Add DT node to carveout memory for shared memory region.
Signed-off-by: Sarangdhar Joshi <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index d6da223..36216ae 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -31,6 +31,17 @@
reg = <0 0 0 0>;
};
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ smem_mem: smem-mem@86000000 {
+ reg = <0x0 0x86000000 0x0 0x200000>;
+ no-map;
+ };
+ };
+
cpus {
#address-cells = <2>;
#size-cells = <0>;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Add reserve-memory nodes required for Qualcomm
Peripheral Image Loaders
Signed-off-by: Sarangdhar Joshi <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 36216ae..949b096 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -36,6 +36,31 @@
#size-cells = <2>;
ranges;
+ mba_region: mba@91500000 {
+ reg = <0x0 0x91500000 0x0 0x200000>;
+ no-map;
+ };
+
+ slpi_region: slpi@90b00000 {
+ reg = <0x0 0x90b00000 0xa00000>;
+ no-map;
+ };
+
+ venus_region: venus@90400000 {
+ reg = <0x0 0x90400000 0x0 0x700000>;
+ no-map;
+ };
+
+ adsp_region: adsp@8ea00000 {
+ reg = <0x0 0x8ea00000 0x0 0x1a00000>;
+ no-map;
+ };
+
+ mpss_region: mpss@88800000 {
+ reg = <0x0 0x88800000 0x0 0x6200000>;
+ no-map;
+ };
+
smem_mem: smem-mem@86000000 {
reg = <0x0 0x86000000 0x0 0x200000>;
no-map;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
From: Bjorn Andersson <[email protected]>
Add SMEM and TCSR DT nodes on MSM8996.
Signed-off-by: Bjorn Andersson <[email protected]>
Signed-off-by: Sarangdhar Joshi <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 949b096..0a810f5 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -169,12 +169,31 @@
method = "smc";
};
+ smem {
+ compatible = "qcom,smem";
+
+ memory-region = <&smem_mem>;
+
+ hwlocks = <&tcsr_mutex 3>;
+ };
+
soc: soc {
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0 0 0xffffffff>;
compatible = "simple-bus";
+ tcsr_mutex_regs: syscon@740000 {
+ compatible = "syscon";
+ reg = <0x740000 0x20000>;
+ };
+
+ tcsr_mutex: hwlock {
+ compatible = "qcom,tcsr-mutex";
+ syscon = <&tcsr_mutex_regs 0 0x1000>;
+ #hwlock-cells = <1>;
+ };
+
intc: interrupt-controller@9bc0000 {
compatible = "arm,gic-v3";
#interrupt-cells = <3>;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Add SMP2P and APCS DT nodes required for Qualcomm ADSP
Peripheral Image Loader.
Signed-off-by: Sarangdhar Joshi <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 0a810f5..3edb56b 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -169,6 +169,31 @@
method = "smc";
};
+ smp2p-adsp {
+ compatible = "qcom,smp2p";
+ qcom,smem = <443>, <429>;
+
+ interrupt-parent = <&intc>;
+ interrupts = <0 158 IRQ_TYPE_EDGE_RISING>;
+
+ qcom,ipc = <&apcs 16 10>;
+
+ qcom,local-pid = <0>;
+ qcom,remote-pid = <2>;
+
+ adsp_smp2p_out: master-kernel {
+ qcom,entry-name = "master-kernel";
+ #qcom,state-cells = <1>;
+ };
+
+ adsp_smp2p_in: slave-kernel {
+ qcom,entry-name = "slave-kernel";
+
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+
smem {
compatible = "qcom,smem";
@@ -205,6 +230,11 @@
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
};
+ apcs: syscon@9820000 {
+ compatible = "syscon";
+ reg = <0x9820000 0x1000>;
+ };
+
gcc: clock-controller@300000 {
compatible = "qcom,gcc-msm8996";
#clock-cells = <1>;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> From: Bjorn Andersson <[email protected]>
>
> Add SMEM and TCSR DT nodes on MSM8996.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> Signed-off-by: Sarangdhar Joshi <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 949b096..0a810f5 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -169,12 +169,31 @@
> method = "smc";
> };
>
> + smem {
> + compatible = "qcom,smem";
> +
> + memory-region = <&smem_mem>;
> +
> + hwlocks = <&tcsr_mutex 3>;
> + };
> +
> soc: soc {
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0 0 0xffffffff>;
> compatible = "simple-bus";
>
> + tcsr_mutex_regs: syscon@740000 {
> + compatible = "syscon";
> + reg = <0x740000 0x20000>;
> + };
> +
> + tcsr_mutex: hwlock {
> + compatible = "qcom,tcsr-mutex";
> + syscon = <&tcsr_mutex_regs 0 0x1000>;
> + #hwlock-cells = <1>;
> + };
Sorry, I got this in the wrong place, the hwlock node should sit outside
of soc {} - looks like we got this wrong in msm8916 as well.
Regards,
Bjorn
> +
> intc: interrupt-controller@9bc0000 {
> compatible = "arm,gic-v3";
> #interrupt-cells = <3>;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> Add reserve-memory nodes required for Qualcomm
> Peripheral Image Loaders
>
Awesome stuff,
Acked-by: Bjorn Andersson <[email protected]>
Regards,
Bjorn
> Signed-off-by: Sarangdhar Joshi <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 36216ae..949b096 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -36,6 +36,31 @@
> #size-cells = <2>;
> ranges;
>
> + mba_region: mba@91500000 {
> + reg = <0x0 0x91500000 0x0 0x200000>;
> + no-map;
> + };
> +
> + slpi_region: slpi@90b00000 {
> + reg = <0x0 0x90b00000 0xa00000>;
> + no-map;
> + };
> +
> + venus_region: venus@90400000 {
> + reg = <0x0 0x90400000 0x0 0x700000>;
> + no-map;
> + };
> +
> + adsp_region: adsp@8ea00000 {
> + reg = <0x0 0x8ea00000 0x0 0x1a00000>;
> + no-map;
> + };
> +
> + mpss_region: mpss@88800000 {
> + reg = <0x0 0x88800000 0x0 0x6200000>;
> + no-map;
> + };
> +
> smem_mem: smem-mem@86000000 {
> reg = <0x0 0x86000000 0x0 0x200000>;
> no-map;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> Add DT node to carveout memory for shared memory region.
>
Reviewed-by: Bjorn Andersson <[email protected]>
Regards,
Bjorn
> Signed-off-by: Sarangdhar Joshi <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index d6da223..36216ae 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -31,6 +31,17 @@
> reg = <0 0 0 0>;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + smem_mem: smem-mem@86000000 {
> + reg = <0x0 0x86000000 0x0 0x200000>;
> + no-map;
> + };
> + };
> +
> cpus {
> #address-cells = <2>;
> #size-cells = <0>;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> Add SMP2P and APCS DT nodes required for Qualcomm ADSP
> Peripheral Image Loader.
>
Nice, two (very) small nits below. But other than that
Acked-by: Bjorn Andersson <[email protected]>
Regards,
Bjorn
> Signed-off-by: Sarangdhar Joshi <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 0a810f5..3edb56b 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -169,6 +169,31 @@
> method = "smc";
> };
>
> + smp2p-adsp {
Sorry for bikeshedding, but on msm8916 I named these {subsystem}-smp2p,
so I would prefer this was naemd adsp-smp2p...
> + compatible = "qcom,smp2p";
> + qcom,smem = <443>, <429>;
> +
> + interrupt-parent = <&intc>;
I believe this node inherit intc as interrupt-parent from the root
already, is there are reason why you need to specify it.
> + interrupts = <0 158 IRQ_TYPE_EDGE_RISING>;
> +
> + qcom,ipc = <&apcs 16 10>;
> +
> + qcom,local-pid = <0>;
> + qcom,remote-pid = <2>;
> +
> + adsp_smp2p_out: master-kernel {
> + qcom,entry-name = "master-kernel";
> + #qcom,state-cells = <1>;
> + };
> +
> + adsp_smp2p_in: slave-kernel {
> + qcom,entry-name = "slave-kernel";
> +
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +
> smem {
> compatible = "qcom,smem";
>
> @@ -205,6 +230,11 @@
> interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + apcs: syscon@9820000 {
> + compatible = "syscon";
> + reg = <0x9820000 0x1000>;
> + };
> +
> gcc: clock-controller@300000 {
> compatible = "qcom,gcc-msm8996";
> #clock-cells = <1>;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
On 10/20/2016 12:57 PM, Bjorn Andersson wrote:
> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>
>> Add DT node to carveout memory for shared memory region.
>>
>
> Reviewed-by: Bjorn Andersson <[email protected]>
Thanks for reviewing.
>
> Regards,
> Bjorn
>
>> Signed-off-by: Sarangdhar Joshi <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index d6da223..36216ae 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -31,6 +31,17 @@
>> reg = <0 0 0 0>;
>> };
>>
>> + reserved-memory {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + smem_mem: smem-mem@86000000 {
>> + reg = <0x0 0x86000000 0x0 0x200000>;
>> + no-map;
>> + };
>> + };
>> +
>> cpus {
>> #address-cells = <2>;
>> #size-cells = <0>;
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On 10/20/2016 12:57 PM, Bjorn Andersson wrote:
> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>
>> Add reserve-memory nodes required for Qualcomm
>> Peripheral Image Loaders
>>
>
> Awesome stuff,
>
> Acked-by: Bjorn Andersson <[email protected]>
Thanks for reviewing.
>
> Regards,
> Bjorn
>
>> Signed-off-by: Sarangdhar Joshi <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index 36216ae..949b096 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -36,6 +36,31 @@
>> #size-cells = <2>;
>> ranges;
>>
>> + mba_region: mba@91500000 {
>> + reg = <0x0 0x91500000 0x0 0x200000>;
>> + no-map;
>> + };
>> +
>> + slpi_region: slpi@90b00000 {
>> + reg = <0x0 0x90b00000 0xa00000>;
>> + no-map;
>> + };
>> +
>> + venus_region: venus@90400000 {
>> + reg = <0x0 0x90400000 0x0 0x700000>;
>> + no-map;
>> + };
>> +
>> + adsp_region: adsp@8ea00000 {
>> + reg = <0x0 0x8ea00000 0x0 0x1a00000>;
>> + no-map;
>> + };
>> +
>> + mpss_region: mpss@88800000 {
>> + reg = <0x0 0x88800000 0x0 0x6200000>;
>> + no-map;
>> + };
>> +
>> smem_mem: smem-mem@86000000 {
>> reg = <0x0 0x86000000 0x0 0x200000>;
>> no-map;
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>
>> From: Bjorn Andersson <[email protected]>
>>
>> Add SMEM and TCSR DT nodes on MSM8996.
>>
>> Signed-off-by: Bjorn Andersson <[email protected]>
>> Signed-off-by: Sarangdhar Joshi <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index 949b096..0a810f5 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -169,12 +169,31 @@
>> method = "smc";
>> };
>>
>> + smem {
>> + compatible = "qcom,smem";
>> +
>> + memory-region = <&smem_mem>;
>> +
>> + hwlocks = <&tcsr_mutex 3>;
>> + };
>> +
>> soc: soc {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> ranges = <0 0 0 0xffffffff>;
>> compatible = "simple-bus";
>>
>> + tcsr_mutex_regs: syscon@740000 {
>> + compatible = "syscon";
>> + reg = <0x740000 0x20000>;
>> + };
>> +
>> + tcsr_mutex: hwlock {
>> + compatible = "qcom,tcsr-mutex";
>> + syscon = <&tcsr_mutex_regs 0 0x1000>;
>> + #hwlock-cells = <1>;
>> + };
>
> Sorry, I got this in the wrong place, the hwlock node should sit outside
> of soc {} - looks like we got this wrong in msm8916 as well.
Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
root)?
>
> Regards,
> Bjorn
>
>> +
>> intc: interrupt-controller@9bc0000 {
>> compatible = "arm,gic-v3";
>> #interrupt-cells = <3>;
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On 10/20/2016 01:03 PM, Bjorn Andersson wrote:
> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>
>> Add SMP2P and APCS DT nodes required for Qualcomm ADSP
>> Peripheral Image Loader.
>>
>
> Nice, two (very) small nits below. But other than that
>
> Acked-by: Bjorn Andersson <[email protected]>
>
> Regards,
> Bjorn
>
>> Signed-off-by: Sarangdhar Joshi <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index 0a810f5..3edb56b 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -169,6 +169,31 @@
>> method = "smc";
>> };
>>
>> + smp2p-adsp {
>
> Sorry for bikeshedding, but on msm8916 I named these {subsystem}-smp2p,
> so I would prefer this was naemd adsp-smp2p...
Sure. Will do.
>
>> + compatible = "qcom,smp2p";
>> + qcom,smem = <443>, <429>;
>> +
>> + interrupt-parent = <&intc>;
>
> I believe this node inherit intc as interrupt-parent from the root
> already, is there are reason why you need to specify it.
>
Good catch. I will remove it.
>> + interrupts = <0 158 IRQ_TYPE_EDGE_RISING>;
>> +
>> + qcom,ipc = <&apcs 16 10>;
>> +
>> + qcom,local-pid = <0>;
>> + qcom,remote-pid = <2>;
>> +
>> + adsp_smp2p_out: master-kernel {
>> + qcom,entry-name = "master-kernel";
>> + #qcom,state-cells = <1>;
>> + };
>> +
>> + adsp_smp2p_in: slave-kernel {
>> + qcom,entry-name = "slave-kernel";
>> +
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> + };
>> +
>> smem {
>> compatible = "qcom,smem";
>>
>> @@ -205,6 +230,11 @@
>> interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>> };
>>
>> + apcs: syscon@9820000 {
>> + compatible = "syscon";
>> + reg = <0x9820000 0x1000>;
>> + };
>> +
>> gcc: clock-controller@300000 {
>> compatible = "qcom,gcc-msm8996";
>> #clock-cells = <1>;
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Thanks for reviewing the patch.
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
> >On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> >
> >>From: Bjorn Andersson <[email protected]>
> >>
> >>Add SMEM and TCSR DT nodes on MSM8996.
> >>
> >>Signed-off-by: Bjorn Andersson <[email protected]>
> >>Signed-off-by: Sarangdhar Joshi <[email protected]>
> >>---
> >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >>
> >>diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>index 949b096..0a810f5 100644
> >>--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>@@ -169,12 +169,31 @@
> >> method = "smc";
> >> };
> >>
> >>+ smem {
> >>+ compatible = "qcom,smem";
> >>+
> >>+ memory-region = <&smem_mem>;
> >>+
> >>+ hwlocks = <&tcsr_mutex 3>;
> >>+ };
> >>+
> >> soc: soc {
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >> ranges = <0 0 0 0xffffffff>;
> >> compatible = "simple-bus";
> >>
> >>+ tcsr_mutex_regs: syscon@740000 {
> >>+ compatible = "syscon";
> >>+ reg = <0x740000 0x20000>;
> >>+ };
> >>+
> >>+ tcsr_mutex: hwlock {
> >>+ compatible = "qcom,tcsr-mutex";
> >>+ syscon = <&tcsr_mutex_regs 0 0x1000>;
> >>+ #hwlock-cells = <1>;
> >>+ };
> >
> >Sorry, I got this in the wrong place, the hwlock node should sit outside
> >of soc {} - looks like we got this wrong in msm8916 as well.
>
> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
> root)?
Yes. Any node that doesn't have reg properties should go under the root.
Andy
On Thu, Oct 20, 2016 at 02:16:41PM -0700, Sarangdhar Joshi wrote:
> On 10/20/2016 12:57 PM, Bjorn Andersson wrote:
> >On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> >
> >>Add DT node to carveout memory for shared memory region.
> >>
> >
> >Reviewed-by: Bjorn Andersson <[email protected]>
>
> Thanks for reviewing.
>
All of the patches looked good. I do agree with Bjorn's comments on the other
patch. When you resend these, please use a cover letter and a V2. I'll then
pick them up for the next pull request.
Thanks for sending these!
Andy
On 10/20/2016 02:51 PM, Andy Gross wrote:
> On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
>> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
>>> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>>>
>>>> From: Bjorn Andersson <[email protected]>
>>>>
>>>> Add SMEM and TCSR DT nodes on MSM8996.
>>>>
>>>> Signed-off-by: Bjorn Andersson <[email protected]>
>>>> Signed-off-by: Sarangdhar Joshi <[email protected]>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
>>>> 1 file changed, 19 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> index 949b096..0a810f5 100644
>>>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> @@ -169,12 +169,31 @@
>>>> method = "smc";
>>>> };
>>>>
>>>> + smem {
>>>> + compatible = "qcom,smem";
>>>> +
>>>> + memory-region = <&smem_mem>;
>>>> +
>>>> + hwlocks = <&tcsr_mutex 3>;
>>>> + };
>>>> +
>>>> soc: soc {
>>>> #address-cells = <1>;
>>>> #size-cells = <1>;
>>>> ranges = <0 0 0 0xffffffff>;
>>>> compatible = "simple-bus";
>>>>
>>>> + tcsr_mutex_regs: syscon@740000 {
>>>> + compatible = "syscon";
>>>> + reg = <0x740000 0x20000>;
>>>> + };
>>>> +
>>>> + tcsr_mutex: hwlock {
>>>> + compatible = "qcom,tcsr-mutex";
>>>> + syscon = <&tcsr_mutex_regs 0 0x1000>;
>>>> + #hwlock-cells = <1>;
>>>> + };
>>>
>>> Sorry, I got this in the wrong place, the hwlock node should sit outside
>>> of soc {} - looks like we got this wrong in msm8916 as well.
>>
>> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
>> root)?
>
> Yes. Any node that doesn't have reg properties should go under the root.
>
Got it. Will update the patch(es) and add cover letter. Thanks.
>
> Andy
>
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project