2016-11-15 08:30:24

by Shiva Kerdel

Subject: [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16'

After following a discussion about the used integer types Dan Carpenter
pointed out that 'int' types should be used over the current change to
's16'. The reason for this is to have an upper bound instead of overflowing
the 's16' so we could still remove devices.

Signed-off-by: Shiva Kerdel <[email protected]>
Suggested-by: Stuart Yoder <[email protected]>
Suggested-by: Dan Carpenter <[email protected]>
---
drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/include/mc-bus.h b/drivers/staging/fsl-mc/include/mc-bus.h
index c7cad87..42700de 100644
--- a/drivers/staging/fsl-mc/include/mc-bus.h
+++ b/drivers/staging/fsl-mc/include/mc-bus.h
@@ -42,8 +42,8 @@ struct msi_domain_info;
*/
struct fsl_mc_resource_pool {
enum fsl_mc_pool_type type;
- s16 max_count;
- s16 free_count;
+ int max_count;
+ int free_count;
struct mutex mutex; /* serializes access to free_list */
struct list_head free_list;
struct fsl_mc_bus *mc_bus;
--
2.10.2

2016-11-15 10:02:11

by Greg Kroah-Hartman

Subject: Re: [PATCH][RESPIN] Staging: fsl-mc: include: mc: Kernel type 'int' preferred over 's16'

On Tue, Nov 15, 2016 at 09:30:03AM +0100, Shiva Kerdel wrote:
> After following a discussion about the used integer types Dan Carpenter
> pointed out that 'int' types should be used over the current change to
> 's16'. The reason for this is to have an upper bound instead of overflowing
> the 's16' so we could still remove devices.
>
> Signed-off-by: Shiva Kerdel <[email protected]>
> Suggested-by: Stuart Yoder <[email protected]>
> Suggested-by: Dan Carpenter <[email protected]>
> ---
> drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

In the future, don't do [RESPIN] as that means nothing to me, and is
just noise...

thanks,

greg k-h