This selects the respective helpers required in addition to the one
Arnd Bergmann pointer out earlier.
Signed-off-by: Robin van der Gracht <[email protected]>
---
This is a responce to https://lkml.org/lkml/2016/11/25/66
This patch complements the changes Arnd submitted earlier.
drivers/auxdisplay/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index b8bbfc6..4ef4c5c 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -132,6 +132,9 @@ config HT16K33
tristate "Holtek Ht16K33 LED controller with keyscan"
depends on FB && OF && I2C && INPUT
select FB_SYS_FOPS
+ select FB_CFB_FILLRECT
+ select FB_CFB_COPYAREA
+ select FB_CFB_IMAGEBLIT
select INPUT_MATRIXKMAP
select FB_BACKLIGHT
help
--
2.7.4
On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> This selects the respective helpers required in addition to the one
> Arnd Bergmann pointer out earlier.
>
> Signed-off-by: Robin van der Gracht <[email protected]>
> ---
> This is a responce to https://lkml.org/lkml/2016/11/25/66
> This patch complements the changes Arnd submitted earlier.
>
> drivers/auxdisplay/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index b8bbfc6..4ef4c5c 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -132,6 +132,9 @@ config HT16K33
> tristate "Holtek Ht16K33 LED controller with keyscan"
> depends on FB && OF && I2C && INPUT
> select FB_SYS_FOPS
> + select FB_CFB_FILLRECT
> + select FB_CFB_COPYAREA
> + select FB_CFB_IMAGEBLIT
> select INPUT_MATRIXKMAP
> select FB_BACKLIGHT
> help
What tree is this patch against?
thanks,
greg k-h
On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> > This selects the respective helpers required in addition to the one
> > Arnd Bergmann pointer out earlier.
> >
> > Signed-off-by: Robin van der Gracht <[email protected]>
> > ---
> > This is a responce to https://lkml.org/lkml/2016/11/25/66
> > This patch complements the changes Arnd submitted earlier.
> >
> > drivers/auxdisplay/Kconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > index b8bbfc6..4ef4c5c 100644
> > --- a/drivers/auxdisplay/Kconfig
> > +++ b/drivers/auxdisplay/Kconfig
> > @@ -132,6 +132,9 @@ config HT16K33
> > tristate "Holtek Ht16K33 LED controller with keyscan"
> > depends on FB && OF && I2C && INPUT
> > select FB_SYS_FOPS
> > + select FB_CFB_FILLRECT
> > + select FB_CFB_COPYAREA
> > + select FB_CFB_IMAGEBLIT
> > select INPUT_MATRIXKMAP
> > select FB_BACKLIGHT
> > help
>
> What tree is this patch against?
>
> thanks,
>
> greg k-h
>
It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS"
from a few days ago. I guess Robin expected you to have picked that
up, while you expected him to combine it with the new changes.
Robin, I think it's easier if you send the combined patch and
add "Reported-by: Arnd Bergmann <[email protected]>", as Greg has
probably already droppped my earlier patch from his queue.
Arnd
On Tue, Nov 29, 2016 at 08:55:50PM +0100, Arnd Bergmann wrote:
> On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> > On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> > > This selects the respective helpers required in addition to the one
> > > Arnd Bergmann pointer out earlier.
> > >
> > > Signed-off-by: Robin van der Gracht <[email protected]>
> > > ---
> > > This is a responce to https://lkml.org/lkml/2016/11/25/66
> > > This patch complements the changes Arnd submitted earlier.
> > >
> > > drivers/auxdisplay/Kconfig | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > > index b8bbfc6..4ef4c5c 100644
> > > --- a/drivers/auxdisplay/Kconfig
> > > +++ b/drivers/auxdisplay/Kconfig
> > > @@ -132,6 +132,9 @@ config HT16K33
> > > tristate "Holtek Ht16K33 LED controller with keyscan"
> > > depends on FB && OF && I2C && INPUT
> > > select FB_SYS_FOPS
> > > + select FB_CFB_FILLRECT
> > > + select FB_CFB_COPYAREA
> > > + select FB_CFB_IMAGEBLIT
> > > select INPUT_MATRIXKMAP
> > > select FB_BACKLIGHT
> > > help
> >
> > What tree is this patch against?
> >
> > thanks,
> >
> > greg k-h
> >
>
> It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS"
> from a few days ago. I guess Robin expected you to have picked that
> up, while you expected him to combine it with the new changes.
>
> Robin, I think it's easier if you send the combined patch and
> add "Reported-by: Arnd Bergmann <[email protected]>", as Greg has
> probably already droppped my earlier patch from his queue.
Yes, it's not in my queue anymore.
thanks,
greg k-h
On Tue, 29 Nov 2016 21:04:30 +0100
Greg Kroah-Hartman <[email protected]> wrote:
> On Tue, Nov 29, 2016 at 08:55:50PM +0100, Arnd Bergmann wrote:
> > On Tuesday, November 29, 2016 8:42:47 PM CET Greg Kroah-Hartman wrote:
> > > On Fri, Nov 25, 2016 at 10:50:07AM +0100, Robin van der Gracht wrote:
> > > > This selects the respective helpers required in addition to the one
> > > > Arnd Bergmann pointer out earlier.
> > > >
> > > > Signed-off-by: Robin van der Gracht <[email protected]>
> > > > ---
> > > > This is a responce to https://lkml.org/lkml/2016/11/25/66
> > > > This patch complements the changes Arnd submitted earlier.
> > > >
> > > > drivers/auxdisplay/Kconfig | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> > > > index b8bbfc6..4ef4c5c 100644
> > > > --- a/drivers/auxdisplay/Kconfig
> > > > +++ b/drivers/auxdisplay/Kconfig
> > > > @@ -132,6 +132,9 @@ config HT16K33
> > > > tristate "Holtek Ht16K33 LED controller with keyscan"
> > > > depends on FB && OF && I2C && INPUT
> > > > select FB_SYS_FOPS
> > > > + select FB_CFB_FILLRECT
> > > > + select FB_CFB_COPYAREA
> > > > + select FB_CFB_IMAGEBLIT
> > > > select INPUT_MATRIXKMAP
> > > > select FB_BACKLIGHT
> > > > help
> > >
> > > What tree is this patch against?
> > >
> > > thanks,
> > >
> > > greg k-h
> > >
> >
> > It's on top of my patch "auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS"
> > from a few days ago. I guess Robin expected you to have picked that
> > up, while you expected him to combine it with the new changes.
> >
> > Robin, I think it's easier if you send the combined patch and
> > add "Reported-by: Arnd Bergmann <[email protected]>", as Greg has
> > probably already droppped my earlier patch from his queue.
>
> Yes, it's not in my queue anymore.
>
> thanks,
>
> greg k-h
I'll create a new patch.
Regards,
Robin