2016-11-30 16:54:33

by Grygorii Strashko

Subject: [PATCH v2] soc: ti: qmss: fix the case when !SMP

The irq_set_affinity_hint() will always fail when !SMP and
Networking will fail on Keystone 2 devices in this case.
Hence, fix by ignoring IRQ affinity settings when !SMP.

Cc: Arnd Bergmann <[email protected]>
Signed-off-by: Grygorii Strashko <[email protected]>
---
drivers/soc/ti/knav_qmss_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index b73e353..eacad57 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,

range->num_irqs++;

- if (oirq.args_count == 3)
+ if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
range->irqs[i].cpu_map =
(oirq.args[2] & 0x0000ff00) >> 8;
}
--
2.10.1

2016-11-30 17:09:45

by Grygorii Strashko

Subject: Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP

+ Santosh Shilimkar <[email protected]>

On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
> The irq_set_affinity_hint() will always fail when !SMP and
> Networking will fail on Keystone 2 devices in this case.
> Hence, fix by ignoring IRQ affinity settings when !SMP.
>
> Cc: Arnd Bergmann <[email protected]>
> Signed-off-by: Grygorii Strashko <[email protected]>
> ---
> drivers/soc/ti/knav_qmss_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b73e353..eacad57 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
>
> range->num_irqs++;
>
> - if (oirq.args_count == 3)
> + if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
> range->irqs[i].cpu_map =
> (oirq.args[2] & 0x0000ff00) >> 8;
> }
>

--
regards,
-grygorii

2016-11-30 17:14:08

by Santosh Shilimkar

Subject: Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP

Hi Anrd,

Can you apply this to your non critical fixes queue ?

On 11/30/2016 9:09 AM, Grygorii Strashko wrote:
> + Santosh Shilimkar <[email protected]>
>
> On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
>> The irq_set_affinity_hint() will always fail when !SMP and
>> Networking will fail on Keystone 2 devices in this case.
>> Hence, fix by ignoring IRQ affinity settings when !SMP.
>>
>> Cc: Arnd Bergmann <[email protected]>
>> Signed-off-by: Grygorii Strashko <[email protected]>
>> ---
Acked-by: Santosh Shilimkar <[email protected]>

>> drivers/soc/ti/knav_qmss_queue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>> b/drivers/soc/ti/knav_qmss_queue.c
>> index b73e353..eacad57 100644
>> --- a/drivers/soc/ti/knav_qmss_queue.c
>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct
>> knav_device *kdev,
>>
>> range->num_irqs++;
>>
>> - if (oirq.args_count == 3)
>> + if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
>> range->irqs[i].cpu_map =
>> (oirq.args[2] & 0x0000ff00) >> 8;
>> }
>>
>

2016-11-30 21:11:51

by Arnd Bergmann

Subject: Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP

On Wednesday, November 30, 2016 9:13:44 AM CET Santosh Shilimkar wrote:
>
> Can you apply this to your non critical fixes queue ?
>
> On 11/30/2016 9:09 AM, Grygorii Strashko wrote:
> > + Santosh Shilimkar <[email protected]>
> >
> > On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
> >> The irq_set_affinity_hint() will always fail when !SMP and
> >> Networking will fail on Keystone 2 devices in this case.
> >> Hence, fix by ignoring IRQ affinity settings when !SMP.
> >>
> >> Cc: Arnd Bergmann <[email protected]>
> >> Signed-off-by: Grygorii Strashko <[email protected]>
> >> ---
> Acked-by: Santosh Shilimkar <[email protected]>
>
>

Applied, thanks!

Arnd