On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote:
> Parantheses are added for Macro argument, to avoid precedence issues.
>
> Signed-off-by: Rishiraj Manwatkar <[email protected]>
> ---
> v1 -> v2: Added mailing list in cc.
> v2 -> v3: Changed From: to be same as Signed-off-by:.
> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ee7d677..0997254 100755
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -52,9 +52,9 @@
> */
>
> #define cl_io_for_each(slice, io) \
> - list_for_each_entry((slice), &io->ci_layers, cis_linkage)
> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)
Really? There is no precedence issues that I can see here, sorry.
thanks,
greg k-h
On Apr 18, 2017, at 09:50, [email protected] wrote:
>
> On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote:
>> Subject: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
(typo) s/Parantheses/parenthesis/ s/Macro/macro/
The Subject line (excluding [PATCH] part) should be under 60
>> Parantheses are added for Macro argument, to avoid precedence issues.
Should be something like:
Subject: [PATCH v4 1/2] staging/lustre: add parenthesis to macro arguments
Add parenthesis to cl_io_for_each() macro to avoid potential issues with
unexpected argument expansion in CPP.
>> Signed-off-by: Rishiraj Manwatkar <[email protected]>
>> ---
>> v1 -> v2: Added mailing list in cc.
>> v2 -> v3: Changed From: to be same as Signed-off-by:.
>> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
>> index ee7d677..0997254 100755
>> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
>> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
>> @@ -52,9 +52,9 @@
>> */
>>
>> #define cl_io_for_each(slice, io) \
>> - list_for_each_entry((slice), &io->ci_layers, cis_linkage)
>> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)
>
> Really? There is no precedence issues that I can see here, sorry.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation