2017-06-26 12:42:54

by Jonathan Liu

Subject: [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

The LCD0 controller on the A20 can do RGB output up to 8 bits per
channel. Add the pins for RGB888 output.

Signed-off-by: Jonathan Liu <[email protected]>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 96bee776e145..09a0e89bed11 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1183,6 +1183,17 @@
function = "ir1";
};

+ lcd0_rgb888_pins: lcd0_rgb888@0 {
+ allwinner,pins = "PD0", "PD1", "PD2", "PD3",
+ "PD4", "PD5", "PD6", "PD7",
+ "PD8", "PD9", "PD10", "PD11",
+ "PD12", "PD13", "PD14", "PD15",
+ "PD16", "PD17", "PD18", "PD19",
+ "PD20", "PD21", "PD22", "PD23",
+ "PD24", "PD25", "PD26", "PD27";
+ allwinner,function = "lcd0";
+ };
+
mmc0_pins_a: mmc0@0 {
pins = "PF0", "PF1", "PF2",
"PF3", "PF4", "PF5";
--
2.13.1

2017-06-26 12:48:05

by Jonathan Liu

Subject: Re: [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

Hi Emmanuel,

On 26 June 2017 at 22:45, Emmanuel Vadot <[email protected]> wrote:
> On Mon, 26 Jun 2017 22:42:49 +1000
> Jonathan Liu <[email protected]> wrote:
>
>> The LCD0 controller on the A20 can do RGB output up to 8 bits per
>> channel. Add the pins for RGB888 output.
>>
>> Signed-off-by: Jonathan Liu <[email protected]>
>> ---
>> arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
>> index 96bee776e145..09a0e89bed11 100644
>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>> @@ -1183,6 +1183,17 @@
>> function = "ir1";
>> };
>>
>> + lcd0_rgb888_pins: lcd0_rgb888@0 {
>> + allwinner,pins = "PD0", "PD1", "PD2", "PD3",
>> + "PD4", "PD5", "PD6", "PD7",
>> + "PD8", "PD9", "PD10", "PD11",
>> + "PD12", "PD13", "PD14", "PD15",
>> + "PD16", "PD17", "PD18", "PD19",
>> + "PD20", "PD21", "PD22", "PD23",
>> + "PD24", "PD25", "PD26", "PD27";
>> + allwinner,function = "lcd0";
>> + };
>> +
>
> We switch to standard pinctrl bindings so you need to use 'pins' and
> 'function' (i.e. without the 'allwinner,' prefix).
>

Thanks, I will change it for V2.

>> mmc0_pins_a: mmc0@0 {
>> pins = "PF0", "PF1", "PF2",
>> "PF3", "PF4", "PF5";
>> --
>> 2.13.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> [email protected]
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
> --
> Emmanuel Vadot <[email protected]> <[email protected]>

Regards,
Jonathan

2017-06-26 12:52:42

by Emmanuel Vadot

Subject: Re: [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

On Mon, 26 Jun 2017 22:42:49 +1000
Jonathan Liu <[email protected]> wrote:

> The LCD0 controller on the A20 can do RGB output up to 8 bits per
> channel. Add the pins for RGB888 output.
>
> Signed-off-by: Jonathan Liu <[email protected]>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 96bee776e145..09a0e89bed11 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1183,6 +1183,17 @@
> function = "ir1";
> };
>
> + lcd0_rgb888_pins: lcd0_rgb888@0 {
> + allwinner,pins = "PD0", "PD1", "PD2", "PD3",
> + "PD4", "PD5", "PD6", "PD7",
> + "PD8", "PD9", "PD10", "PD11",
> + "PD12", "PD13", "PD14", "PD15",
> + "PD16", "PD17", "PD18", "PD19",
> + "PD20", "PD21", "PD22", "PD23",
> + "PD24", "PD25", "PD26", "PD27";
> + allwinner,function = "lcd0";
> + };
> +

We switch to standard pinctrl bindings so you need to use 'pins' and
'function' (i.e. without the 'allwinner,' prefix).

> mmc0_pins_a: mmc0@0 {
> pins = "PF0", "PF1", "PF2",
> "PF3", "PF4", "PF5";
> --
> 2.13.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


--
Emmanuel Vadot <[email protected]> <[email protected]>