Include the OF-based modalias in the uevent sent when registering SPMI
devices, so that user space has a chance to autoload the kernel module
for the device.
Reported-by: Rob Clark <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
---
Based on the MODULE_ALIAS in the qcom-spmi-pmic it's likely that the original
author expected that the spmi-pmic-arb would create devices by the identifier
"pmic" and the spmi code would include a MODALIAS="spmi:pmic" in the uevent.
drivers/spmi/spmi.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 2b9b0941d9eb..6d23226e5f69 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -365,11 +365,23 @@ static int spmi_drv_remove(struct device *dev)
return 0;
}
+static int spmi_drv_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+ int ret;
+
+ ret = of_device_uevent_modalias(dev, env);
+ if (ret != -ENODEV)
+ return ret;
+
+ return 0;
+}
+
static struct bus_type spmi_bus_type = {
.name = "spmi",
.match = spmi_device_match,
.probe = spmi_drv_probe,
.remove = spmi_drv_remove,
+ .uevent = spmi_drv_uevent,
};
/**
--
2.12.0
On Wed, Jun 28, 2017 at 7:44 PM, Bjorn Andersson
<[email protected]> wrote:
> Include the OF-based modalias in the uevent sent when registering SPMI
> devices, so that user space has a chance to autoload the kernel module
> for the device.
>
> Reported-by: Rob Clark <[email protected]>
> Signed-off-by: Bjorn Andersson <[email protected]>
Tested-by: Rob Clark <[email protected]>
> ---
>
> Based on the MODULE_ALIAS in the qcom-spmi-pmic it's likely that the original
> author expected that the spmi-pmic-arb would create devices by the identifier
> "pmic" and the spmi code would include a MODALIAS="spmi:pmic" in the uevent.
>
> drivers/spmi/spmi.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
> index 2b9b0941d9eb..6d23226e5f69 100644
> --- a/drivers/spmi/spmi.c
> +++ b/drivers/spmi/spmi.c
> @@ -365,11 +365,23 @@ static int spmi_drv_remove(struct device *dev)
> return 0;
> }
>
> +static int spmi_drv_uevent(struct device *dev, struct kobj_uevent_env *env)
> +{
> + int ret;
> +
> + ret = of_device_uevent_modalias(dev, env);
> + if (ret != -ENODEV)
> + return ret;
> +
> + return 0;
> +}
> +
> static struct bus_type spmi_bus_type = {
> .name = "spmi",
> .match = spmi_device_match,
> .probe = spmi_drv_probe,
> .remove = spmi_drv_remove,
> + .uevent = spmi_drv_uevent,
> };
>
> /**
> --
> 2.12.0
>
On 06/28, Bjorn Andersson wrote:
> Include the OF-based modalias in the uevent sent when registering SPMI
> devices, so that user space has a chance to autoload the kernel module
> for the device.
>
> Reported-by: Rob Clark <[email protected]>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
I suppose we can delete the MODALIAS in the qcom-spmi-pmic file
too? That doesn't look like it could ever work
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
On Thu 29 Jun 14:04 PDT 2017, Stephen Boyd wrote:
> On 06/28, Bjorn Andersson wrote:
> > Include the OF-based modalias in the uevent sent when registering SPMI
> > devices, so that user space has a chance to autoload the kernel module
> > for the device.
> >
> > Reported-by: Rob Clark <[email protected]>
> > Signed-off-by: Bjorn Andersson <[email protected]>
> > ---
>
> Reviewed-by: Stephen Boyd <[email protected]>
>
> I suppose we can delete the MODALIAS in the qcom-spmi-pmic file
> too? That doesn't look like it could ever work
>
Right, it has never worked. Potentially we would like some SPMI based
modalias thing, but I'm not sure we have enough information about the
found device to create a meaningful alias.
Regards,
Bjorn