2017-07-21 16:13:54

by Arnd Bergmann

[permalink] [raw]

Subject: [PATCH] drm: tegra: add CONFIG_OF dependency

---

Without CONFIG_OF, we can run into a build error:

drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
.dt_node_to_map = pinconf_generic_dt_node_to_map_group,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pinconf_generic_params
drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?

This adds an explicit dependency.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/gpu/drm/tegra/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
index 2db29d67193d..dc58ab140151 100644
--- a/drivers/gpu/drm/tegra/Kconfig
+++ b/drivers/gpu/drm/tegra/Kconfig
@@ -3,6 +3,7 @@ config DRM_TEGRA
depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
depends on COMMON_CLK
depends on DRM
+ depends on OF
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL
--
2.9.0

2017-07-25 08:26:04

by Jon Hunter

[permalink] [raw]

Subject: Re: [PATCH] drm: tegra: add CONFIG_OF dependency

---

On 21/07/17 17:13, Arnd Bergmann wrote:
> Without CONFIG_OF, we can run into a build error:
>
> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pinconf_generic_params
> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>
> This adds an explicit dependency.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/gpu/drm/tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
> index 2db29d67193d..dc58ab140151 100644
> --- a/drivers/gpu/drm/tegra/Kconfig
> +++ b/drivers/gpu/drm/tegra/Kconfig
> @@ -3,6 +3,7 @@ config DRM_TEGRA
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> depends on COMMON_CLK
> depends on DRM
> + depends on OF
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL

Thanks Arnd. I am curious if it can still fail if PINCTRL is not
selected in whatever config you are using?

That said ...

Acked-by: Jon Hunter <[email protected]>

Cheers
Jon

--
nvpublic

2017-07-25 11:54:04

by Arnd Bergmann

[permalink] [raw]

Subject: Re: [PATCH] drm: tegra: add CONFIG_OF dependency

---

On Tue, Jul 25, 2017 at 10:25 AM, Jon Hunter <[email protected]> wrote:
>
> On 21/07/17 17:13, Arnd Bergmann wrote:
>> Without CONFIG_OF, we can run into a build error:
>>
>> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> pinconf_generic_params
>> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>>
>> This adds an explicit dependency.
>>
>> Signed-off-by: Arnd Bergmann <[email protected]>
>> ---
>> drivers/gpu/drm/tegra/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
>> index 2db29d67193d..dc58ab140151 100644
>> --- a/drivers/gpu/drm/tegra/Kconfig
>> +++ b/drivers/gpu/drm/tegra/Kconfig
>> @@ -3,6 +3,7 @@ config DRM_TEGRA
>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>> depends on COMMON_CLK
>> depends on DRM
>> + depends on OF
>> select DRM_KMS_HELPER
>> select DRM_MIPI_DSI
>> select DRM_PANEL
>
> Thanks Arnd. I am curious if it can still fail if PINCTRL is not
> selected in whatever config you are using?

I have not run into other those problems in many randconfig builds.
Looking at the driver now, I see it has an "#ifdef CONFIG_GENERIC_PINCONF"
to handle that case.

Arnd

2017-08-17 15:20:18

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH] drm: tegra: add CONFIG_OF dependency

---

On Fri, Jul 21, 2017 at 06:13:23PM +0200, Arnd Bergmann wrote:
> Without CONFIG_OF, we can run into a build error:
>
> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pinconf_generic_params
> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>
> This adds an explicit dependency.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/gpu/drm/tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

Thierry

---

Attachments:

(No filename) (792.00 B)
signature.asc (833.00 B)
Download all attachments