2017-12-05 06:44:33

by wanglong

Subject: [PATCH] writeback: fix comment in __mark_inode_dirty

Signed-off-by: Wang Long <[email protected]>
---
fs/fs-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index cea4836..8d477cf 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
trace_writeback_dirty_inode_enqueue(inode);

/*
- * If this is the first dirty inode for this bdi,
+ * If this is the first dirty inode for this wb,
* we have to wake-up the corresponding bdi thread
* to make sure background write-back happens
* later.
--
1.8.3.1

2017-12-05 15:48:39

by Tejun Heo

Subject: Re: [PATCH] writeback: fix comment in __mark_inode_dirty

Hello, Wang.

On Tue, Dec 05, 2017 at 12:52:54AM -0500, Wang Long wrote:
> Signed-off-by: Wang Long <[email protected]>
> ---
> fs/fs-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index cea4836..8d477cf 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
> trace_writeback_dirty_inode_enqueue(inode);
>
> /*
> - * If this is the first dirty inode for this bdi,
> + * If this is the first dirty inode for this wb,

Acked-by: Tejun Heo <[email protected]>

This probably should go through the block tree tho. Please cc Jens
Axboe.

Thanks.

--
tejun

2017-12-06 02:35:32

by wanglong

Subject: Re: [PATCH] writeback: fix comment in __mark_inode_dirty

Cc: Jens Axboe

> On 5 Dec 2017, at 11:48 PM, [email protected] wrote:
>
> Hello, Wang.
>
> On Tue, Dec 05, 2017 at 12:52:54AM -0500, Wang Long wrote:
>> Signed-off-by: Wang Long <[email protected]>
>> ---
>> fs/fs-writeback.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
>> index cea4836..8d477cf 100644
>> --- a/fs/fs-writeback.c
>> +++ b/fs/fs-writeback.c
>> @@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>> trace_writeback_dirty_inode_enqueue(inode);
>>
>> /*
>> - * If this is the first dirty inode for this bdi,
>> + * If this is the first dirty inode for this wb,
>
> Acked-by: Tejun Heo <[email protected]>
>
> This probably should go through the block tree tho. Please cc Jens
> Axboe.
>
> Thanks.
>
> --
> tejun