2017-12-06 14:23:26

by Tobias Jordan

Subject: [PATCH] net: mvmdio: disable/unprepare clocks in EPROBE_DEFER case

add appropriate calls to clk_disable_unprepare() by jumping to out_mdio
in case orion_mdio_probe() returns -EPROBE_DEFER.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 3d604da1e954 net: mvmdio: get and enable optional clock
Signed-off-by: Tobias Jordan <[email protected]>
---
drivers/net/ethernet/marvell/mvmdio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
index c9798210fa0f..0495487f7b42 100644
--- a/drivers/net/ethernet/marvell/mvmdio.c
+++ b/drivers/net/ethernet/marvell/mvmdio.c
@@ -344,7 +344,8 @@ static int orion_mdio_probe(struct platform_device *pdev)
dev->regs + MVMDIO_ERR_INT_MASK);

} else if (dev->err_interrupt == -EPROBE_DEFER) {
- return -EPROBE_DEFER;
+ ret = -EPROBE_DEFER;
+ goto out_mdio;
}

if (pdev->dev.of_node)
--
2.11.0

2017-12-06 16:03:59

by Andrew Lunn

Subject: Re: [PATCH] net: mvmdio: disable/unprepare clocks in EPROBE_DEFER case

On Wed, Dec 06, 2017 at 03:23:23PM +0100, Tobias Jordan wrote:
> add appropriate calls to clk_disable_unprepare() by jumping to out_mdio
> in case orion_mdio_probe() returns -EPROBE_DEFER.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Fixes: 3d604da1e954 net: mvmdio: get and enable optional clock
> Signed-off-by: Tobias Jordan <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Thanks Tobais

Andrew

2017-12-07 18:41:41

by David Miller

Subject: Re: [PATCH] net: mvmdio: disable/unprepare clocks in EPROBE_DEFER case

From: Tobias Jordan <[email protected]>
Date: Wed, 6 Dec 2017 15:23:23 +0100

> add appropriate calls to clk_disable_unprepare() by jumping to out_mdio
> in case orion_mdio_probe() returns -EPROBE_DEFER.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Fixes: 3d604da1e954 net: mvmdio: get and enable optional clock
> Signed-off-by: Tobias Jordan <[email protected]>

Applied, but please in the future format your Fixes: tag properly.

You need to put the commit message header line inside of parenthesis
and double quotes, like this:

Fixes: 3d604da1e954 ("net: mvmdio: get and enable optional clock")