2018-01-15 18:20:41

by Luis de Bethencourt

[permalink] [raw]
Subject: [PATCH] ALSA: pcm: Fix trailing semicolon

From: Ubuntu <[email protected]>

The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.

Signed-off-by: Luis de Bethencourt <[email protected]>
---


Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].

Best regards
Luis


[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

sound/core/pcm_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 3f13e8da0812..51104df924e1 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
struct vm_area_struct *area)
{
- struct snd_pcm_runtime *runtime = substream->runtime;;
+ struct snd_pcm_runtime *runtime = substream->runtime;

area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
--
2.15.1


2018-01-15 19:18:46

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] ALSA: pcm: Fix trailing semicolon

On Mon, 15 Jan 2018 19:18:57 +0100,
Luis de Bethencourt wrote:
>
> From: Ubuntu <[email protected]>

Is this from address intentional? It'd be taken as is via git-am.


thanks,

Takashi

> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
>
>
> Hi,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> sound/core/pcm_native.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index 3f13e8da0812..51104df924e1 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
> int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
> struct vm_area_struct *area)
> {
> - struct snd_pcm_runtime *runtime = substream->runtime;;
> + struct snd_pcm_runtime *runtime = substream->runtime;
>
> area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
> return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
> --
> 2.15.1
>
>

2018-01-16 13:28:42

by Luis de Bethencourt

[permalink] [raw]
Subject: Re: [PATCH] ALSA: pcm: Fix trailing semicolon

On 01/15/2018 07:18 PM, Takashi Iwai wrote:
> On Mon, 15 Jan 2018 19:18:57 +0100,
> Luis de Bethencourt wrote:
>>
>> From: Ubuntu <[email protected]>
>
> Is this from address intentional? It'd be taken as is via git-am.
>
>
> thanks,
>
> Takashi
>
>> The trailing semicolon is an empty statement that does no operation.
>> Removing it since it doesn't do anything.
>>
>> Signed-off-by: Luis de Bethencourt <[email protected]>
>> ---
>>
>>
>> Hi,
>>
>> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
>> suggested I fix it treewide [0].
>>
>> Best regards
>> Luis
>>
>>
>> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
>> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>>
>> sound/core/pcm_native.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
>> index 3f13e8da0812..51104df924e1 100644
>> --- a/sound/core/pcm_native.c
>> +++ b/sound/core/pcm_native.c
>> @@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
>> int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
>> struct vm_area_struct *area)
>> {
>> - struct snd_pcm_runtime *runtime = substream->runtime;;
>> + struct snd_pcm_runtime *runtime = substream->runtime;
>>
>> area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
>> return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
>> --
>> 2.15.1
>>
>>

Hi Takashi,

Sorry. Not sure how git send-email added that line to the commit message.
I have sent a v2 correcting it.

Thanks,
Luis