2018-01-15 13:30:23

by Michal Suchánek

[permalink] [raw]
Subject: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
settings") uses u64 in asm/hvcall.h without including linux/types.h

This breaks hvcall.h users that do not include the header themselves.

Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
settings")

Signed-off-by: Michal Suchanek <[email protected]>
---
arch/powerpc/include/asm/hvcall.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
index f0461618bf7b..eca3f9c68907 100644
--- a/arch/powerpc/include/asm/hvcall.h
+++ b/arch/powerpc/include/asm/hvcall.h
@@ -353,6 +353,7 @@
#define PROC_TABLE_GTSE 0x01

#ifndef __ASSEMBLY__
+#include <linux/types.h>

/**
* plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
--
2.13.6


2018-01-16 03:17:01

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

Michal Suchanek <[email protected]> writes:

> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings")
>
> Signed-off-by: Michal Suchanek <[email protected]>
> ---
> arch/powerpc/include/asm/hvcall.h | 1 +
> 1 file changed, 1 insertion(+)

Thanks. None of my ~250 defconfig test builds hit this, what config are
you using?

cheers

> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> index f0461618bf7b..eca3f9c68907 100644
> --- a/arch/powerpc/include/asm/hvcall.h
> +++ b/arch/powerpc/include/asm/hvcall.h
> @@ -353,6 +353,7 @@
> #define PROC_TABLE_GTSE 0x01
>
> #ifndef __ASSEMBLY__
> +#include <linux/types.h>
>
> /**
> * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
> --
> 2.13.6

2018-01-16 04:53:55

by David Gibson

[permalink] [raw]
Subject: Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

On Tue, Jan 16, 2018 at 02:16:58PM +1100, Michael Ellerman wrote:
> Michal Suchanek <[email protected]> writes:
>
> > Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> > settings") uses u64 in asm/hvcall.h without including linux/types.h
> >
> > This breaks hvcall.h users that do not include the header themselves.
> >
> > Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> > settings")
> >
> > Signed-off-by: Michal Suchanek <[email protected]>
> > ---
> > arch/powerpc/include/asm/hvcall.h | 1 +
> > 1 file changed, 1 insertion(+)
>
> Thanks. None of my ~250 defconfig test builds hit this, what config are
> you using?

I also hit this, but only when I backported the change to RH's 3.10
kernel. I assumed something since then had added an indirect include.

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachments:
(No filename) (0.98 kB)
 signature.asc (833.00 B)
 Download all attachments

2018-01-17 13:26:04

by Michael Ellerman

[permalink] [raw]
Subject: Re: powerpc/pseries: include linux/types.h in asm/hvcall.h

On Mon, 2018-01-15 at 13:30:03 UTC, Michal Suchanek wrote:
> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings")
>
> Signed-off-by: Michal Suchanek <[email protected]>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/1b689a95ce7427075f9ac9fb4aea1a

cheers