2018-02-14 14:32:49

by Schenk, Gavin

Subject: [PATCH] siox: fix possible buffer overflow in device_add_store

Width 20 given in format string is larger than destination
buffer 'type[20]', use %19s to prevent overflowing it.

Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
Reported-by: David Binderman <[email protected]>
Signed-off-by: Gavin Schenk <[email protected]>
---
drivers/siox/siox-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index fdfcdea25867..16590dfaafa4 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -594,7 +594,7 @@ static ssize_t device_add_store(struct device *dev,
size_t inbytes = 0, outbytes = 0;
u8 statustype = 0;

- ret = sscanf(buf, "%20s %zu %zu %hhu", type, &inbytes,
+ ret = sscanf(buf, "%19s %zu %zu %hhu", type, &inbytes,
&outbytes, &statustype);
if (ret != 3 && ret != 4)
return -EINVAL;
--
2.15.1


--
Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa
Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
http://www.eckelmann.de

2018-02-14 20:10:12

by Uwe Kleine-König

Subject: Re: [PATCH] siox: fix possible buffer overflow in device_add_store

Hello,

On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> Width 20 given in format string is larger than destination
> buffer 'type[20]', use %19s to prevent overflowing it.
>
> Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> Reported-by: David Binderman <[email protected]>
> Signed-off-by: Gavin Schenk <[email protected]>
Reviewed-by: Uwe Kleine-K?nig <[email protected]>

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |

2018-03-02 15:47:37

by Uwe Kleine-König

Subject: Re: [PATCH] siox: fix possible buffer overflow in device_add_store

Hello Greg,

On Wed, Feb 14, 2018 at 06:00:21PM +0100, Uwe Kleine-K?nig wrote:
> On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> > Width 20 given in format string is larger than destination
> > buffer 'type[20]', use %19s to prevent overflowing it.
> >
> > Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> > Reported-by: David Binderman <[email protected]>
> > Signed-off-by: Gavin Schenk <[email protected]>
> Reviewed-by: Uwe Kleine-K?nig <[email protected]>

is this patch still in your patch queue? The patch didn't appear in next
yet.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |