The checks are misleading and not required [1].
[1] https://lkml.org/lkml/2018/3/19/1792
Addresses-Coverity-ID: 1466017
Cc: Chris Wilson <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/gpu/drm/i915/gvt/scheduler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index 78588ef..b6da223 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -74,7 +74,7 @@ static void sr_oa_regs(struct intel_vgpu_workload *workload,
i915_mmio_reg_offset(EU_PERF_CNTL6),
};
- if (!workload || !reg_state || workload->ring_id != RCS)
+ if (workload->ring_id != RCS)
return;
if (save) {
--
2.7.4
Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
> The checks are misleading and not required [1].
>
> [1] https://lkml.org/lkml/2018/3/19/1792
>
> Addresses-Coverity-ID: 1466017
> Cc: Chris Wilson <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>
Zhenyu?
-Chris
On 2018.03.22 21:31:33 +0000, Chris Wilson wrote:
> Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
> > The checks are misleading and not required [1].
> >
> > [1] https://lkml.org/lkml/2018/3/19/1792
> >
> > Addresses-Coverity-ID: 1466017
> > Cc: Chris Wilson <[email protected]>
> > Signed-off-by: Gustavo A. R. Silva <[email protected]>
> Reviewed-by: Chris Wilson <[email protected]>
>
Looks good to me, I will pick this up, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827