2018-07-18 13:11:10

by Gustavo A. R. Silva

Subject: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

The use of the | operator always leads to true, which looks rather
suspect in this case.

Fix this by using & instead.

Addresses-Coverity-ID: 1471903 ("Wrong operator used")
Fixes: dba1d918da02 ("net: mvpp2: debugfs: add entries for classifier flows")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
index 02dfef1..f9744a6 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
@@ -245,7 +245,7 @@ static int mvpp2_dbgfs_flow_c2_enable_show(struct seq_file *s, void *unused)

mvpp2_cls_c2_read(port->priv, MVPP22_CLS_C2_RSS_ENTRY(port->id), &c2);

- enabled = !!(c2.attr[2] | MVPP22_CLS_C2_ATTR2_RSS_EN);
+ enabled = !!(c2.attr[2] & MVPP22_CLS_C2_ATTR2_RSS_EN);

seq_printf(s, "%d\n", enabled);

--
2.7.4

2018-07-18 14:10:32

by Maxime Chevallier

Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

Hi Gustavo,

On Wed, 18 Jul 2018 08:08:46 -0500
"Gustavo A. R. Silva" <[email protected]> wrote:

>The use of the | operator always leads to true, which looks rather
>suspect in this case.
>
>Fix this by using & instead.
>

Acked-by: Maxime Chevallier <[email protected]>

Good catch, thanks.

Maxime

2018-07-18 14:33:44

by Gustavo A. R. Silva

Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

Hey Maxime,

On 07/18/2018 09:09 AM, Maxime Chevallier wrote:
> Hi Gustavo,
>
> On Wed, 18 Jul 2018 08:08:46 -0500
> "Gustavo A. R. Silva" <[email protected]> wrote:
>
>> The use of the | operator always leads to true, which looks rather
>> suspect in this case.
>>
>> Fix this by using & instead.
>>
>
> Acked-by: Maxime Chevallier <[email protected]>
>
> Good catch, thanks.
>

Glad to help. :)

Thanks
--
Gustavo

2018-07-18 17:57:03

by David Miller

Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 18 Jul 2018 08:08:46 -0500

> The use of the | operator always leads to true, which looks rather
> suspect in this case.
>
> Fix this by using & instead.
>
> Addresses-Coverity-ID: 1471903 ("Wrong operator used")
> Fixes: dba1d918da02 ("net: mvpp2: debugfs: add entries for classifier flows")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied, thanks.