2018-09-07 17:09:20

by jun qian

Subject: [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback

As you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: jun qian <[email protected]>
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index a8b9fbab5f73..084c983ec3c2 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -2075,10 +2075,10 @@ static void nfp_ctrl_poll(unsigned long arg)
{
struct nfp_net_r_vector *r_vec = (void *)arg;

- spin_lock_bh(&r_vec->lock);
+ spin_lock(&r_vec->lock);
nfp_net_tx_complete(r_vec->tx_ring, 0);
__nfp_ctrl_tx_queued(r_vec);
- spin_unlock_bh(&r_vec->lock);
+ spin_unlock(&r_vec->lock);

nfp_ctrl_rx(r_vec);

--
2.17.1

2018-09-07 17:43:48

by Jakub Kicinski

Subject: Re: [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback

On Fri, 7 Sep 2018 10:01:09 -0700, jun qian wrote:
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <[email protected]>

Acked-by: Jakub Kicinski <[email protected]>

2018-09-08 05:57:54

by David Miller

Subject: Re: [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback

From: jun qian <[email protected]>
Date: Fri, 7 Sep 2018 10:01:09 -0700

> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <[email protected]>

Applied to net-next, thanks.