LinuxLists.cc - [PATCH v2] mtd: rawnand: remove ->legacy.erase and single

2019-01-21 07:13:53

Subject: [PATCH v2] mtd: rawnand: remove ->legacy.erase and single_erase()

Now that the last user of this hook, denali.c, stopped using it,
we can remove the erase hook from nand_legacy.

I squashed single_erase() because only the difference between
single_erase() and nand_erase_op() is the number of bit shifts.

The status/ret conversion in nand_erase_nand() is unneeded since
commit eb94555e9e97 ("mtd: nand: use usual return values for the
->erase() hook"). Cleaned it up now.

Signed-off-by: Masahiro Yamada <[email protected]>
---

This depends on the denali patch:
http://patchwork.ozlabs.org/patch/1028264/

Changes in v2:
- I noticed the masking by chip->pagemask is still needed

drivers/mtd/nand/raw/nand_base.c | 31 ++++---------------------------
include/linux/mtd/rawnand.h | 2 --
2 files changed, 4 insertions(+), 29 deletions(-)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index cca4b24..7ea3f10 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -4155,23 +4155,6 @@ static int nand_write_oob(struct mtd_info *mtd, loff_t to,
}

/**
- * single_erase - [GENERIC] NAND standard block erase command function
- * @chip: NAND chip object
- * @page: the page address of the block which will be erased
- *
- * Standard erase command for NAND chips. Returns NAND status.
- */
-static int single_erase(struct nand_chip *chip, int page)
-{
- unsigned int eraseblock;
-
- /* Send commands to erase a block */
- eraseblock = page >> (chip->phys_erase_shift - chip->page_shift);
-
- return nand_erase_op(chip, eraseblock);
-}
-
-/**
* nand_erase - [MTD Interface] erase block(s)
* @mtd: MTD device structure
* @instr: erase instruction
@@ -4194,7 +4177,7 @@ static int nand_erase(struct mtd_info *mtd, struct erase_info *instr)
int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,
int allowbbt)
{
- int page, status, pages_per_block, ret, chipnr;
+ int page, pages_per_block, ret, chipnr;
loff_t len;

pr_debug("%s: start = 0x%012llx, len = %llu\n",
@@ -4246,17 +4229,11 @@ int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,
(page + pages_per_block))
chip->pagebuf = -1;

- if (chip->legacy.erase)
- status = chip->legacy.erase(chip,
- page & chip->pagemask);
- else
- status = single_erase(chip, page & chip->pagemask);
-
- /* See if block erase succeeded */
- if (status) {
+ ret = nand_erase_op(chip, (page & chip->pagemask) >>
+ (chip->phys_erase_shift - chip->page_shift));
+ if (ret) {
pr_debug("%s: failed erase, page 0x%08x\n",
__func__, page);
- ret = -EIO;
instr->fail_addr =
((loff_t)page << chip->page_shift);
goto erase_exit;
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index 33e240a..5e37534 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -936,7 +936,6 @@ static inline void nand_controller_init(struct nand_controller *nfc)
* @waitfunc: hardware specific function for wait on ready.
* @block_bad: check if a block is bad, using OOB markers
* @block_markbad: mark a block bad
- * @erase: erase function
* @set_features: set the NAND chip features
* @get_features: get the NAND chip features
* @chip_delay: chip dependent delay for transferring data from array to read
@@ -962,7 +961,6 @@ struct nand_legacy {
int (*waitfunc)(struct nand_chip *chip);
int (*block_bad)(struct nand_chip *chip, loff_t ofs);
int (*block_markbad)(struct nand_chip *chip, loff_t ofs);
- int (*erase)(struct nand_chip *chip, int page);
int (*set_features)(struct nand_chip *chip, int feature_addr,
u8 *subfeature_para);
int (*get_features)(struct nand_chip *chip, int feature_addr,
--
2.7.4

2019-01-21 08:14:46

by Boris Brezillon

[permalink] [raw]

Subject: Re: [PATCH v2] mtd: rawnand: remove ->legacy.erase and single_erase()

On Mon, 21 Jan 2019 15:32:07 +0900
Masahiro Yamada <[email protected]> wrote:

> Now that the last user of this hook, denali.c, stopped using it,
> we can remove the erase hook from nand_legacy.
>
> I squashed single_erase() because only the difference between
> single_erase() and nand_erase_op() is the number of bit shifts.
>
> The status/ret conversion in nand_erase_nand() is unneeded since
> commit eb94555e9e97 ("mtd: nand: use usual return values for the
> ->erase() hook"). Cleaned it up now.

Yeah! One less field in nand_legacy :-).

>
> Signed-off-by: Masahiro Yamada <[email protected]>

Reviewed-by: Boris Brezillon <[email protected]>

> ---
>
> This depends on the denali patch:
> http://patchwork.ozlabs.org/patch/1028264/
>
>
> Changes in v2:
> - I noticed the masking by chip->pagemask is still needed
>
> drivers/mtd/nand/raw/nand_base.c | 31 ++++---------------------------
> include/linux/mtd/rawnand.h | 2 --
> 2 files changed, 4 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index cca4b24..7ea3f10 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -4155,23 +4155,6 @@ static int nand_write_oob(struct mtd_info *mtd, loff_t to,
> }
>
> /**
> - * single_erase - [GENERIC] NAND standard block erase command function
> - * @chip: NAND chip object
> - * @page: the page address of the block which will be erased
> - *
> - * Standard erase command for NAND chips. Returns NAND status.
> - */
> -static int single_erase(struct nand_chip *chip, int page)
> -{
> - unsigned int eraseblock;
> -
> - /* Send commands to erase a block */
> - eraseblock = page >> (chip->phys_erase_shift - chip->page_shift);
> -
> - return nand_erase_op(chip, eraseblock);
> -}
> -
> -/**
> * nand_erase - [MTD Interface] erase block(s)
> * @mtd: MTD device structure
> * @instr: erase instruction
> @@ -4194,7 +4177,7 @@ static int nand_erase(struct mtd_info *mtd, struct erase_info *instr)
> int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,
> int allowbbt)
> {
> - int page, status, pages_per_block, ret, chipnr;
> + int page, pages_per_block, ret, chipnr;
> loff_t len;
>
> pr_debug("%s: start = 0x%012llx, len = %llu\n",
> @@ -4246,17 +4229,11 @@ int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,
> (page + pages_per_block))
> chip->pagebuf = -1;
>
> - if (chip->legacy.erase)
> - status = chip->legacy.erase(chip,
> - page & chip->pagemask);
> - else
> - status = single_erase(chip, page & chip->pagemask);
> -
> - /* See if block erase succeeded */
> - if (status) {
> + ret = nand_erase_op(chip, (page & chip->pagemask) >>
> + (chip->phys_erase_shift - chip->page_shift));
> + if (ret) {
> pr_debug("%s: failed erase, page 0x%08x\n",
> __func__, page);
> - ret = -EIO;
> instr->fail_addr =
> ((loff_t)page << chip->page_shift);
> goto erase_exit;
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 33e240a..5e37534 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -936,7 +936,6 @@ static inline void nand_controller_init(struct nand_controller *nfc)
> * @waitfunc: hardware specific function for wait on ready.
> * @block_bad: check if a block is bad, using OOB markers
> * @block_markbad: mark a block bad
> - * @erase: erase function
> * @set_features: set the NAND chip features
> * @get_features: get the NAND chip features
> * @chip_delay: chip dependent delay for transferring data from array to read
> @@ -962,7 +961,6 @@ struct nand_legacy {
> int (*waitfunc)(struct nand_chip *chip);
> int (*block_bad)(struct nand_chip *chip, loff_t ofs);
> int (*block_markbad)(struct nand_chip *chip, loff_t ofs);
> - int (*erase)(struct nand_chip *chip, int page);
> int (*set_features)(struct nand_chip *chip, int feature_addr,
> u8 *subfeature_para);
> int (*get_features)(struct nand_chip *chip, int feature_addr,

2019-01-21 23:32:31

by kernel test robot

[permalink] [raw]

Subject: Re: [PATCH v2] mtd: rawnand: remove ->legacy.erase and single_erase()

Hi Masahiro,

I love your patch! Yet something
[auto build test ERROR on [if your patch is applied
url: # save the attached GCC_VERSION=8.2.0
All errors (new ones prefixed
drivers/mtd/nand/raw/denali.c: >> drivers/mtd/nand/raw/denali.c:1247:14: chip->legacy.erase ^

vim +1247 drivers/mtd/nand/raw/denali.c
6da27b469 drivers/mtd/nand/denali.c d03af162b drivers/mtd/nand/raw/denali.c ce082596a drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c d03af162b drivers/mtd/nand/raw/denali.c 2a0a288ec drivers/mtd/nand/denali.c ce082596a drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c e07caa368 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c e07caa368 drivers/mtd/nand/denali.c e07caa368 drivers/mtd/nand/denali.c 26d266e10 drivers/mtd/nand/denali.c 997cde2a2 drivers/mtd/nand/denali.c 997cde2a2 drivers/mtd/nand/denali.c 89dcb27b0 drivers/mtd/nand/denali.c 89dcb27b0 drivers/mtd/nand/denali.c 89dcb27b0 drivers/mtd/nand/denali.c 89dcb27b0 drivers/mtd/nand/denali.c 66406524e drivers/mtd/nand/denali.c 66406524e drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c 777f2d49e drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c d99d72829 drivers/mtd/nand/denali.c f9801fda9 drivers/mtd/nand/raw/denali.c f9801fda9 drivers/mtd/nand/raw/denali.c 7de117fd5 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c d03af162b drivers/mtd/nand/raw/denali.c ce082596a drivers/mtd/nand/denali.c ce082596a drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c e0d53b3f8 drivers/mtd/nand/denali.c e0d53b3f8 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 0615e7ad5 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 0615e7ad5 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c a3750a642 drivers/mtd/nand/denali.c a3750a642 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c 0d3a966d2 drivers/mtd/nand/denali.c 7de117fd5 drivers/mtd/nand/denali.c 14fad62b6 drivers/mtd/nand/denali.c db9a32104 drivers/mtd/nand/denali.c fa6134e54 drivers/mtd/nand/denali.c 716bbbabc drivers/mtd/nand/raw/denali.c 716bbbabc drivers/mtd/nand/raw/denali.c fa6134e54 drivers/mtd/nand/denali.c 716bbbabc drivers/mtd/nand/raw/denali.c 716bbbabc drivers/mtd/nand/raw/denali.c fa6134e54 drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c 1394a7265 drivers/mtd/nand/denali.c f9ebd1bb4 drivers/mtd/nand/raw/denali.c ce082596a drivers/mtd/nand/denali.c e93c1640e drivers/mtd/nand/denali.c e93c1640e drivers/mtd/nand/denali.c d03af162b drivers/mtd/nand/raw/denali.c 6da27b469 drivers/mtd/nand/denali.c 7d370b2c2 drivers/mtd/nand/denali.c 7d370b2c2 drivers/mtd/nand/denali.c 7d370b2c2 drivers/mtd/nand/denali.c 7d370b2c2 drivers/mtd/nand/denali.c 7d370b2c2 drivers/mtd/nand/denali.c 7d370b2c2 drivers/mtd/nand/denali.c d03af162b drivers/mtd/nand/raw/denali.c d03af162b drivers/mtd/nand/raw/denali.c d03af162b drivers/mtd/nand/raw/denali.c d03af162b drivers/mtd/nand/raw/denali.c d03af162b drivers/mtd/nand/raw/denali.c d03af162b drivers/mtd/nand/raw/denali.c
:::::: The code at line 1247 :::::: f9ebd1bb41031afc162e9acda7ad044a35bccf82
:::::: TO: Boris Brezillon :::::: CC: Miquel Raynal ---
0-DAY kernel test infrastructure https://github.com/0day-ci/linux/commits/Masahiro-Yamada/mtd-rawnand-remove-legacy-erase-and-single_erase/20190122-040438
as .config)
(Debian 8.2.0-11) 8.2.0
githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
.config to linux build tree
make.cross ARCH=sh
by >>):
In function 'denali_attach_chip':
error: 'struct nand_legacy' has no member named 'erase'
= denali_erase;
/> Masahiro Yamada 2017-03-23 1168
Miquel Raynal 2018-07-20 1169 static int denali_attach_chip(struct nand_chip *chip)
Jason Roberts 2010-05-13 1170 {
Masahiro Yamada 2017-03-23 1171 struct mtd_info *mtd = nand_to_mtd(chip);
Miquel Raynal 2018-07-20 1172 struct denali_nand_info *denali = mtd_to_denali(mtd);
Dinh Nguyen 2012-09-27 1173 int ret;
Jason Roberts 2010-05-13 1174
Masahiro Yamada 2017-06-16 1175 if (ioread32(denali->reg + FEATURES) & FEATURES__DMA)
Masahiro Yamada 2017-06-13 1176 denali->dma_avail = 1;
Masahiro Yamada 2017-06-13 1177
Masahiro Yamada 2017-06-13 1178 if (denali->dma_avail) {
Masahiro Yamada 2017-06-13 1179 int dma_bit = denali->caps & DENALI_CAP_DMA_64BIT ? 64 : 32;
Masahiro Yamada 2017-06-13 1180
Masahiro Yamada 2017-06-13 1181 ret = dma_set_mask(denali->dev, DMA_BIT_MASK(dma_bit));
Huang Shijie 2013-12-21 1182 if (ret) {
Masahiro Yamada 2017-06-13 1183 dev_info(denali->dev,
Masahiro Yamada 2017-06-13 1184 "Failed to set DMA mask. Disabling DMA.\n");
Masahiro Yamada 2017-06-13 1185 denali->dma_avail = 0;
Masahiro Yamada 2017-06-13 1186 }
Huang Shijie 2013-12-21 1187 }
Huang Shijie 2013-12-21 1188
Masahiro Yamada 2017-06-13 1189 if (denali->dma_avail) {
Masahiro Yamada 2017-06-13 1190 chip->options |= NAND_USE_BOUNCE_BUFFER;
Masahiro Yamada 2017-06-13 1191 chip->buf_align = 16;
Masahiro Yamada 2017-09-22 1192 if (denali->caps & DENALI_CAP_DMA_64BIT)
Masahiro Yamada 2017-09-22 1193 denali->setup_dma = denali_setup_dma64;
Masahiro Yamada 2017-09-22 1194 else
Masahiro Yamada 2017-09-22 1195 denali->setup_dma = denali_setup_dma32;
Chuanxiao.Dong 2010-08-06 1196 }
Chuanxiao.Dong 2010-08-06 1197
Masahiro Yamada 2017-03-23 1198 chip->bbt_options |= NAND_BBT_USE_FLASH;
Masahiro Yamada 2017-06-13 1199 chip->bbt_options |= NAND_BBT_NO_OOB;
Masahiro Yamada 2017-03-23 1200 chip->ecc.mode = NAND_ECC_HW_SYNDROME;
Masahiro Yamada 2017-03-23 1201 chip->options |= NAND_NO_SUBPAGE_WRITE;
Graham Moore 2015-01-14 1202
Abhishek Sahu 2018-06-20 1203 ret = nand_ecc_choose_conf(chip, denali->ecc_caps,
Abhishek Sahu 2018-06-20 1204 mtd->oobsize - denali->oob_skip_bytes);
Masahiro Yamada 2017-06-07 1205 if (ret) {
Masahiro Yamada 2017-06-07 1206 dev_err(denali->dev, "Failed to setup ECC settings.\n");
Miquel Raynal 2018-07-20 1207 return ret;
Jason Roberts 2010-05-13 1208 }
Jason Roberts 2010-05-13 1209
Masahiro Yamada 2017-06-07 1210 dev_dbg(denali->dev,
Masahiro Yamada 2017-06-07 1211 "chosen ECC settings: step=%d, strength=%d, bytes=%d\n",
Masahiro Yamada 2017-06-07 1212 chip->ecc.size, chip->ecc.strength, chip->ecc.bytes);
Masahiro Yamada 2017-06-07 1213
Masahiro Yamada 2017-09-22 1214 iowrite32(FIELD_PREP(ECC_CORRECTION__ERASE_THRESHOLD, 1) |
Masahiro Yamada 2017-09-22 1215 FIELD_PREP(ECC_CORRECTION__VALUE, chip->ecc.strength),
Masahiro Yamada 2017-06-16 1216 denali->reg + ECC_CORRECTION);
Masahiro Yamada 2017-06-07 1217 iowrite32(mtd->erasesize / mtd->writesize,
Masahiro Yamada 2017-06-16 1218 denali->reg + PAGES_PER_BLOCK);
Masahiro Yamada 2017-06-07 1219 iowrite32(chip->options & NAND_BUSWIDTH_16 ? 1 : 0,
Masahiro Yamada 2017-06-16 1220 denali->reg + DEVICE_WIDTH);
Masahiro Yamada 2017-09-13 1221 iowrite32(chip->options & NAND_ROW_ADDR_3 ? 0 : TWO_ROW_ADDR_CYCLES__FLAG,
Masahiro Yamada 2017-09-13 1222 denali->reg + TWO_ROW_ADDR_CYCLES);
Masahiro Yamada 2017-06-16 1223 iowrite32(mtd->writesize, denali->reg + DEVICE_MAIN_AREA_SIZE);
Masahiro Yamada 2017-06-16 1224 iowrite32(mtd->oobsize, denali->reg + DEVICE_SPARE_AREA_SIZE);
Masahiro Yamada 2017-06-07 1225
Masahiro Yamada 2017-06-16 1226 iowrite32(chip->ecc.size, denali->reg + CFG_DATA_BLOCK_SIZE);
Masahiro Yamada 2017-06-16 1227 iowrite32(chip->ecc.size, denali->reg + CFG_LAST_DATA_BLOCK_SIZE);
Masahiro Yamada 2017-06-07 1228 /* chip->ecc.steps is set by nand_scan_tail(); not available here */
Masahiro Yamada 2017-06-07 1229 iowrite32(mtd->writesize / chip->ecc.size,
Masahiro Yamada 2017-06-16 1230 denali->reg + CFG_NUM_DATA_BLOCKS);
Masahiro Yamada 2017-06-07 1231
Boris Brezillon 2016-02-03 1232 mtd_set_ooblayout(mtd, &denali_ooblayout_ops);
Chuanxiao Dong 2010-08-06 1233
Masahiro Yamada 2017-06-13 1234 if (chip->options & NAND_BUSWIDTH_16) {
Boris Brezillon 2018-09-07 1235 chip->legacy.read_buf = denali_read_buf16;
Boris Brezillon 2018-09-07 1236 chip->legacy.write_buf = denali_write_buf16;
Masahiro Yamada 2017-06-13 1237 } else {
Boris Brezillon 2018-09-07 1238 chip->legacy.read_buf = denali_read_buf;
Boris Brezillon 2018-09-07 1239 chip->legacy.write_buf = denali_write_buf;
Masahiro Yamada 2017-06-13 1240 }
Masahiro Yamada 2017-03-23 1241 chip->ecc.read_page = denali_read_page;
Masahiro Yamada 2017-03-23 1242 chip->ecc.read_page_raw = denali_read_page_raw;
Masahiro Yamada 2017-03-23 1243 chip->ecc.write_page = denali_write_page;
Masahiro Yamada 2017-03-23 1244 chip->ecc.write_page_raw = denali_write_page_raw;
Masahiro Yamada 2017-03-23 1245 chip->ecc.read_oob = denali_read_oob;
Masahiro Yamada 2017-03-23 1246 chip->ecc.write_oob = denali_write_oob;
Boris Brezillon 2018-09-07 @1247 chip->legacy.erase = denali_erase;
Jason Roberts 2010-05-13 1248
Masahiro Yamada 2017-03-23 1249 ret = denali_multidev_fixup(denali);
Masahiro Yamada 2017-03-23 1250 if (ret)
Miquel Raynal 2018-07-20 1251 return ret;
Masahiro Yamada 2017-03-23 1252
Masahiro Yamada 2017-06-13 1253 /*
Masahiro Yamada 2017-06-13 1254 * This buffer is DMA-mapped by denali_{read,write}_page_raw. Do not
Masahiro Yamada 2017-06-13 1255 * use devm_kmalloc() because the memory allocated by devm_ does not
Masahiro Yamada 2017-06-13 1256 * guarantee DMA-safe alignment.
Masahiro Yamada 2017-06-13 1257 */
Masahiro Yamada 2017-06-13 1258 denali->buf = kmalloc(mtd->writesize + mtd->oobsize, GFP_KERNEL);
Miquel Raynal 2018-07-20 1259 if (!denali->buf)
Miquel Raynal 2018-07-20 1260 return -ENOMEM;
Miquel Raynal 2018-07-20 1261
Miquel Raynal 2018-07-20 1262 return 0;
Miquel Raynal 2018-07-20 1263 }
Miquel Raynal 2018-07-20 1264
was first introduced by commit
mtd: rawnand: Deprecate ->erase()
<[email protected]>
href="/cdn-cgi/l/email-protection#6d4b01195600041c180801431f0c14030c012d0f020219010403430e02004b0a1956"><[email protected]>
Open Source Technology Center
rmail/kbuild-all">https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachments:

(No filename) (11.47 kB)
.config.gz (49.81 kB)
Download all attachments

2019-01-25 12:38:13

by Miquel Raynal

[permalink] [raw]

Subject: Re: [PATCH v2] mtd: rawnand: remove ->legacy.erase and single_erase()

Hi Masahiro,

Masahiro Yamada <[email protected]> wrote on Mon, 21 Jan
2019 15:32:07 +0900:

> Now that the last user of this hook, denali.c, stopped using it,
> we can remove the erase hook from nand_legacy.
>
> I squashed single_erase() because only the difference between
> single_erase() and nand_erase_op() is the number of bit shifts.
>
> The status/ret conversion in nand_erase_nand() is unneeded since
> commit eb94555e9e97 ("mtd: nand: use usual return values for the
> ->erase() hook"). Cleaned it up now.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

Applied to nand/next.

Thanks,
Miquèl