2019-02-12 11:30:46

by Colin King

Subject: [PATCH][next] RDMA: fix allocation failure on pointer pd

From: Colin Ian King <[email protected]>

The null check on an allocation failure on pd is currently checking
if pd is non-null rather than null. Fix this by adding the missing !
operator.

Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
index a18b88c95995..77c3678f4829 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
@@ -745,7 +745,7 @@ static int hns_roce_v1_rsv_lp_qp(struct hns_roce_dev *hr_dev)

ibdev = &hr_dev->ib_dev;
pd = rdma_zalloc_drv_obj(ibdev, ib_pd);
- if (pd)
+ if (!pd)
goto alloc_mem_failed;

pd->device = ibdev;
--
2.20.1

2019-02-12 11:33:48

by Leon Romanovsky

Subject: Re: [PATCH][next] RDMA: fix allocation failure on pointer pd

On Tue, Feb 12, 2019 at 11:22:33AM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The null check on an allocation failure on pd is currently checking
> if pd is non-null rather than null. Fix this by adding the missing !
> operator.
>
> Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks a lot,
Reviewed-by: Leon Romanovsky <[email protected]>

2019-02-12 21:45:42

by Jason Gunthorpe

Subject: Re: [PATCH][next] RDMA: fix allocation failure on pointer pd

On Tue, Feb 12, 2019 at 11:22:33AM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The null check on an allocation failure on pd is currently checking
> if pd is non-null rather than null. Fix this by adding the missing !
> operator.
>
> Fixes: 21a428a019c9 ("RDMA: Handle PD allocations by IB/core")
> Signed-off-by: Colin Ian King <[email protected]>
> Reviewed-by: Leon Romanovsky <[email protected]>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks applied to for-next

Regards,
Jason