2019-02-15 15:38:32

by Maxime Chevallier

Subject: [PATCH net-next] net: phy: marvell10g: Don't explicitly set Pause and Asym_Pause

The PHY core expects PHY drivers not to set Pause and Asym_Pause bits,
unless the driver only wants to specify one of them due to HW
limitation. In the case of the Marvell10g driver, we don't need to set
them.

Signed-off-by: Maxime Chevallier <[email protected]>
Suggested-by: Andrew Lunn <[email protected]>
---
drivers/net/phy/marvell10g.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
index 496805c0ddfe..c04fe5a75129 100644
--- a/drivers/net/phy/marvell10g.c
+++ b/drivers/net/phy/marvell10g.c
@@ -242,9 +242,6 @@ static int mv3310_config_init(struct phy_device *phydev)
phydev->interface != PHY_INTERFACE_MODE_10GKR)
return -ENODEV;

- __set_bit(ETHTOOL_LINK_MODE_Pause_BIT, phydev->supported);
- __set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT, phydev->supported);
-
if (phydev->c45_ids.devices_in_package & MDIO_DEVS_AN) {
val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_STAT1);
if (val < 0)
--
2.19.2

2019-02-15 16:18:03

by Andrew Lunn

Subject: Re: [PATCH net-next] net: phy: marvell10g: Don't explicitly set Pause and Asym_Pause

On Fri, Feb 15, 2019 at 09:33:47AM +0100, Maxime Chevallier wrote:
> The PHY core expects PHY drivers not to set Pause and Asym_Pause bits,
> unless the driver only wants to specify one of them due to HW
> limitation. In the case of the Marvell10g driver, we don't need to set
> them.
>
> Signed-off-by: Maxime Chevallier <[email protected]>
> Suggested-by: Andrew Lunn <[email protected]>

Thanks Maxime

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2019-02-17 23:34:39

by David Miller

Subject: Re: [PATCH net-next] net: phy: marvell10g: Don't explicitly set Pause and Asym_Pause

From: Maxime Chevallier <[email protected]>
Date: Fri, 15 Feb 2019 09:33:47 +0100

> The PHY core expects PHY drivers not to set Pause and Asym_Pause bits,
> unless the driver only wants to specify one of them due to HW
> limitation. In the case of the Marvell10g driver, we don't need to set
> them.
>
> Signed-off-by: Maxime Chevallier <[email protected]>
> Suggested-by: Andrew Lunn <[email protected]>

Applied, thanks.