2019-04-29 17:39:57

by Gustavo A. R. Silva

Subject: [PATCH net-next] netdevsim: fix fall-through annotation

Replace "pass through" with a proper "fall through" annotation
in order to fix the following warning:

drivers/net/netdevsim/bus.c: In function ‘new_device_store’:
drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
port_count = 1;
~~~~~~~~~~~^~~
drivers/net/netdevsim/bus.c:172:2: note: here
case 2:
^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This fix is part of the ongoing efforts to enable
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/netdevsim/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c
index ae482347b67b..fd68eeac574c 100644
--- a/drivers/net/netdevsim/bus.c
+++ b/drivers/net/netdevsim/bus.c
@@ -168,7 +168,7 @@ new_device_store(struct bus_type *bus, const char *buf, size_t count)
switch (err) {
case 1:
port_count = 1;
- /* pass through */
+ /* fall through */
case 2:
if (id > INT_MAX) {
pr_err("Value of \"id\" is too big.\n");
--
2.21.0

2019-04-30 00:41:52

by Jakub Kicinski

Subject: Re: [PATCH net-next] netdevsim: fix fall-through annotation

On Mon, 29 Apr 2019 12:38:07 -0500, Gustavo A. R. Silva wrote:
> Replace "pass through" with a proper "fall through" annotation
> in order to fix the following warning:
>
> drivers/net/netdevsim/bus.c: In function ‘new_device_store’:
> drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
> port_count = 1;
> ~~~~~~~~~~~^~~
> drivers/net/netdevsim/bus.c:172:2: note: here
> case 2:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This fix is part of the ongoing efforts to enable
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Acked-by: Jakub Kicinski <[email protected]>

2019-05-01 15:38:33

by David Miller

Subject: Re: [PATCH net-next] netdevsim: fix fall-through annotation

From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 29 Apr 2019 12:38:07 -0500

> Replace "pass through" with a proper "fall through" annotation
> in order to fix the following warning:
>
> drivers/net/netdevsim/bus.c: In function ?new_device_store?:
> drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
> port_count = 1;
> ~~~~~~~~~~~^~~
> drivers/net/netdevsim/bus.c:172:2: note: here
> case 2:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This fix is part of the ongoing efforts to enable
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied.