2019-06-15 10:37:54

by Wei Yongjun

Subject: [PATCH -next] coresight: replicator: Add terminate entry for acpi_device_id tables

Make sure acpi_device_id tables have terminate entry.

Fixes: 8f35caae1e1f ("coresight: acpi: Support for platform devices")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/hwtracing/coresight/coresight-replicator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 542952759941..0c73dc1073c0 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
#ifdef CONFIG_ACPI
static const struct acpi_device_id static_replicator_acpi_ids[] = {
{"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
+ {"", 0},
};
#endif

2019-06-17 08:25:51

by Suzuki K Poulose

Subject: Re: [PATCH -next] coresight: replicator: Add terminate entry for acpi_device_id tables

Hi

Thanks for the fix, please find my comment below.

On 15/06/2019 11:44, Wei Yongjun wrote:
> Make sure acpi_device_id tables have terminate entry.
>
> Fixes: 8f35caae1e1f ("coresight: acpi: Support for platform devices")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 542952759941..0c73dc1073c0 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id static_replicator_acpi_ids[] = {
> {"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
> + {"", 0},

nit: I would leave it {}, instead of creating an empty string.

With that :

Reviewed-by: Suzuki K Poulose <[email protected]>

2019-06-17 09:16:09

by Wei Yongjun

Subject: [PATCH -next v2] coresight: replicator: Add terminate entry for acpi_device_id tables

Make sure acpi_device_id tables have terminate entry.

Fixes: fe446287ec9f ("coresight: acpi: Support for platform devices")
Signed-off-by: Wei Yongjun <[email protected]>
Reviewed-by: Suzuki K Poulose <[email protected]>
---
drivers/hwtracing/coresight/coresight-replicator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 542952759941..b7d6d59d56db 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
#ifdef CONFIG_ACPI
static const struct acpi_device_id static_replicator_acpi_ids[] = {
{"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
+ {}
};
#endif

2019-06-18 16:57:47

by Mathieu Poirier

Subject: Re: [PATCH -next v2] coresight: replicator: Add terminate entry for acpi_device_id tables

On Mon, 17 Jun 2019 at 03:15, Wei Yongjun <[email protected]> wrote:
>
> Make sure acpi_device_id tables have terminate entry.
>
> Fixes: fe446287ec9f ("coresight: acpi: Support for platform devices")
> Signed-off-by: Wei Yongjun <[email protected]>
> Reviewed-by: Suzuki K Poulose <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 542952759941..b7d6d59d56db 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -300,6 +300,7 @@ static const struct of_device_id static_replicator_match[] = {
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id static_replicator_acpi_ids[] = {
> {"ARMHC985", 0}, /* ARM CoreSight Static Replicator */
> + {}

Applied - thanks

> };
> #endif
>
>
>