From: Yue Hu <[email protected]>
Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().
Signed-off-by: Yue Hu <[email protected]>
Reviewed-by: Gao Xiang <[email protected]>
Reviewed-by: Chao Yu <[email protected]>
---
no change
drivers/staging/erofs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index e51348f..d6e1e16 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
struct erofs_sb_info *sbi = EROFS_I_SB(inode);
const int mode = vi->datamode;
- DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
-
/* should be inode inline C */
if (mode != EROFS_INODE_LAYOUT_INLINE)
return 0;
--
1.9.1
On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu <[email protected]>
> Reviewed-by: Gao Xiang <[email protected]>
> Reviewed-by: Chao Yu <[email protected]>
> ---
> no change
>
> drivers/staging/erofs/inode.c | 2 --
> 1 file changed, 2 deletions(-)
This is already in my tree, right?
confused,
greg k-h
On Wed, 3 Jul 2019 18:20:38 +0200
Greg KH <[email protected]> wrote:
> On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
> > From: Yue Hu <[email protected]>
> >
> > Already check if ->datamode is supported in read_inode(), no need to check
> > again in the next fill_inline_data() only called by fill_inode().
> >
> > Signed-off-by: Yue Hu <[email protected]>
> > Reviewed-by: Gao Xiang <[email protected]>
> > Reviewed-by: Chao Yu <[email protected]>
> > ---
> > no change
> >
> > drivers/staging/erofs/inode.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> This is already in my tree, right?
Seems not, i have received notes about other 2 patches below mergerd:
```note1
This is a note to let you know that I've just added the patch titled
staging: erofs: don't check special inode layout
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-next branch.
```
```note2
This is a note to let you know that I've just added the patch titled
staging: erofs: return the error value if fill_inline_data() fails
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-next branch.
```
No this patch in below link checked:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing
Thanks.
>
> confused,
>
> greg k-h
On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote:
> On Wed, 3 Jul 2019 18:20:38 +0200
> Greg KH <[email protected]> wrote:
>
> > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
> > > From: Yue Hu <[email protected]>
> > >
> > > Already check if ->datamode is supported in read_inode(), no need to check
> > > again in the next fill_inline_data() only called by fill_inode().
> > >
> > > Signed-off-by: Yue Hu <[email protected]>
> > > Reviewed-by: Gao Xiang <[email protected]>
> > > Reviewed-by: Chao Yu <[email protected]>
> > > ---
> > > no change
> > >
> > > drivers/staging/erofs/inode.c | 2 --
> > > 1 file changed, 2 deletions(-)
> >
> > This is already in my tree, right?
>
> Seems not, i have received notes about other 2 patches below mergerd:
>
> ```note1
> This is a note to let you know that I've just added the patch titled
>
> staging: erofs: don't check special inode layout
>
> to my staging git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> in the staging-next branch.
> ```
>
> ```note2
> This is a note to let you know that I've just added the patch titled
>
> staging: erofs: return the error value if fill_inline_data() fails
>
> to my staging git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> in the staging-next branch.
> ```
>
> No this patch in below link checked:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing
Then if it is not present, it needs to be rebased as it does not apply.
Please do so and resend it.
thanks,
greg k-h
On Thu, 4 Jul 2019 07:26:49 +0200
Greg KH <[email protected]> wrote:
> On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote:
> > On Wed, 3 Jul 2019 18:20:38 +0200
> > Greg KH <[email protected]> wrote:
> >
> > > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
> > > > From: Yue Hu <[email protected]>
> > > >
> > > > Already check if ->datamode is supported in read_inode(), no need to check
> > > > again in the next fill_inline_data() only called by fill_inode().
> > > >
> > > > Signed-off-by: Yue Hu <[email protected]>
> > > > Reviewed-by: Gao Xiang <[email protected]>
> > > > Reviewed-by: Chao Yu <[email protected]>
> > > > ---
> > > > no change
> > > >
> > > > drivers/staging/erofs/inode.c | 2 --
> > > > 1 file changed, 2 deletions(-)
> > >
> > > This is already in my tree, right?
> >
> > Seems not, i have received notes about other 2 patches below mergerd:
> >
> > ```note1
> > This is a note to let you know that I've just added the patch titled
> >
> > staging: erofs: don't check special inode layout
> >
> > to my staging git tree which can be found at
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > in the staging-next branch.
> > ```
> >
> > ```note2
> > This is a note to let you know that I've just added the patch titled
> >
> > staging: erofs: return the error value if fill_inline_data() fails
> >
> > to my staging git tree which can be found at
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> > in the staging-next branch.
> > ```
> >
> > No this patch in below link checked:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing
>
> Then if it is not present, it needs to be rebased as it does not apply.
>
> Please do so and resend it.
Hm, no need to resend since it's included in another patch below.
ec8c244 staging: erofs: add compacted ondisk compression indexes.
Thanks.
>
> thanks,
>
> greg k-h
On 2019/7/4 18:02, Yue Hu wrote:
> On Thu, 4 Jul 2019 07:26:49 +0200
> Greg KH <[email protected]> wrote:
>
>> On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote:
>>> On Wed, 3 Jul 2019 18:20:38 +0200
>>> Greg KH <[email protected]> wrote:
>>>
>>>> On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
>>>>> From: Yue Hu <[email protected]>
>>>>>
>>>>> Already check if ->datamode is supported in read_inode(), no need to check
>>>>> again in the next fill_inline_data() only called by fill_inode().
>>>>>
>>>>> Signed-off-by: Yue Hu <[email protected]>
>>>>> Reviewed-by: Gao Xiang <[email protected]>
>>>>> Reviewed-by: Chao Yu <[email protected]>
>>>>> ---
>>>>> no change
>>>>>
>>>>> drivers/staging/erofs/inode.c | 2 --
>>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> This is already in my tree, right?
>>>
>>> Seems not, i have received notes about other 2 patches below mergerd:
>>>
>>> ```note1
>>> This is a note to let you know that I've just added the patch titled
>>>
>>> staging: erofs: don't check special inode layout
>>>
>>> to my staging git tree which can be found at
>>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>>> in the staging-next branch.
>>> ```
>>>
>>> ```note2
>>> This is a note to let you know that I've just added the patch titled
>>>
>>> staging: erofs: return the error value if fill_inline_data() fails
>>>
>>> to my staging git tree which can be found at
>>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>>> in the staging-next branch.
>>> ```
>>>
>>> No this patch in below link checked:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing
>>
>> Then if it is not present, it needs to be rebased as it does not apply.
>>
>> Please do so and resend it.
>
> Hm, no need to resend since it's included in another patch below.
>
> ec8c244 staging: erofs: add compacted ondisk compression indexes.
Yes, it seems it was modified by the following patch occasionally months ago.
https://lore.kernel.org/lkml/[email protected]/
Anyway, thanks for your patch. :)
Thanks,
Gao Xiang
>
> Thanks.
>
>>
>> thanks,
>>
>> greg k-h
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>