2019-09-14 23:27:18

by Jens Axboe

Subject: Re: [PATCH] bfq: Fix bfq linkage error

On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <[email protected]>
>
> Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
> blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
> causes linkage error if bfq compiled as a module.

Thanks, I'll apply and add the Fixes tag.

--
Jens Axboe

2019-09-16 07:38:09

by Fam Zheng

Subject: Re: [PATCH] bfq: Fix bfq linkage error

On Sat, 09/14 11:32, Jens Axboe wrote:
> On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote:
> > From: Pavel Begunkov <[email protected]>
> >
> > Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
> > blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
> > causes linkage error if bfq compiled as a module.
>
> Thanks, I'll apply and add the Fixes tag.

Thanks! This is indeed my oversight.

Fam