2019-10-15 15:27:53

by Andrey Smirnov

Subject: [PATCH 1/4] arm64: dts: zii-ultra: Fix regulator-vsd-3v3's vin-supply

Regulator-vsd-3v3 is supplied via GEN_3V3 rail which is an output of
an "always on" load switch supplied by 3V3_MAIN. GEN_3V3 is also used
as vin-supply by a number of peripherals, so adding it also allows us
to follow the schematic more closely.

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected],
Cc: [email protected]
---
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 087b5b6ebe89..5d7a8f09f1ab 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -68,11 +68,20 @@
regulator-always-on;
};

+ reg_gen_3p3: regulator-gen-3p3 {
+ compatible = "regulator-fixed";
+ vin-supply = <&reg_3p3_main>;
+ regulator-name = "GEN_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
reg_usdhc2_vmmc: regulator-vsd-3v3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_reg_usdhc2>;
compatible = "regulator-fixed";
- vin-supply = <&reg_3p3_main>;
+ vin-supply = <&reg_gen_3p3>;
regulator-name = "3V3_SD";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
--
2.21.0

2019-10-15 15:27:57

by Andrey Smirnov

Subject: [PATCH 3/4] arm64: dts: zii-ultra: Add node for accelerometer

Add I2C node for accelerometer present on both Zest and RMB3 boards.

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected],
Cc: [email protected]
---
.../boot/dts/freescale/imx8mq-zii-ultra.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 21eb52341ba8..8395c5a73ba6 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -262,6 +262,18 @@
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";

+ accel@1c {
+ compatible = "fsl,mma8451";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_accel>;
+ reg = <0x1c>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "INT2";
+ vdd-supply = <&reg_gen_3p3>;
+ vddio-supply = <&reg_gen_3p3>;
+ };
+
ucs1002: charger@32 {
compatible = "microchip,ucs1002";
pinctrl-names = "default";
@@ -522,6 +534,12 @@
};

&iomuxc {
+ pinctrl_accel: accelgrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_SAI5_RXC_GPIO3_IO20 0x41
+ >;
+ };
+
pinctrl_fec1: fec1grp {
fsl,pins = <
MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC 0x3
--
2.21.0

2019-10-15 15:30:55

by Andrey Smirnov

Subject: [PATCH 2/4] arm64: dts: zii-ultra: Fix regulator-3p3-main's name

It's 3V3_MAIN, not 3V3V_MAIN on schematic. Fix it.

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected],
Cc: [email protected]
---
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 5d7a8f09f1ab..21eb52341ba8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -62,7 +62,7 @@
reg_3p3_main: regulator-3p3-main {
compatible = "regulator-fixed";
vin-supply = <&reg_12p0_main>;
- regulator-name = "3V3V_MAIN";
+ regulator-name = "3V3_MAIN";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-always-on;
--
2.21.0

2019-10-15 15:32:10

by Andrey Smirnov

Subject: [PATCH 4/4] arm64: dts: zii-ultra: Add node for switch watchdog

Add I2C node for switch watchdog present on both Zest and RMB3 boards.

Signed-off-by: Andrey Smirnov <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Chris Healy <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected],
Cc: [email protected]
---
arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
index 8395c5a73ba6..e058ad908b2e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
@@ -400,6 +400,11 @@
reg = <0x2c>;
reset-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>;
};
+
+ watchdog@38 {
+ compatible = "zii,rave-wdt";
+ reg = <0x38>;
+ };
};

&i2c4 {
--
2.21.0

2019-10-26 11:56:43

by Shawn Guo

Subject: Re: [PATCH 3/4] arm64: dts: zii-ultra: Add node for accelerometer

On Tue, Oct 15, 2019 at 08:26:53AM -0700, Andrey Smirnov wrote:
> Add I2C node for accelerometer present on both Zest and RMB3 boards.
>
> Signed-off-by: Andrey Smirnov <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> Cc: Chris Healy <[email protected]>
> Cc: Lucas Stach <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: [email protected],
> Cc: [email protected]
> ---
> .../boot/dts/freescale/imx8mq-zii-ultra.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> index 21eb52341ba8..8395c5a73ba6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> @@ -262,6 +262,18 @@
> pinctrl-0 = <&pinctrl_i2c1>;
> status = "okay";
>
> + accel@1c {

s/accel/accelerometer

I fixed it up and applied the series.

Shawn

> + compatible = "fsl,mma8451";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_accel>;
> + reg = <0x1c>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "INT2";
> + vdd-supply = <&reg_gen_3p3>;
> + vddio-supply = <&reg_gen_3p3>;
> + };
> +
> ucs1002: charger@32 {
> compatible = "microchip,ucs1002";
> pinctrl-names = "default";
> @@ -522,6 +534,12 @@
> };
>
> &iomuxc {
> + pinctrl_accel: accelgrp {
> + fsl,pins = <
> + MX8MQ_IOMUXC_SAI5_RXC_GPIO3_IO20 0x41
> + >;
> + };
> +
> pinctrl_fec1: fec1grp {
> fsl,pins = <
> MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC 0x3
> --
> 2.21.0
>

2019-10-26 18:57:45

by Andrey Smirnov

Subject: Re: [PATCH 3/4] arm64: dts: zii-ultra: Add node for accelerometer

On Sat, Oct 26, 2019 at 4:55 AM Shawn Guo <[email protected]> wrote:
>
> On Tue, Oct 15, 2019 at 08:26:53AM -0700, Andrey Smirnov wrote:
> > Add I2C node for accelerometer present on both Zest and RMB3 boards.
> >
> > Signed-off-by: Andrey Smirnov <[email protected]>
> > Cc: Fabio Estevam <[email protected]>
> > Cc: Chris Healy <[email protected]>
> > Cc: Lucas Stach <[email protected]>
> > Cc: Shawn Guo <[email protected]>
> > Cc: [email protected],
> > Cc: [email protected]
> > ---
> > .../boot/dts/freescale/imx8mq-zii-ultra.dtsi | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > index 21eb52341ba8..8395c5a73ba6 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > @@ -262,6 +262,18 @@
> > pinctrl-0 = <&pinctrl_i2c1>;
> > status = "okay";
> >
> > + accel@1c {
>
> s/accel/accelerometer
>
> I fixed it up and applied the series.
>

I'm fine with that change, but FYI, I originally had it as
"accelerometer', but changed to "accel" to match the name in DT for
RDU2.

Thanks,
Andrey Smirnov

2019-10-28 12:44:06

by Shawn Guo

Subject: Re: [PATCH 3/4] arm64: dts: zii-ultra: Add node for accelerometer

On Sat, Oct 26, 2019 at 11:54:13AM -0700, Andrey Smirnov wrote:
> On Sat, Oct 26, 2019 at 4:55 AM Shawn Guo <[email protected]> wrote:
> >
> > On Tue, Oct 15, 2019 at 08:26:53AM -0700, Andrey Smirnov wrote:
> > > Add I2C node for accelerometer present on both Zest and RMB3 boards.
> > >
> > > Signed-off-by: Andrey Smirnov <[email protected]>
> > > Cc: Fabio Estevam <[email protected]>
> > > Cc: Chris Healy <[email protected]>
> > > Cc: Lucas Stach <[email protected]>
> > > Cc: Shawn Guo <[email protected]>
> > > Cc: [email protected],
> > > Cc: [email protected]
> > > ---
> > > .../boot/dts/freescale/imx8mq-zii-ultra.dtsi | 18 ++++++++++++++++++
> > > 1 file changed, 18 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > index 21eb52341ba8..8395c5a73ba6 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi
> > > @@ -262,6 +262,18 @@
> > > pinctrl-0 = <&pinctrl_i2c1>;
> > > status = "okay";
> > >
> > > + accel@1c {
> >
> > s/accel/accelerometer
> >
> > I fixed it up and applied the series.
> >
>
> I'm fine with that change, but FYI, I originally had it as
> "accelerometer', but changed to "accel" to match the name in DT for
> RDU2.

We should change RDU2 instead, IMO.

Shawn