2019-10-21 09:22:08

by Peng Fan

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

From: Peng Fan <[email protected]>

We should not rely on U-Boot to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.

Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index faefb7182af1..e4d66f7db09d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -80,6 +80,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <&ethphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";

--
2.16.4


2019-10-21 09:22:38

by Peng Fan

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: imx8mn-ddr4-evk: add phy-reset-gpios for fec1

From: Peng Fan <[email protected]>

We should not rely on U-Boot to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.

Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index 1b90faace1d3..761ba0b5d271 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -48,6 +48,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <&ethphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";

--
2.16.4

2019-10-21 09:47:11

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

> Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> fec1
>
> Hi,
>
> On 19-10-21 09:21, Peng Fan wrote:
> > From: Peng Fan <[email protected]>
> >
> > We should not rely on U-Boot to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> > pinctrl-0 = <&pinctrl_fec1>;
> > phy-mode = "rgmii-id";
> > phy-handle = <&ethphy0>;
> > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
>
> Where is the pinctrl done?

https://elixir.bootlin.com/linux/v5.4-rc2/source/arch/arm64/boot/dts/freescale/imx8mm-evk.dts#L328

Regards,
Peng.

>
> Regards,
> Marco
>
> > fsl,magic-packet;
> > status = "okay";
> >
> > --
> > 2.16.4
> >
> >
> >
>
> --
> Pengutronix e.K. |
> |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> engutronix.de%2F&amp;data=02%7C01%7Cpeng.fan%40nxp.com%7Cb40bb6
> 4c5e39449ade4808d7560b43ca%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C637072478688921047&amp;sdata=xZI60uyyQ%2BkX%2Fpf07n
> CgVhGt1ApYBKSnndGB3Dk2578%3D&amp;reserved=0 |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |

2019-10-21 09:47:19

by Marco Felsch

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

Hi,

On 19-10-21 09:21, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> We should not rely on U-Boot to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index faefb7182af1..e4d66f7db09d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -80,6 +80,7 @@
> pinctrl-0 = <&pinctrl_fec1>;
> phy-mode = "rgmii-id";
> phy-handle = <&ethphy0>;
> + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;

Where is the pinctrl done?

Regards,
Marco

> fsl,magic-packet;
> status = "okay";
>
> --
> 2.16.4
>
>
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2019-10-21 09:52:11

by Marco Felsch

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

On 19-10-21 09:46, Peng Fan wrote:
> > Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> > fec1
> >
> > Hi,
> >
> > On 19-10-21 09:21, Peng Fan wrote:
> > > From: Peng Fan <[email protected]>
> > >
> > > We should not rely on U-Boot to configure the phy reset.

nitpick: s/U-Boot/bootloader/ ?

> > > So introduce phy-reset-gpios property to let Linux handle phy reset
> > > itself.
> > >
> > > Signed-off-by: Peng Fan <[email protected]>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > index faefb7182af1..e4d66f7db09d 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > > @@ -80,6 +80,7 @@
> > > pinctrl-0 = <&pinctrl_fec1>;
> > > phy-mode = "rgmii-id";
> > > phy-handle = <&ethphy0>;
> > > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> >
> > Where is the pinctrl done?
>
> https://elixir.bootlin.com/linux/v5.4-rc2/source/arch/arm64/boot/dts/freescale/imx8mm-evk.dts#L328

Thanks :)

Reviewed-by: Marco Felsch <[email protected]>

Regards,
Marco

> Regards,
> Peng.
>
> >
> > Regards,
> > Marco
> >
> > > fsl,magic-packet;
> > > status = "okay";
> > >
> > > --
> > > 2.16.4
> > >
> > >
> > >
> >
> > --
> > Pengutronix e.K. |
> > |
> > Industrial Linux Solutions |
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> > engutronix.de%2F&amp;data=02%7C01%7Cpeng.fan%40nxp.com%7Cb40bb6
> > 4c5e39449ade4808d7560b43ca%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> > 7C0%7C0%7C637072478688921047&amp;sdata=xZI60uyyQ%2BkX%2Fpf07n
> > CgVhGt1ApYBKSnndGB3Dk2578%3D&amp;reserved=0 |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> > |
> > Amtsgericht Hildesheim, HRA 2686 | Fax:
> > +49-5121-206917-5555 |
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |