2019-11-11 14:22:59

by Tony Lu

Subject: [PATCH] net: add missing semicolon in net_dev_template

This patch adds missing semicolon in the end of net_dev_template.

Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
Signed-off-by: Tony Lu <[email protected]>
---
include/trace/events/net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/net.h b/include/trace/events/net.h
index 2399073c3afc..3b28843652d2 100644
--- a/include/trace/events/net.h
+++ b/include/trace/events/net.h
@@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,

TP_printk("dev=%s skbaddr=%p len=%u",
__get_str(name), __entry->skbaddr, __entry->len)
-)
+);

DEFINE_EVENT(net_dev_template, net_dev_queue,

--
2.24.0

2019-11-11 23:15:45

by Steven Rostedt

Subject: Re: [PATCH] net: add missing semicolon in net_dev_template

On Mon, 11 Nov 2019 22:17:53 +0800
Tony Lu <[email protected]> wrote:

> This patch adds missing semicolon in the end of net_dev_template.
>
> Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> Signed-off-by: Tony Lu <[email protected]>
> ---
> include/trace/events/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> index 2399073c3afc..3b28843652d2 100644
> --- a/include/trace/events/net.h
> +++ b/include/trace/events/net.h
> @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
>
> TP_printk("dev=%s skbaddr=%p len=%u",
> __get_str(name), __entry->skbaddr, __entry->len)
> -)
> +);

Actually, we are thinking of making a sweeping patch set to remove all
these semicolons, as they are not needed, and would also allow more
flexible processing of the trace event macros.

-- Steve

>
> DEFINE_EVENT(net_dev_template, net_dev_queue,
>

2019-11-12 07:02:51

by Tony Lu

Subject: Re: [PATCH] net: add missing semicolon in net_dev_template

On Mon, Nov 11, 2019 at 06:12:28PM -0500, Steven Rostedt wrote:
> On Mon, 11 Nov 2019 22:17:53 +0800
> Tony Lu <[email protected]> wrote:
>
> > This patch adds missing semicolon in the end of net_dev_template.
> >
> > Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> > Signed-off-by: Tony Lu <[email protected]>
> > ---
> > include/trace/events/net.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> > index 2399073c3afc..3b28843652d2 100644
> > --- a/include/trace/events/net.h
> > +++ b/include/trace/events/net.h
> > @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
> >
> > TP_printk("dev=%s skbaddr=%p len=%u",
> > __get_str(name), __entry->skbaddr, __entry->len)
> > -)
> > +);
>
> Actually, we are thinking of making a sweeping patch set to remove all
> these semicolons, as they are not needed, and would also allow more
> flexible processing of the trace event macros.
>
> -- Steve

Thanks for your reply, it's great to take actions to sweep them for a
unified code style. I just found a different place in the code :-)

Cheers
Tony Lu

>
> >
> > DEFINE_EVENT(net_dev_template, net_dev_queue,
> >