2019-11-27 10:32:33

by Yannick FERTRE

Subject: [PATCH] Input: goodix - support gt9147 touchpanel

From: Yannick Fertré <[email protected]>

Add support for it by adding compatible and supported chip data
(default settings used).
The chip data on GT9147 is similar to GT912, like
- config data register has 0x8047 address
- config data register max len is 240
- config data checksum has 8-bit

Signed-off-by: Yannick Fertre <[email protected]>
---
drivers/input/touchscreen/goodix.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index fb43aa7..b470773 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
{ .compatible = "goodix,gt9271" },
{ .compatible = "goodix,gt928" },
{ .compatible = "goodix,gt967" },
+ { .compatible = "goodix,gt9147",},
{ }
};
MODULE_DEVICE_TABLE(of, goodix_of_match);
--
2.7.4

2019-12-01 03:10:17

by Dmitry Torokhov

Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel

On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertr? <[email protected]>
>
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit

If it is compatible with gt912 then the driver does not need another
compatible in the code I think. Rob will tell more.

>
> Signed-off-by: Yannick Fertre <[email protected]>
> ---
> drivers/input/touchscreen/goodix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
> { .compatible = "goodix,gt9271" },
> { .compatible = "goodix,gt928" },
> { .compatible = "goodix,gt967" },
> + { .compatible = "goodix,gt9147",},
> { }
> };
> MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
>

--
Dmitry

2019-12-05 08:32:22

by Yannick FERTRE

Subject: RE: [PATCH] Input: goodix - support gt9147 touchpanel

Hello,
Dmitry,
I forgot to modify the binding to declare the new compatible "gt9147".
Rob,
can I modify the binding without converting it first to yaml?

Best regards

Yannick Fertr?

-----Original Message-----
From: Dmitry Torokhov <[email protected]>
Sent: dimanche 1 d?cembre 2019 04:08
To: Yannick FERTRE <[email protected]>; Rob Herring <[email protected]>
Cc: Philippe CORNU <[email protected]>; Benjamin GAIGNARD <[email protected]>; Bastien Nocera <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel

On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertr? <[email protected]>
>
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit

If it is compatible with gt912 then the driver does not need another compatible in the code I think. Rob will tell more.

>
> Signed-off-by: Yannick Fertre <[email protected]>
> ---
> drivers/input/touchscreen/goodix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
> { .compatible = "goodix,gt9271" },
> { .compatible = "goodix,gt928" },
> { .compatible = "goodix,gt967" },
> + { .compatible = "goodix,gt9147",},
> { }
> };
> MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
>

--
Dmitry