2020-01-16 13:20:01

by Hongbo Yao

Subject: [PATCH v2 -next] drivers/net: netdevsim depends on INET

If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
Building drivers/net/netdevsim/fib.o will get the following error:

drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
fib.c:(.text+0xb11): undefined reference to `free_fib_info'

Correct the Kconfig for netdevsim.

Reported-by: Hulk Robot <[email protected]>
Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
Signed-off-by: Hongbo Yao <[email protected]>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 77ee9afad038..25a8f9387d5a 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -549,6 +549,7 @@ source "drivers/net/hyperv/Kconfig"
config NETDEVSIM
tristate "Simulated networking device"
depends on DEBUG_FS
+ depends on INET
depends on IPV6 || IPV6=n
select NET_DEVLINK
help
--
2.20.1

2020-01-16 13:33:13

by Jakub Kicinski

Subject: Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET

On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> Building drivers/net/netdevsim/fib.o will get the following error:
>
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>
> Correct the Kconfig for netdevsim.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")

Looks better :) Still missing a space between the hash and the bracket,
but:

Acked-by: Jakub Kicinski <[email protected]>

While at it - does mlxsw have the same problem by any chance?

2020-01-16 13:59:02

by Jiri Pirko

Subject: Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET

Thu, Jan 16, 2020 at 02:31:37PM CET, [email protected] wrote:
>On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
>> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
>> Building drivers/net/netdevsim/fib.o will get the following error:
>>
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
>> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
>> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>>
>> Correct the Kconfig for netdevsim.
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
>
>Looks better :) Still missing a space between the hash and the bracket,
>but:
>
>Acked-by: Jakub Kicinski <[email protected]>
>
>While at it - does mlxsw have the same problem by any chance?

Looks like it does.

2020-01-16 14:07:58

by Ido Schimmel

Subject: Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET

On Thu, Jan 16, 2020 at 02:56:50PM +0100, Jiri Pirko wrote:
> Thu, Jan 16, 2020 at 02:31:37PM CET, [email protected] wrote:
> >On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
> >> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> >> Building drivers/net/netdevsim/fib.o will get the following error:
> >>
> >> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> >> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> >> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> >> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
> >>
> >> Correct the Kconfig for netdevsim.
> >>
> >> Reported-by: Hulk Robot <[email protected]>
> >> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
> >
> >Looks better :) Still missing a space between the hash and the bracket,
> >but:
> >
> >Acked-by: Jakub Kicinski <[email protected]>
> >
> >While at it - does mlxsw have the same problem by any chance?
>
> Looks like it does.

MLXSW_SPECTRUM depends on NET_SWITCHDEV which in turn depends on INET

2020-01-17 10:30:25

by David Miller

Subject: Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET

From: Hongbo Yao <[email protected]>
Date: Thu, 16 Jan 2020 21:14:04 +0800

> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> Building drivers/net/netdevsim/fib.o will get the following error:
>
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>
> Correct the Kconfig for netdevsim.
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: 48bb9eb47b270 ("netdevsim: fib: Add dummy implementation for FIB offload")
> Signed-off-by: Hongbo Yao <[email protected]>

Applied, thanks.