2020-01-21 09:31:04

by chenzhou

Subject: [PATCH -next v2] drivers: net: declance: fix comparing pointer to 0

Fixes coccicheck warning:

./drivers/net/ethernet/amd/declance.c:611:14-15:
WARNING comparing pointer to 0

Replace "skb == 0" with "!skb".

Signed-off-by: Chen Zhou <[email protected]>
---
drivers/net/ethernet/amd/declance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
index 6592a2d..7282ce5 100644
--- a/drivers/net/ethernet/amd/declance.c
+++ b/drivers/net/ethernet/amd/declance.c
@@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
skb = netdev_alloc_skb(dev, len + 2);

- if (skb == 0) {
+ if (!skb) {
dev->stats.rx_dropped++;
*rds_ptr(rd, mblength, lp->type) = 0;
*rds_ptr(rd, rmd1, lp->type) =
--
2.7.4

2020-01-21 11:11:31

by David Miller

Subject: Re: [PATCH -next v2] drivers: net: declance: fix comparing pointer to 0

From: Chen Zhou <[email protected]>
Date: Tue, 21 Jan 2020 17:24:55 +0800

> Fixes coccicheck warning:
>
> ./drivers/net/ethernet/amd/declance.c:611:14-15:
> WARNING comparing pointer to 0
>
> Replace "skb == 0" with "!skb".
>
> Signed-off-by: Chen Zhou <[email protected]>

Applied, thanks.