2020-04-16 00:28:01

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

On Wed, 15 Apr 2020 20:00:43 +0300
Andy Shevchenko <[email protected]> wrote:

> It is a logical continuation of previously applied %ptR for struct rtc_time.
> We have few users of time64_t that would like to print it.
>
> Andrew, since Petr can't pay attention on this perhaps it can be passed thru
> your tree?
>
> Sergey, Steven, what do you think?

I'm fine with these changes. Sergey, what do you think?

-- Steve


2020-04-16 02:37:10

by Sergey Senozhatsky

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

On (20/04/15 13:20), Steven Rostedt wrote:
> On Wed, 15 Apr 2020 20:00:43 +0300
> Andy Shevchenko <[email protected]> wrote:
>
> > It is a logical continuation of previously applied %ptR for struct rtc_time.
> > We have few users of time64_t that would like to print it.
> >
> > Andrew, since Petr can't pay attention on this perhaps it can be passed thru
> > your tree?
> >
> > Sergey, Steven, what do you think?
>
> I'm fine with these changes. Sergey, what do you think?

I'm not against it in general, I'm slightly concerned if "two users"
is enough of a justification for new vsprintf() specifier.

-ss

2020-04-16 02:50:27

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

On Thu, 2020-04-16 at 11:34 +0900, Sergey Senozhatsky wrote:
> On (20/04/15 13:20), Steven Rostedt wrote:
> > On Wed, 15 Apr 2020 20:00:43 +0300
> > Andy Shevchenko <[email protected]> wrote:
> >
> > > It is a logical continuation of previously applied %ptR for struct rtc_time.
> > > We have few users of time64_t that would like to print it.
> > >
> > > Andrew, since Petr can't pay attention on this perhaps it can be passed thru
> > > your tree?
> > >
> > > Sergey, Steven, what do you think?
> >
> > I'm fine with these changes. Sergey, what do you think?
>
> I'm not against it in general, I'm slightly concerned if "two users"
> is enough of a justification for new vsprintf() specifier.

Me too as separate functions could be used here.


2020-04-21 13:09:29

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

On Wed, Apr 15, 2020 at 07:46:27PM -0700, Joe Perches wrote:
> On Thu, 2020-04-16 at 11:34 +0900, Sergey Senozhatsky wrote:
> > On (20/04/15 13:20), Steven Rostedt wrote:
> > > On Wed, 15 Apr 2020 20:00:43 +0300
> > > Andy Shevchenko <[email protected]> wrote:
> > >
> > > > It is a logical continuation of previously applied %ptR for struct rtc_time.
> > > > We have few users of time64_t that would like to print it.
> > > >
> > > > Andrew, since Petr can't pay attention on this perhaps it can be passed thru
> > > > your tree?
> > > >
> > > > Sergey, Steven, what do you think?
> > >
> > > I'm fine with these changes. Sergey, what do you think?
> >
> > I'm not against it in general, I'm slightly concerned if "two users"
> > is enough of a justification for new vsprintf() specifier.
>
> Me too as separate functions could be used here.

If we drop T in favour of ' ' (space) as delimiter, we will immediately get 5
or 6 users (I didn't check for new ones during last couple of years though).

--
With Best Regards,
Andy Shevchenko