2020-06-22 02:07:23

by Gaurav Singh

Subject: [PATCH] [objtoo] fix memory leak in special_get_alts

Free alt before returning to avoid memory leak.

Signed-off-by: Gaurav Singh <[email protected]>
---
tools/objtool/special.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/special.c b/tools/objtool/special.c
index e74e0189de22..f6f7dee1ba77 100644
--- a/tools/objtool/special.c
+++ b/tools/objtool/special.c
@@ -188,8 +188,10 @@ int special_get_alts(struct elf *elf, struct list_head *alts)
memset(alt, 0, sizeof(*alt));

ret = get_alt_entry(elf, entry, sec, idx, alt);
- if (ret)
+ if (ret) {
+ free(alt);
return ret;
+ }

list_add_tail(&alt->list, alts);
}
--
2.17.1

2020-06-23 04:15:19

by Josh Poimboeuf

Subject: Re: [PATCH] [objtoo] fix memory leak in special_get_alts

On Sun, Jun 21, 2020 at 10:04:34PM -0400, Gaurav Singh wrote:
> Free alt before returning to avoid memory leak.
>
> Signed-off-by: Gaurav Singh <[email protected]>

Hi Gaurav,

Since objtool is a short-lived (and performance sensitive) process, we
don't care about memory leaks. In fact we intentionally don't fix them.

--
Josh