2020-07-20 11:25:06

by Xiongfeng Wang

Subject: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to
add a newline for easy reading.

root@syzkaller:~# cat /sys/devices/virtual/net/lo/queues/tx-0/tx_timeout
0root@syzkaller:~#

Signed-off-by: Xiongfeng Wang <[email protected]>
---
net/core/net-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index e353b82..52bafb8 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1108,7 +1108,7 @@ static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf)
trans_timeout = queue->trans_timeout;
spin_unlock_irq(&queue->_xmit_lock);

- return sprintf(buf, "%lu", trans_timeout);
+ return sprintf(buf, "%lu\n", trans_timeout);
}

static unsigned int get_netdev_queue_index(struct netdev_queue *queue)
--
1.7.12.4

2020-07-21 00:45:08

by David Miller

Subject: Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

From: Xiongfeng Wang <[email protected]>
Date: Mon, 20 Jul 2020 19:17:49 +0800

> - return sprintf(buf, "%lu", trans_timeout);
> + return sprintf(buf, "%lu\n", trans_timeout);

Better to replace it with 'fmt_ulong'.

2020-07-21 06:17:23

by Xiongfeng Wang

Subject: Re: [PATCH] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

Hi,

On 2020/7/21 8:44, David Miller wrote:
> From: Xiongfeng Wang <[email protected]>
> Date: Mon, 20 Jul 2020 19:17:49 +0800
>
>> - return sprintf(buf, "%lu", trans_timeout);
>> + return sprintf(buf, "%lu\n", trans_timeout);
>
> Better to replace it with 'fmt_ulong'.

Thanks for your advice. I will change it in the next version.

Thanks,
Xiongfeng

>
> .
>