2020-07-23 20:14:00

by Chris Wilson

Subject: [PATCH] sched: Warn if garbage is passed to default_wake_function()

Since the default_wake_function() passes its flags onto
try_to_wake_up(), warn if those flags collide with internal values.
Given that the supplied flags are garbage, no repair can be done but at
least alert the user to the damage they are causing.

In the belief that these errors should be picked up during testing, the
warning is only compiled in under CONFIG_SCHED_DEBUG.

Signed-off-by: Chris Wilson <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Juri Lelli <[email protected]>
Cc: Vincent Guittot <[email protected]>
---
kernel/sched/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 7b918059332b..4be209266d8a 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4481,6 +4481,7 @@ asmlinkage __visible void __sched preempt_schedule_irq(void)
int default_wake_function(wait_queue_entry_t *curr, unsigned mode, int wake_flags,
void *key)
{
+ WARN_ON_ONCE(IS_ENABLED(CONFIG_SCHED_DEBUG) && wake_flags & ~WF_SYNC);
return try_to_wake_up(curr->private, mode, wake_flags);
}
EXPORT_SYMBOL(default_wake_function);
--
2.20.1

2020-07-23 20:24:56

by Peter Zijlstra

Subject: Re: [PATCH] sched: Warn if garbage is passed to default_wake_function()

On Thu, Jul 23, 2020 at 09:10:42PM +0100, Chris Wilson wrote:
> Since the default_wake_function() passes its flags onto
> try_to_wake_up(), warn if those flags collide with internal values.
> Given that the supplied flags are garbage, no repair can be done but at
> least alert the user to the damage they are causing.
>
> In the belief that these errors should be picked up during testing, the
> warning is only compiled in under CONFIG_SCHED_DEBUG.
>
> Signed-off-by: Chris Wilson <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Juri Lelli <[email protected]>
> Cc: Vincent Guittot <[email protected]>

Thanks!

2020-07-24 12:05:16

by tip-bot2 for Jacob Pan

Subject: [tip: sched/core] sched: Warn if garbage is passed to default_wake_function()

The following commit has been merged into the sched/core branch of tip:

Commit-ID: da3520d750e36051ecd5847ef712659b9c68ce20
Gitweb: https://git.kernel.org/tip/da3520d750e36051ecd5847ef712659b9c68ce20
Author: Chris Wilson <[email protected]>
AuthorDate: Thu, 23 Jul 2020 21:10:42 +01:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Fri, 24 Jul 2020 13:47:12 +02:00

sched: Warn if garbage is passed to default_wake_function()

Since the default_wake_function() passes its flags onto
try_to_wake_up(), warn if those flags collide with internal values.

Given that the supplied flags are garbage, no repair can be done but at
least alert the user to the damage they are causing.

In the belief that these errors should be picked up during testing, the
warning is only compiled in under CONFIG_SCHED_DEBUG.

Signed-off-by: Chris Wilson <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/sched/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index bd8e521..637365e 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4686,6 +4686,7 @@ asmlinkage __visible void __sched preempt_schedule_irq(void)
int default_wake_function(wait_queue_entry_t *curr, unsigned mode, int wake_flags,
void *key)
{
+ WARN_ON_ONCE(IS_ENABLED(CONFIG_SCHED_DEBUG) && wake_flags & ~WF_SYNC);
return try_to_wake_up(curr->private, mode, wake_flags);
}
EXPORT_SYMBOL(default_wake_function);

2020-07-24 12:47:21

by tip-bot2 for Jacob Pan

Subject: [tip: sched/urgent] sched: Warn if garbage is passed to default_wake_function()

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID: 062d3f95b630113e1156a31f376ad36e25da29a7
Gitweb: https://git.kernel.org/tip/062d3f95b630113e1156a31f376ad36e25da29a7
Author: Chris Wilson <[email protected]>
AuthorDate: Thu, 23 Jul 2020 21:10:42 +01:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Fri, 24 Jul 2020 14:40:25 +02:00

sched: Warn if garbage is passed to default_wake_function()

Since the default_wake_function() passes its flags onto
try_to_wake_up(), warn if those flags collide with internal values.

Given that the supplied flags are garbage, no repair can be done but at
least alert the user to the damage they are causing.

In the belief that these errors should be picked up during testing, the
warning is only compiled in under CONFIG_SCHED_DEBUG.

Signed-off-by: Chris Wilson <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Acked-by: Peter Zijlstra <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/sched/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 5dece9b..2142c67 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4485,6 +4485,7 @@ asmlinkage __visible void __sched preempt_schedule_irq(void)
int default_wake_function(wait_queue_entry_t *curr, unsigned mode, int wake_flags,
void *key)
{
+ WARN_ON_ONCE(IS_ENABLED(CONFIG_SCHED_DEBUG) && wake_flags & ~WF_SYNC);
return try_to_wake_up(curr->private, mode, wake_flags);
}
EXPORT_SYMBOL(default_wake_function);