variable err is uninitialized when bio is an error code
Signed-off-by: Tong Zhang <[email protected]>
---
drivers/block/rnbd/rnbd-srv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
index 0fb94843a495..818eff323825 100644
--- a/drivers/block/rnbd/rnbd-srv.c
+++ b/drivers/block/rnbd/rnbd-srv.c
@@ -149,6 +149,7 @@ static int process_rdma(struct rtrs_srv *sess,
bio = rnbd_bio_map_kern(data, sess_dev->rnbd_dev->ibd_bio_set, datalen, GFP_KERNEL);
if (IS_ERR(bio)) {
rnbd_srv_err(sess_dev, "Failed to generate bio, err: %ld\n", PTR_ERR(bio));
+ err = bio
goto sess_dev_put;
}
--
2.25.1
On 8/24/20 1:43 PM, Tong Zhang wrote:
> variable err is uninitialized when bio is an error code
It's fixed in Linus's tree:
commit 17bc10300c69bd51b82983cdadafa0a7791f074e
Author: Nathan Chancellor <[email protected]>
Date: Mon Aug 17 23:49:25 2020 -0700
block/rnbd: Ensure err is always initialized in process_rdma
--
Jens Axboe
Got it. Thanks Jens.
On Mon, Aug 24, 2020 at 3:45 PM Jens Axboe <[email protected]> wrote:
>
> On 8/24/20 1:43 PM, Tong Zhang wrote:
> > variable err is uninitialized when bio is an error code
>
> It's fixed in Linus's tree:
>
> commit 17bc10300c69bd51b82983cdadafa0a7791f074e
> Author: Nathan Chancellor <[email protected]>
> Date: Mon Aug 17 23:49:25 2020 -0700
>
> block/rnbd: Ensure err is always initialized in process_rdma
>
> --
> Jens Axboe
>