2020-11-24 19:50:47

by liwei (GF)

Subject: [PATCH] drivers/pcmcia: Fix error return code in electra_cf_probe()

When it fails to call of_get_property(), it just jumps to 'fail1',
while the 'status' which will be returned is not updated.

Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards")
Signed-off-by: Wei Li <[email protected]>
---
drivers/pcmcia/electra_cf.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c
index 35158cfd9c1a..0570758e3fa8 100644
--- a/drivers/pcmcia/electra_cf.c
+++ b/drivers/pcmcia/electra_cf.c
@@ -228,6 +228,7 @@ static int electra_cf_probe(struct platform_device *ofdev)
}

cf->socket.pci_irq = cf->irq;
+ status = -ENODEV;

prop = of_get_property(np, "card-detect-gpio", NULL);
if (!prop)
--
2.17.1

2020-12-05 10:15:13

by Dominik Brodowski

Subject: Re: [PATCH] drivers/pcmcia: Fix error return code in electra_cf_probe()

Am Tue, Nov 24, 2020 at 03:00:40PM +0800 schrieb Wei Li:
> When it fails to call of_get_property(), it just jumps to 'fail1',
> while the 'status' which will be returned is not updated.
>
> Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards")
> Signed-off-by: Wei Li <[email protected]>

Thnaks for the patch. However, this issue is already fixed by
commit f15480e947d4 ("pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()'
in case of error")
in pcmcia-next.

Thanks,
Dominik