2020-11-27 18:15:12

by Joe Perches

Subject: Re: [PATCH] eCryptfs: add a semicolon

On Fri, 2020-11-27 at 08:05 -0800, [email protected] wrote:
> Function like macros should have a semicolon.
[]
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
[]
> @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> ? rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> ? if (rc) {
> ? ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> - cipher_code)
> + cipher_code);

As this is the only use that does not have a semicolon,
it'd be good to add the removal of the semicolon from
the #define at the same time.

2021-01-30 17:59:19

by Tyler Hicks

Subject: Re: [PATCH] eCryptfs: add a semicolon

On 2020-11-27 10:11:23, Joe Perches wrote:
> On Fri, 2020-11-27 at 08:05 -0800, [email protected] wrote:
> > Function like macros should have a semicolon.
> []
> > diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
> []
> > @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> > ? rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> > ? if (rc) {
> > ? ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> > - cipher_code)
> > + cipher_code);
>
> As this is the only use that does not have a semicolon,
> it'd be good to add the removal of the semicolon from
> the #define at the same time.

I double checked that this is the only ecryptfs_printk() usage missing
the trailing semicolon and then made Joe's suggested change before
pushing the patch to the eCryptfs next branch:

https://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git/log/?h=next

Thanks for the cleanup!

Tyler