2020-08-12 06:32:38

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 00/14] mips: bmips: include dt-bindings headers

Allow including dt-bindings header files and use them for bcm63xx.

Álvaro Fernández Rojas (14):
mips: dts: brcm: allow including header files
mips: bmips: add BCM3368 irq definitions
mips: bmips: add BCM6318 irq definitions
mips: bmips: add BCM6328 irq definitions
mips: bmips: add BCM6358 irq definitions
mips: bmips: add BCM6362 irq definitions
mips: bmips: add BCM6368 irq definitions
mips: bmips: add BCM63268 irq definitions
mips: bmips: bcm3368: include and use dt-bindings
mips: bmips: bcm6328: include and use dt-bindings
mips: bmips: bcm6358: include and use dt-bindings
mips: bmips: bcm6362: include and use dt-bindings
mips: bmips: bcm6368: include and use dt-bindings
mips: bmips: bcm63268: include and use dt-bindings

.../boot/dts/brcm/bcm3368-netgear-cvg834g.dts | 2 +-
arch/mips/boot/dts/brcm/bcm3368.dtsi | 8 +-
.../dts/brcm/bcm63268-comtrend-vr-3032u.dts | 2 +-
arch/mips/boot/dts/brcm/bcm63268.dtsi | 12 ++-
arch/mips/boot/dts/brcm/bcm6328.dtsi | 12 ++-
.../dts/brcm/bcm6358-neufbox4-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6358.dtsi | 12 ++-
.../dts/brcm/bcm6362-neufbox6-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6362.dtsi | 12 ++-
arch/mips/boot/dts/brcm/bcm6368.dtsi | 12 ++-
arch/mips/boot/dts/brcm/bcm93384wvg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts | 2 +-
arch/mips/boot/dts/brcm/bcm96368mvwg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 +-
arch/mips/boot/dts/brcm/bcm97358svmb.dts | 4 +-
arch/mips/boot/dts/brcm/bcm97360svmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 +-
arch/mips/boot/dts/brcm/bcm97420c.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97425svmb.dts | 4 +-
arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 +-
arch/mips/boot/dts/brcm/bcm9ejtagprb.dts | 2 +-
.../bcm3368-interrupt-controller.h | 19 ++++
.../bcm6318-interrupt-controller.h | 84 ++++++++++++++++++
.../bcm63268-interrupt-controller.h | 86 +++++++++++++++++++
.../bcm6328-interrupt-controller.h | 68 +++++++++++++++
.../bcm6358-interrupt-controller.h | 38 ++++++++
.../bcm6362-interrupt-controller.h | 71 +++++++++++++++
.../bcm6368-interrupt-controller.h | 71 +++++++++++++++
29 files changed, 504 insertions(+), 43 deletions(-)
create mode 100644 include/dt-bindings/interrupt-controller/bcm3368-interrupt-controller.h
create mode 100644 include/dt-bindings/interrupt-controller/bcm6318-interrupt-controller.h
create mode 100644 include/dt-bindings/interrupt-controller/bcm63268-interrupt-controller.h
create mode 100644 include/dt-bindings/interrupt-controller/bcm6328-interrupt-controller.h
create mode 100644 include/dt-bindings/interrupt-controller/bcm6358-interrupt-controller.h
create mode 100644 include/dt-bindings/interrupt-controller/bcm6362-interrupt-controller.h
create mode 100644 include/dt-bindings/interrupt-controller/bcm6368-interrupt-controller.h

--
2.28.0


2020-08-12 06:32:40

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 02/14] mips: bmips: add BCM3368 irq definitions

Add header with BCM3368 definitions in order to be able to include it from
device tree files.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
.../bcm3368-interrupt-controller.h | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 include/dt-bindings/interrupt-controller/bcm3368-interrupt-controller.h

diff --git a/include/dt-bindings/interrupt-controller/bcm3368-interrupt-controller.h b/include/dt-bindings/interrupt-controller/bcm3368-interrupt-controller.h
new file mode 100644
index 000000000000..e269c1bb93ea
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/bcm3368-interrupt-controller.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM3368_H
+#define __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM3368_H
+
+#define BCM3368_IRQ_TIMER 0
+#define BCM3368_IRQ_SPI 1
+#define BCM3368_IRQ_UART0 2
+#define BCM3368_IRQ_UART1 3
+#define BCM3368_IRQ_ENET1 6
+#define BCM3368_IRQ_ENET0 8
+#define BCM3368_IRQ_ENET_PHY 9
+#define BCM3368_IRQ_ENET0_RX_DMA 15
+#define BCM3368_IRQ_ENET0_TX_DMA 16
+#define BCM3368_IRQ_ENET1_RX_DMA 17
+#define BCM3368_IRQ_ENET1_TX_DMA 18
+#define BCM3368_IRQ_PCI 31
+
+#endif /* __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM3368_H */
--
2.28.0

2020-08-12 06:32:49

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 05/14] mips: bmips: add BCM6358 irq definitions

Add header with BCM6358 definitions in order to be able to include it from
device tree files.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
.../bcm6358-interrupt-controller.h | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 include/dt-bindings/interrupt-controller/bcm6358-interrupt-controller.h

diff --git a/include/dt-bindings/interrupt-controller/bcm6358-interrupt-controller.h b/include/dt-bindings/interrupt-controller/bcm6358-interrupt-controller.h
new file mode 100644
index 000000000000..a098639dbe4e
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/bcm6358-interrupt-controller.h
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6358_H
+#define __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6358_H
+
+#define BCM6358_IRQ_TIMER 0
+#define BCM6358_IRQ_SPI 1
+#define BCM6358_IRQ_UART0 2
+#define BCM6358_IRQ_UART1 3
+#define BCM6358_IRQ_OHCI 5
+#define BCM6358_IRQ_EMAC1 6
+#define BCM6358_IRQ_USBS 7
+#define BCM6358_IRQ_EMAC0 8
+#define BCM6358_IRQ_EPHY 9
+#define BCM6358_IRQ_EHCI 10
+#define BCM6358_IRQ_USB_CTL_RX_DMA 11
+#define BCM6358_IRQ_USB_CTL_TX_DMA 12
+#define BCM6358_IRQ_USB_BULK_RX_DMA 13
+#define BCM6358_IRQ_USB_BULK_TX_DMA 14
+#define BCM6358_IRQ_EMAC0_RX_DMA 15
+#define BCM6358_IRQ_EMAC0_TX_DMA 16
+#define BCM6358_IRQ_EMAC1_RX_DMA 17
+#define BCM6358_IRQ_EMAC1_TX_DMA 18
+#define BCM6358_IRQ_ATM 19
+#define BCM6358_IRQ_EXT4 20
+#define BCM6358_IRQ_EXT5 21
+#define BCM6358_IRQ_PCM 22
+#define BCM6358_IRQ_PCM_RX_DMA 23
+#define BCM6358_IRQ_PCM_TX_DMA 24
+#define BCM6358_IRQ_EXT0 25
+#define BCM6358_IRQ_EXT1 26
+#define BCM6358_IRQ_EXT2 27
+#define BCM6358_IRQ_EXT3 28
+#define BCM6358_IRQ_ADSL 29
+#define BCM6358_IRQ_DG 30
+#define BCM6358_IRQ_MPI 31
+
+#endif /* __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6358_H */
--
2.28.0

2020-08-12 06:33:00

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 11/14] mips: bmips: bcm6358: include and use dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
arch/mips/boot/dts/brcm/bcm6358.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm6358.dtsi b/arch/mips/boot/dts/brcm/bcm6358.dtsi
index f21176cac038..d149d062be80 100644
--- a/arch/mips/boot/dts/brcm/bcm6358.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6358.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6358-clock.h"
+#include "dt-bindings/interrupt-controller/bcm6358-interrupt-controller.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
@@ -96,7 +100,7 @@ uart0: serial@fffe0100 {
reg = <0xfffe0100 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <2>;
+ interrupts = <BCM6358_IRQ_UART0>;

clocks = <&periph_clk>;
clock-names = "refclk";
@@ -109,7 +113,7 @@ uart1: serial@fffe0120 {
reg = <0xfffe0120 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <3>;
+ interrupts = <BCM6358_IRQ_UART1>;

clocks = <&periph_clk>;
clock-names = "refclk";
@@ -122,7 +126,7 @@ ehci: usb@fffe1300 {
reg = <0xfffe1300 0x100>;
big-endian;
interrupt-parent = <&periph_intc>;
- interrupts = <10>;
+ interrupts = <BCM6358_IRQ_EHCI>;
status = "disabled";
};

@@ -132,7 +136,7 @@ ohci: usb@fffe1400 {
big-endian;
no-big-frame-no;
interrupt-parent = <&periph_intc>;
- interrupts = <5>;
+ interrupts = <BCM6358_IRQ_OHCI>;
status = "disabled";
};
};
--
2.28.0

2020-08-12 06:33:03

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 12/14] mips: bmips: bcm6362: include and use dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
arch/mips/boot/dts/brcm/bcm6362.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm6362.dtsi b/arch/mips/boot/dts/brcm/bcm6362.dtsi
index 8ae6981735b8..e6ec366818a9 100644
--- a/arch/mips/boot/dts/brcm/bcm6362.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6362.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6362-clock.h"
+#include "dt-bindings/interrupt-controller/bcm6362-interrupt-controller.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
@@ -87,7 +91,7 @@ uart0: serial@10000100 {
reg = <0x10000100 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <3>;
+ interrupts = <BCM6362_IRQ_UART0>;

clocks = <&periph_clk>;
clock-names = "refclk";
@@ -100,7 +104,7 @@ uart1: serial@10000120 {
reg = <0x10000120 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <4>;
+ interrupts = <BCM6362_IRQ_UART1>;

clocks = <&periph_clk>;
clock-names = "refclk";
@@ -123,7 +127,7 @@ ehci: usb@10002500 {
big-endian;

interrupt-parent = <&periph_intc>;
- interrupts = <10>;
+ interrupts = <BCM6362_IRQ_EHCI>;

status = "disabled";
};
@@ -135,7 +139,7 @@ ohci: usb@10002600 {
no-big-frame-no;

interrupt-parent = <&periph_intc>;
- interrupts = <9>;
+ interrupts = <BCM6362_IRQ_OHCI>;

status = "disabled";
};
--
2.28.0

2020-08-12 06:33:15

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 09/14] mips: bmips: bcm3368: include and use dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
arch/mips/boot/dts/brcm/bcm3368.dtsi | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm3368.dtsi b/arch/mips/boot/dts/brcm/bcm3368.dtsi
index 69cbef472377..63d844601718 100644
--- a/arch/mips/boot/dts/brcm/bcm3368.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm3368.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm3368-clock.h"
+#include "dt-bindings/interrupt-controller/bcm3368-interrupt-controller.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
@@ -86,7 +90,7 @@ uart0: serial@fff8c100 {
reg = <0xfff8c100 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <2>;
+ interrupts = <BCM3368_IRQ_UART0>;

clocks = <&periph_clk>;
clock-names = "refclk";
@@ -99,7 +103,7 @@ uart1: serial@fff8c120 {
reg = <0xfff8c120 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <3>;
+ interrupts = <BCM3368_IRQ_UART1>;

clocks = <&periph_clk>;
clock-names = "refclk";
--
2.28.0

2020-08-12 06:33:18

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 10/14] mips: bmips: bcm6328: include and use dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
arch/mips/boot/dts/brcm/bcm6328.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm6328.dtsi b/arch/mips/boot/dts/brcm/bcm6328.dtsi
index af860d06def6..1f84f6b05f88 100644
--- a/arch/mips/boot/dts/brcm/bcm6328.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6328.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6328-clock.h"
+#include "dt-bindings/interrupt-controller/bcm6328-interrupt-controller.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
@@ -73,7 +77,7 @@ uart0: serial@10000100 {
compatible = "brcm,bcm6345-uart";
reg = <0x10000100 0x18>;
interrupt-parent = <&periph_intc>;
- interrupts = <28>;
+ interrupts = <BCM6328_IRQ_UART0>;
clocks = <&periph_clk>;
clock-names = "refclk";
status = "disabled";
@@ -83,7 +87,7 @@ uart1: serial@10000120 {
compatible = "brcm,bcm6345-uart";
reg = <0x10000120 0x18>;
interrupt-parent = <&periph_intc>;
- interrupts = <39>;
+ interrupts = <BCM6328_IRQ_UART1>;
clocks = <&periph_clk>;
clock-names = "refclk";
status = "disabled";
@@ -115,7 +119,7 @@ ehci: usb@10002500 {
reg = <0x10002500 0x100>;
big-endian;
interrupt-parent = <&periph_intc>;
- interrupts = <42>;
+ interrupts = <BCM6328_IRQ_EHCI>;
status = "disabled";
};

@@ -125,7 +129,7 @@ ohci: usb@10002600 {
big-endian;
no-big-frame-no;
interrupt-parent = <&periph_intc>;
- interrupts = <41>;
+ interrupts = <BCM6328_IRQ_OHCI>;
status = "disabled";
};
};
--
2.28.0

2020-08-12 06:33:28

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 13/14] mips: bmips: bcm6368: include and use dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
arch/mips/boot/dts/brcm/bcm6368.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm6368.dtsi b/arch/mips/boot/dts/brcm/bcm6368.dtsi
index 449c167dd892..62599d4e6abe 100644
--- a/arch/mips/boot/dts/brcm/bcm6368.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6368.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6368-clock.h"
+#include "dt-bindings/interrupt-controller/bcm6368-interrupt-controller.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
@@ -94,7 +98,7 @@ uart0: serial@10000100 {
compatible = "brcm,bcm6345-uart";
reg = <0x10000100 0x18>;
interrupt-parent = <&periph_intc>;
- interrupts = <2>;
+ interrupts = <BCM6368_IRQ_UART0>;
clocks = <&periph_clk>;
clock-names = "refclk";
status = "disabled";
@@ -104,7 +108,7 @@ uart1: serial@10000120 {
compatible = "brcm,bcm6345-uart";
reg = <0x10000120 0x18>;
interrupt-parent = <&periph_intc>;
- interrupts = <3>;
+ interrupts = <BCM6368_IRQ_UART1>;
clocks = <&periph_clk>;
clock-names = "refclk";
status = "disabled";
@@ -115,7 +119,7 @@ ehci: usb@10001500 {
reg = <0x10001500 0x100>;
big-endian;
interrupt-parent = <&periph_intc>;
- interrupts = <7>;
+ interrupts = <BCM6368_IRQ_EHCI>;
status = "disabled";
};

@@ -125,7 +129,7 @@ ohci: usb@10001600 {
big-endian;
no-big-frame-no;
interrupt-parent = <&periph_intc>;
- interrupts = <5>;
+ interrupts = <BCM6368_IRQ_OHCI>;
status = "disabled";
};
};
--
2.28.0

2020-08-12 06:33:38

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 14/14] mips: bmips: bcm63268: include and use dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
arch/mips/boot/dts/brcm/bcm63268.dtsi | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi
index beec24145af7..17d744db8211 100644
--- a/arch/mips/boot/dts/brcm/bcm63268.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm63268-clock.h"
+#include "dt-bindings/interrupt-controller/bcm63268-interrupt-controller.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
@@ -87,7 +91,7 @@ uart0: serial@10000180 {
reg = <0x10000180 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <5>;
+ interrupts = <BCM63268_IRQ_UART0>;

clocks = <&periph_clk>;
clock-names = "refclk";
@@ -100,7 +104,7 @@ uart1: serial@100001a0 {
reg = <0x100001a0 0x18>;

interrupt-parent = <&periph_intc>;
- interrupts = <34>;
+ interrupts = <BCM63268_IRQ_UART1>;

clocks = <&periph_clk>;
clock-names = "refclk";
@@ -123,7 +127,7 @@ ehci: usb@10002500 {
big-endian;

interrupt-parent = <&periph_intc>;
- interrupts = <10>;
+ interrupts = <BCM63268_IRQ_EHCI>;

status = "disabled";
};
@@ -135,7 +139,7 @@ ohci: usb@10002600 {
no-big-frame-no;

interrupt-parent = <&periph_intc>;
- interrupts = <9>;
+ interrupts = <BCM63268_IRQ_OHCI>;

status = "disabled";
};
--
2.28.0

2020-08-12 06:33:58

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 06/14] mips: bmips: add BCM6362 irq definitions

Add header with BCM6362 definitions in order to be able to include it from
device tree files.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
.../bcm6362-interrupt-controller.h | 71 +++++++++++++++++++
1 file changed, 71 insertions(+)
create mode 100644 include/dt-bindings/interrupt-controller/bcm6362-interrupt-controller.h

diff --git a/include/dt-bindings/interrupt-controller/bcm6362-interrupt-controller.h b/include/dt-bindings/interrupt-controller/bcm6362-interrupt-controller.h
new file mode 100644
index 000000000000..7a13046f0d81
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/bcm6362-interrupt-controller.h
@@ -0,0 +1,71 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6362_H
+#define __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6362_H
+
+#define BCM6362_IRQ_TIMER 0
+#define BCM6362_IRQ_RING_OSC 1
+#define BCM6362_IRQ_LSSPI 2
+#define BCM6362_IRQ_UART0 3
+#define BCM6362_IRQ_UART1 4
+#define BCM6362_IRQ_HSSPI 5
+#define BCM6362_IRQ_WLAN_GPIO 6
+#define BCM6362_IRQ_WLAN 7
+#define BCM6362_IRQ_IPSEC 8
+#define BCM6362_IRQ_OHCI 9
+#define BCM6362_IRQ_EHCI 10
+#define BCM6362_IRQ_USBS 11
+#define BCM6362_IRQ_NAND 12
+#define BCM6362_IRQ_PCM 13
+#define BCM6362_IRQ_EPHY 14
+#define BCM6362_IRQ_DF 15
+#define BCM6362_IRQ_EPHY_EN0 16
+#define BCM6362_IRQ_EPHY_EN1 17
+#define BCM6362_IRQ_EPHY_EN2 18
+#define BCM6362_IRQ_EPHY_EN3 19
+#define BCM6362_IRQ_USB_CTL_RX_DMA 20
+#define BCM6362_IRQ_USB_CTL_TX_DMA 21
+#define BCM6362_IRQ_USB_BULK_RX_DMA 22
+#define BCM6362_IRQ_USB_BULK_TX_DMA 23
+#define BCM6362_IRQ_USB_ISO_RX_DMA 24
+#define BCM6362_IRQ_USB_ISO_TX_DMA 25
+#define BCM6362_IRQ_IPSEC_DMA0 26
+#define BCM6362_IRQ_IPSEC_DMA1 27
+#define BCM6362_IRQ_XDSL 28
+#define BCM6362_IRQ_FAP 29
+#define BCM6362_IRQ_PCIE_RC 30
+#define BCM6362_IRQ_PCIE_EP 31
+#define BCM6362_IRQ_ENETSW_RX_DMA0 32
+#define BCM6362_IRQ_ENETSW_RX_DMA1 33
+#define BCM6362_IRQ_ENETSW_RX_DMA2 34
+#define BCM6362_IRQ_ENETSW_RX_DMA3 35
+#define BCM6362_IRQ_PCM_DMA0 36
+#define BCM6362_IRQ_PCM_DMA1 37
+#define BCM6362_IRQ_DECT0 38
+#define BCM6362_IRQ_DECT1 39
+#define BCM6362_IRQ_EXT0 40
+#define BCM6362_IRQ_EXT1 41
+#define BCM6362_IRQ_EXT2 42
+#define BCM6362_IRQ_EXT3 43
+#define BCM6362_IRQ_ATM_DMA0 44
+#define BCM6362_IRQ_ATM_DMA1 45
+#define BCM6362_IRQ_ATM_DMA2 46
+#define BCM6362_IRQ_ATM_DMA3 47
+#define BCM6362_IRQ_ATM_DMA4 48
+#define BCM6362_IRQ_ATM_DMA5 49
+#define BCM6362_IRQ_ATM_DMA6 50
+#define BCM6362_IRQ_ATM_DMA7 51
+#define BCM6362_IRQ_ATM_DMA8 52
+#define BCM6362_IRQ_ATM_DMA9 53
+#define BCM6362_IRQ_ATM_DMA10 54
+#define BCM6362_IRQ_ATM_DMA11 55
+#define BCM6362_IRQ_ATM_DMA12 56
+#define BCM6362_IRQ_ATM_DMA13 57
+#define BCM6362_IRQ_ATM_DMA14 58
+#define BCM6362_IRQ_ATM_DMA15 59
+#define BCM6362_IRQ_ATM_DMA16 60
+#define BCM6362_IRQ_ATM_DMA17 61
+#define BCM6362_IRQ_ATM_DMA18 62
+#define BCM6362_IRQ_ATM_DMA19 63
+
+#endif /* __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6362_H */
--
2.28.0

2020-08-12 06:34:27

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 04/14] mips: bmips: add BCM6328 irq definitions

Add header with BCM6328 definitions in order to be able to include it from
device tree files.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
.../bcm6328-interrupt-controller.h | 68 +++++++++++++++++++
1 file changed, 68 insertions(+)
create mode 100644 include/dt-bindings/interrupt-controller/bcm6328-interrupt-controller.h

diff --git a/include/dt-bindings/interrupt-controller/bcm6328-interrupt-controller.h b/include/dt-bindings/interrupt-controller/bcm6328-interrupt-controller.h
new file mode 100644
index 000000000000..def2a21efc77
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/bcm6328-interrupt-controller.h
@@ -0,0 +1,68 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6328_H
+#define __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6328_H
+
+#define BCM6328_IRQ_NAND 0
+#define BCM6328_IRQ_PCM 1
+#define BCM6328_IRQ_PCM_DMA0 2
+#define BCM6328_IRQ_PCM_DMA1 3
+#define BCM6328_IRQ_USBS 4
+#define BCM6328_IRQ_USB_CTL_RX_DMA 5
+#define BCM6328_IRQ_USB_CTL_TX_DMA 6
+#define BCM6328_IRQ_USB_BULK_RX_DMA 7
+#define BCM6328_IRQ_USB_BULK_TX_DMA 8
+#define BCM6328_IRQ_USB_ISO_RX_DMA 9
+#define BCM6328_IRQ_USB_ISO_TX_DMA 10
+#define BCM6328_IRQ_DG 11
+#define BCM6328_IRQ_EPHY 12
+#define BCM6328_IRQ_EPHY_EN0N 13
+#define BCM6328_IRQ_EPHY_EN1N 14
+#define BCM6328_IRQ_EPHY_EN2N 15
+#define BCM6328_IRQ_EPHY_EN3N 16
+#define BCM6328_IRQ_EPHY_EN0 17
+#define BCM6328_IRQ_EPHY_EN1 18
+#define BCM6328_IRQ_EPHY_EN2 19
+#define BCM6328_IRQ_EPHY_EN3 20
+#define BCM6328_IRQ_XDSL 21
+#define BCM6328_IRQ_PCIE_EP 22
+#define BCM6328_IRQ_PCIE_RC 23
+#define BCM6328_IRQ_EXTO 24
+#define BCM6328_IRQ_EXT1 25
+#define BCM6328_IRQ_EXT2 26
+#define BCM6328_IRQ_EXT3 27
+#define BCM6328_IRQ_UART0 28
+#define BCM6328_IRQ_HSSPI 29
+#define BCM6328_IRQ_WAKE_ON_IRQ 30
+#define BCM6328_IRQ_TIMER 31
+#define BCM6328_IRQ_ENETSW_RX_DMA0 32
+#define BCM6328_IRQ_ENETSW_RX_DMA1 33
+#define BCM6328_IRQ_ENETSW_TX_DMA0 34
+#define BCM6328_IRQ_ENETSW_TX_DMA1 35
+#define BCM6328_IRQ_UART1 39
+#define BCM6328_IRQ_ENETSW 40
+#define BCM6328_IRQ_OHCI 41
+#define BCM6328_IRQ_EHCI 42
+#define BCM6328_IRQ_ATM_DMA0 43
+#define BCM6328_IRQ_ATM_DMA1 44
+#define BCM6328_IRQ_ATM_DMA2 45
+#define BCM6328_IRQ_ATM_DMA3 46
+#define BCM6328_IRQ_ATM_DMA4 47
+#define BCM6328_IRQ_ATM_DMA5 48
+#define BCM6328_IRQ_ATM_DMA6 49
+#define BCM6328_IRQ_ATM_DMA7 50
+#define BCM6328_IRQ_ATM_DMA8 51
+#define BCM6328_IRQ_ATM_DMA9 52
+#define BCM6328_IRQ_ATM_DMA10 53
+#define BCM6328_IRQ_ATM_DMA11 54
+#define BCM6328_IRQ_ATM_DMA12 55
+#define BCM6328_IRQ_ATM_DMA13 56
+#define BCM6328_IRQ_ATM_DMA14 57
+#define BCM6328_IRQ_ATM_DMA15 58
+#define BCM6328_IRQ_ATM_DMA16 59
+#define BCM6328_IRQ_ATM_DMA17 60
+#define BCM6328_IRQ_ATM_DMA18 61
+#define BCM6328_IRQ_ATM_DMA19 62
+#define BCM6328_IRQ_SAR 63
+
+#endif /* __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6328_H */
--
2.28.0

2020-08-12 06:34:40

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 01/14] mips: dts: brcm: allow including header files

Change /include/ with #include in order to be able to include header files
from dt-bindings.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts | 2 +-
arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm93384wvg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts | 2 +-
arch/mips/boot/dts/brcm/bcm96368mvwg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97358svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97360svmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97420c.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97425svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm9ejtagprb.dts | 2 +-
16 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts b/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts
index ed6023a91763..d702a843c74a 100644
--- a/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts
+++ b/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm3368.dtsi"
+#include "bcm3368.dtsi"

/ {
compatible = "netgear,cvg834g", "brcm,bcm3368";
diff --git a/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts b/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts
index 8d010b919de2..b511bc7125d5 100644
--- a/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts
+++ b/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm63268.dtsi"
+#include "bcm63268.dtsi"

/ {
compatible = "comtrend,vr-3032u", "brcm,bcm63268";
diff --git a/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts b/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts
index 53e57cc29291..c646690ee3df 100644
--- a/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts
+++ b/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6358.dtsi"
+#include "bcm6358.dtsi"

/ {
compatible = "sfr,nb4-ser", "brcm,bcm6358";
diff --git a/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts b/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts
index 3e83bee5b91e..f83d95ca0514 100644
--- a/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts
+++ b/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6362.dtsi"
+#include "bcm6362.dtsi"

/ {
compatible = "sfr,nb6-ser", "brcm,bcm6362";
diff --git a/arch/mips/boot/dts/brcm/bcm93384wvg.dts b/arch/mips/boot/dts/brcm/bcm93384wvg.dts
index 601e4d9293ab..7d3f181b8980 100644
--- a/arch/mips/boot/dts/brcm/bcm93384wvg.dts
+++ b/arch/mips/boot/dts/brcm/bcm93384wvg.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm3384_zephyr.dtsi"
+#include "bcm3384_zephyr.dtsi"

/ {
compatible = "brcm,bcm93384wvg", "brcm,bcm3384";
diff --git a/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts b/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts
index 938a8e66128c..f845faa0d682 100644
--- a/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts
+++ b/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm3384_viper.dtsi"
+#include "bcm3384_viper.dtsi"

/ {
compatible = "brcm,bcm93384wvg-viper", "brcm,bcm3384-viper";
diff --git a/arch/mips/boot/dts/brcm/bcm96368mvwg.dts b/arch/mips/boot/dts/brcm/bcm96368mvwg.dts
index 6d772c394e41..f5e955085308 100644
--- a/arch/mips/boot/dts/brcm/bcm96368mvwg.dts
+++ b/arch/mips/boot/dts/brcm/bcm96368mvwg.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6368.dtsi"
+#include "bcm6368.dtsi"

/ {
compatible = "brcm,bcm96368mvwg", "brcm,bcm6368";
diff --git a/arch/mips/boot/dts/brcm/bcm97125cbmb.dts b/arch/mips/boot/dts/brcm/bcm97125cbmb.dts
index 79e9769f7e00..bda5f796251a 100644
--- a/arch/mips/boot/dts/brcm/bcm97125cbmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97125cbmb.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7125.dtsi"
+#include "bcm7125.dtsi"

/ {
compatible = "brcm,bcm97125cbmb", "brcm,bcm7125";
diff --git a/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts b/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts
index 28370ff77eeb..9f73735e815c 100644
--- a/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7346.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch24.dtsi"
+#include "bcm7346.dtsi"
+#include "bcm97xxx-nand-cs1-bch24.dtsi"

/ {
compatible = "brcm,bcm97346dbsmb", "brcm,bcm7346";
diff --git a/arch/mips/boot/dts/brcm/bcm97358svmb.dts b/arch/mips/boot/dts/brcm/bcm97358svmb.dts
index 41c1b510c230..522f2c40d6e6 100644
--- a/arch/mips/boot/dts/brcm/bcm97358svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97358svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7358.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch4.dtsi"
+#include "bcm7358.dtsi"
+#include "bcm97xxx-nand-cs1-bch4.dtsi"

/ {
compatible = "brcm,bcm97358svmb", "brcm,bcm7358";
diff --git a/arch/mips/boot/dts/brcm/bcm97360svmb.dts b/arch/mips/boot/dts/brcm/bcm97360svmb.dts
index 9f6c6c9b7ea7..01f215b08dba 100644
--- a/arch/mips/boot/dts/brcm/bcm97360svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97360svmb.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7360.dtsi"
+#include "bcm7360.dtsi"

/ {
compatible = "brcm,bcm97360svmb", "brcm,bcm7360";
diff --git a/arch/mips/boot/dts/brcm/bcm97362svmb.dts b/arch/mips/boot/dts/brcm/bcm97362svmb.dts
index df8b755c390f..97aeb51b6831 100644
--- a/arch/mips/boot/dts/brcm/bcm97362svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97362svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7362.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch4.dtsi"
+#include "bcm7362.dtsi"
+#include "bcm97xxx-nand-cs1-bch4.dtsi"

/ {
compatible = "brcm,bcm97362svmb", "brcm,bcm7362";
diff --git a/arch/mips/boot/dts/brcm/bcm97420c.dts b/arch/mips/boot/dts/brcm/bcm97420c.dts
index 086faeaa384a..cc70c2dd4d85 100644
--- a/arch/mips/boot/dts/brcm/bcm97420c.dts
+++ b/arch/mips/boot/dts/brcm/bcm97420c.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7420.dtsi"
+#include "bcm7420.dtsi"

/ {
compatible = "brcm,bcm97420c", "brcm,bcm7420";
diff --git a/arch/mips/boot/dts/brcm/bcm97425svmb.dts b/arch/mips/boot/dts/brcm/bcm97425svmb.dts
index 0ed22217bf3a..9efecfe1e05c 100644
--- a/arch/mips/boot/dts/brcm/bcm97425svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97425svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7425.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch24.dtsi"
+#include "bcm7425.dtsi"
+#include "bcm97xxx-nand-cs1-bch24.dtsi"

/ {
compatible = "brcm,bcm97425svmb", "brcm,bcm7425";
diff --git a/arch/mips/boot/dts/brcm/bcm97435svmb.dts b/arch/mips/boot/dts/brcm/bcm97435svmb.dts
index 2c145a883aef..b653c6ff74b5 100644
--- a/arch/mips/boot/dts/brcm/bcm97435svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97435svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7435.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch24.dtsi"
+#include "bcm7435.dtsi"
+#include "bcm97xxx-nand-cs1-bch24.dtsi"

/ {
compatible = "brcm,bcm97435svmb", "brcm,bcm7435";
diff --git a/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts b/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts
index 8d58c1971b30..615d2b97770e 100644
--- a/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts
+++ b/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6328.dtsi"
+#include "bcm6328.dtsi"

/ {
compatible = "brcm,bcm9ejtagprb", "brcm,bcm6328";
--
2.28.0

2020-08-12 06:34:48

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 07/14] mips: bmips: add BCM6368 irq definitions

Add header with BCM6368 definitions in order to be able to include it from
device tree files.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
.../bcm6368-interrupt-controller.h | 71 +++++++++++++++++++
1 file changed, 71 insertions(+)
create mode 100644 include/dt-bindings/interrupt-controller/bcm6368-interrupt-controller.h

diff --git a/include/dt-bindings/interrupt-controller/bcm6368-interrupt-controller.h b/include/dt-bindings/interrupt-controller/bcm6368-interrupt-controller.h
new file mode 100644
index 000000000000..988e368cc156
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/bcm6368-interrupt-controller.h
@@ -0,0 +1,71 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6368_H
+#define __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6368_H
+
+#define BCM6368_IRQ_TIMER 0
+#define BCM6368_IRQ_SPI 1
+#define BCM6368_IRQ_UART0 2
+#define BCM6368_IRQ_UART1 3
+#define BCM6368_IRQ_XDSL 4
+#define BCM6368_IRQ_OHCI 5
+#define BCM6368_IRQ_IPSEC 6
+#define BCM6368_IRQ_EHCI 7
+#define BCM6368_IRQ_USBS 8
+#define BCM6368_IRQ_RING_OSC 9
+#define BCM6368_IRQ_NAND 10
+#define BCM6368_IRQ_ATM 11
+#define BCM6368_IRQ_PCM 12
+#define BCM6368_IRQ_MPI 13
+#define BCM6368_IRQ_DG 14
+#define BCM6368_IRQ_EPHY 15
+#define BCM6368_IRQ_EPHY_EN0 16
+#define BCM6368_IRQ_EPHY_EN1 17
+#define BCM6368_IRQ_EPHY_EN2 18
+#define BCM6368_IRQ_EPHY_EN3 19
+#define BCM6368_IRQ_EXT0 20
+#define BCM6368_IRQ_EXT1 21
+#define BCM6368_IRQ_EXT2 22
+#define BCM6368_IRQ_EXT3 23
+#define BCM6368_IRQ_EXT4 24
+#define BCM6368_IRQ_EXT5 25
+#define BCM6368_IRQ_USB_CTL_RX_DMA 26
+#define BCM6368_IRQ_USB_CTL_TX_DMA 27
+#define BCM6368_IRQ_USB_BULK_RX_DMA 28
+#define BCM6368_IRQ_USB_BULK_TX_DMA 29
+#define BCM6368_IRQ_USB_ISO_RX_DMA 30
+#define BCM6368_IRQ_USB_ISO_TX_DMA 31
+#define BCM6368_IRQ_ENETSW_RX_DMA0 32
+#define BCM6368_IRQ_ENETSW_RX_DMA1 33
+#define BCM6368_IRQ_ENETSW_RX_DMA2 34
+#define BCM6368_IRQ_ENETSW_RX_DMA3 35
+#define BCM6368_IRQ_ENETSW_TX_DMA0 36
+#define BCM6368_IRQ_ENETSW_TX_DMA1 37
+#define BCM6368_IRQ_ENETSW_TX_DMA2 38
+#define BCM6368_IRQ_ENETSW_TX_DMA3 39
+#define BCM6368_IRQ_ATM_DMA0 40
+#define BCM6368_IRQ_ATM_DMA1 41
+#define BCM6368_IRQ_ATM_DMA2 42
+#define BCM6368_IRQ_ATM_DMA3 43
+#define BCM6368_IRQ_ATM_DMA4 44
+#define BCM6368_IRQ_ATM_DMA5 45
+#define BCM6368_IRQ_ATM_DMA6 46
+#define BCM6368_IRQ_ATM_DMA7 47
+#define BCM6368_IRQ_ATM_DMA8 48
+#define BCM6368_IRQ_ATM_DMA9 49
+#define BCM6368_IRQ_ATM_DMA10 50
+#define BCM6368_IRQ_ATM_DMA11 51
+#define BCM6368_IRQ_ATM_DMA12 52
+#define BCM6368_IRQ_ATM_DMA13 53
+#define BCM6368_IRQ_ATM_DMA14 54
+#define BCM6368_IRQ_ATM_DMA15 55
+#define BCM6368_IRQ_ATM_DMA16 56
+#define BCM6368_IRQ_ATM_DMA17 57
+#define BCM6368_IRQ_ATM_DMA18 58
+#define BCM6368_IRQ_ATM_DMA19 59
+#define BCM6368_IRQ_IPSEC_DMA0 60
+#define BCM6368_IRQ_IPSEC_DMA1 61
+#define BCM6368_IRQ_PCM_DMA0 62
+#define BCM6368_IRQ_PCM_DMA1 63
+
+#endif /* __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6368_H */
--
2.28.0

2020-08-12 06:35:22

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 08/14] mips: bmips: add BCM63268 irq definitions

Add header with BCM63268 definitions in order to be able to include it from
device tree files.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
.../bcm63268-interrupt-controller.h | 86 +++++++++++++++++++
1 file changed, 86 insertions(+)
create mode 100644 include/dt-bindings/interrupt-controller/bcm63268-interrupt-controller.h

diff --git a/include/dt-bindings/interrupt-controller/bcm63268-interrupt-controller.h b/include/dt-bindings/interrupt-controller/bcm63268-interrupt-controller.h
new file mode 100644
index 000000000000..8589e8686d60
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/bcm63268-interrupt-controller.h
@@ -0,0 +1,86 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM63268_H
+#define __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM63268_H
+
+#define BCM63268_IRQ_TIMER 0
+#define BCM63268_IRQ_ENETSW_RX_DMA0 1
+#define BCM63268_IRQ_ENETSW_RX_DMA1 2
+#define BCM63268_IRQ_ENETSW_RX_DMA2 3
+#define BCM63268_IRQ_ENETSW_RX_DMA3 4
+#define BCM63268_IRQ_UART0 5
+#define BCM63268_IRQ_HSSPI 6
+#define BCM63268_IRQ_WLAN 7
+#define BCM63268_IRQ_IPSEC 8
+#define BCM63268_IRQ_OHCI 9
+#define BCM63268_IRQ_EHCI 10
+#define BCM63268_IRQ_USBS 11
+#define BCM63268_IRQ_PCM 12
+#define BCM63268_IRQ_EPHY 13
+#define BCM63268_IRQ_DG 14
+#define BCM63268_IRQ_EPHY0_EN 15
+#define BCM63268_IRQ_EPHY1_EN 16
+#define BCM63268_IRQ_EPHY2_EN 17
+#define BCM63268_IRQ_GPHY_EN 18
+#define BCM63268_IRQ_USB_CTL_RX_DMA 19
+#define BCM63268_IRQ_USB_BULK_RX_DMA 20
+#define BCM63268_IRQ_ISO_RX_DMA 21
+#define BCM63268_IRQ_IPSEC_DMA0 22
+#define BCM63268_IRQ_XDSL 23
+#define BCM63268_IRQ_FAP0 24
+#define BCM63268_IRQ_FAP1 25
+#define BCM63268_IRQ_ATM_DMA0 26
+#define BCM63268_IRQ_ATM_DMA1 27
+#define BCM63268_IRQ_ATM_DMA2 28
+#define BCM63268_IRQ_ATM_DMA3 29
+#define BCM63268_IRQ_WAKE_ON_IRQ 30
+#define BCM63268_IRQ_GPHY 31
+#define BCM63268_IRQ_DECT0 32
+#define BCM63268_IRQ_DECT1 33
+#define BCM63268_IRQ_UART1 34
+#define BCM63268_IRQ_WLAN_GPIO 35
+#define BCM63268_IRQ_USB_CTL_TX_DMA 36
+#define BCM63268_IRQ_USB_BULK_TX_DMA 37
+#define BCM63268_IRQ_ISO_TX_DMA 38
+#define BCM63268_IRQ_IPSEC_DMA1 39
+#define BCM63268_IRQ_PCIE_RC 40
+#define BCM63268_IRQ_PCIE_EP 41
+#define BCM63268_IRQ_PCM_DMA0 42
+#define BCM63268_IRQ_PCM_DMA1 43
+#define BCM63268_IRQ_EXT0 44
+#define BCM63268_IRQ_EXT1 45
+#define BCM63268_IRQ_EXT2 46
+#define BCM63268_IRQ_EXT3 47
+#define BCM63268_IRQ_ENETSW 48
+#define BCM63268_IRQ_SAR 49
+#define BCM63268_IRQ_NAND 50
+#define BCM63268_IRQ_RING_OSC 52
+#define BCM63268_IRQ_USB_CONNECT 53
+#define BCM63268_IRQ_USB_DISCONNECT 54
+#define BCM63268_IRQ_PER_MBOX0 55
+#define BCM63268_IRQ_PER_MBOX1 56
+#define BCM63268_IRQ_PER_MBOX2 57
+#define BCM63268_IRQ_PER_MBOX3 58
+#define BCM63268_IRQ_ATM_DMA4 59
+#define BCM63268_IRQ_ATM_DMA5 60
+#define BCM63268_IRQ_ATM_DMA6 61
+#define BCM63268_IRQ_ATM_DMA7 62
+#define BCM63268_IRQ_ENETSW_TX_DMA0 64
+#define BCM63268_IRQ_ENETSW_TX_DMA1 65
+#define BCM63268_IRQ_ENETSW_TX_DMA2 66
+#define BCM63268_IRQ_ENETSW_TX_DMA3 67
+#define BCM63268_IRQ_ATM_DMA8 68
+#define BCM63268_IRQ_ATM_DMA9 69
+#define BCM63268_IRQ_ATM_DMA10 70
+#define BCM63268_IRQ_ATM_DMA11 71
+#define BCM63268_IRQ_ATM_DMA12 72
+#define BCM63268_IRQ_ATM_DMA13 73
+#define BCM63268_IRQ_ATM_DMA14 74
+#define BCM63268_IRQ_ATM_DMA15 75
+#define BCM63268_IRQ_ATM_DMA16 76
+#define BCM63268_IRQ_ATM_DMA17 77
+#define BCM63268_IRQ_ATM_DMA18 78
+#define BCM63268_IRQ_ATM_DMA19 79
+#define BCM63268_IRQ_LSSPI 80
+
+#endif /* __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM63268_H */
--
2.28.0

2020-08-12 06:36:24

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 03/14] mips: bmips: add BCM6318 irq definitions

Add header with BCM6318 definitions in order to be able to include it from
device tree files.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
.../bcm6318-interrupt-controller.h | 84 +++++++++++++++++++
1 file changed, 84 insertions(+)
create mode 100644 include/dt-bindings/interrupt-controller/bcm6318-interrupt-controller.h

diff --git a/include/dt-bindings/interrupt-controller/bcm6318-interrupt-controller.h b/include/dt-bindings/interrupt-controller/bcm6318-interrupt-controller.h
new file mode 100644
index 000000000000..7882dcb279c4
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/bcm6318-interrupt-controller.h
@@ -0,0 +1,84 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6318_H
+#define __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6318_H
+
+#define BCM6318_IRQ_TIMER0 0
+#define BCM6318_IRQ_TIMER1 1
+#define BCM6318_IRQ_TIMER2 2
+#define BCM6318_IRQ_TIMER3 3
+#define BCM6318_IRQ_USBS 4
+#define BCM6318_IRQ_USB_CTL_RX_DMA 5
+#define BCM6318_IRQ_USB_CTL_TX_DMA 6
+#define BCM6318_IRQ_USB_BULK_RX_DMA 7
+#define BCM6318_IRQ_USB_BULK_TX_DMA 8
+#define BCM6318_IRQ_USB_ISO_RX_DMA 9
+#define BCM6318_IRQ_USB_ISO_TX_DMA 10
+#define BCM6318_IRQ_DG 11
+#define BCM6318_IRQ_EPHY 12
+#define BCM6318_IRQ_EPHY_EN0N 13
+#define BCM6318_IRQ_EPHY_EN1N 14
+#define BCM6318_IRQ_EPHY_EN2N 15
+#define BCM6318_IRQ_EPHY_EN3N 16
+#define BCM6318_IRQ_EPHY_EN0 17
+#define BCM6318_IRQ_EPHY_EN1 18
+#define BCM6318_IRQ_EPHY_EN2 19
+#define BCM6318_IRQ_EPHY_EN3 20
+#define BCM6318_IRQ_XDSL 21
+#define BCM6318_IRQ_SDR 22
+#define BCM6318_IRQ_PCIE_RC 23
+#define BCM6318_IRQ_EXT0 24
+#define BCM6318_IRQ_EXT1 25
+#define BCM6318_IRQ_EXT2 26
+#define BCM6318_IRQ_EXT3 27
+#define BCM6318_IRQ_UART0 28
+#define BCM6318_IRQ_HSSPI 29
+#define BCM6318_IRQ_WAKE_ON_IRQ 30
+#define BCM6318_IRQ_TIMER 31
+#define BCM6318_IRQ_ENETSW_RX_DMA0 32
+#define BCM6318_IRQ_ENETSW_RX_DMA1 33
+#define BCM6318_IRQ_ENETSW_RX_DMA2 34
+#define BCM6318_IRQ_ENETSW_RX_DMA3 35
+#define BCM6318_IRQ_WDTIMER 37
+#define BCM6318_IRQ_ENETSW 40
+#define BCM6318_IRQ_OHCI 41
+#define BCM6318_IRQ_EHCI 42
+#define BCM6318_IRQ_ATM_DMA0 43
+#define BCM6318_IRQ_ATM_DMA1 44
+#define BCM6318_IRQ_ATM_DMA2 45
+#define BCM6318_IRQ_ATM_DMA3 46
+#define BCM6318_IRQ_ATM_DMA4 47
+#define BCM6318_IRQ_ATM_DMA5 48
+#define BCM6318_IRQ_ATM_DMA6 49
+#define BCM6318_IRQ_ATM_DMA7 50
+#define BCM6318_IRQ_ATM_DMA8 51
+#define BCM6318_IRQ_ATM_DMA9 52
+#define BCM6318_IRQ_ATM_DMA10 53
+#define BCM6318_IRQ_ATM_DMA11 54
+#define BCM6318_IRQ_ATM_DMA12 55
+#define BCM6318_IRQ_ATM_DMA13 56
+#define BCM6318_IRQ_ATM_DMA14 57
+#define BCM6318_IRQ_ATM_DMA15 58
+#define BCM6318_IRQ_ATM_DMA16 59
+#define BCM6318_IRQ_ATM_DMA17 60
+#define BCM6318_IRQ_ATM_DMA18 61
+#define BCM6318_IRQ_ATM_DMA19 62
+#define BCM6318_IRQ_SAR 63
+#define BCM6318_IRQ_ADSL_ENERGY 64
+#define BCM6318_IRQ_ADSL_ENERGY_N 65
+#define BCM6318_IRQ_USB_ENERGY_ON 66
+#define BCM6318_IRQ_USB_ENERGY_OFF 67
+#define BCM6318_IRQ_PVTMON_TEMP 68
+#define BCM6318_IRQ_SYSPLL_LOCK 69
+#define BCM6318_IRQ_LCPLL_LOCK 70
+#define BCM6318_IRQ_PMU_STABLE 71
+#define BCM6318_IRQ_ENETSW_TX_DMA0 72
+#define BCM6318_IRQ_ENETSW_TX_DMA1 73
+#define BCM6318_IRQ_ENETSW_TX_DMA2 74
+#define BCM6318_IRQ_ENETSW_TX_DMA3 75
+#define BCM6318_IRQ_EPHY0_IDDQ_ENERGY 76
+#define BCM6318_IRQ_EPHY1_IDDQ_ENERGY 77
+#define BCM6318_IRQ_EPHY2_IDDQ_ENERGY 78
+#define BCM6318_IRQ_EPHY3_IDDQ_ENERGY 79
+
+#endif /* __DT_BINDINGS_INTERRUPT_CONTROLLER_BCM6318_H */
--
2.28.0

2020-08-13 16:56:02

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 01/14] mips: dts: brcm: allow including header files



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Change /include/ with #include in order to be able to include header files
> from dt-bindings.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 16:58:17

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 02/14] mips: bmips: add BCM3368 irq definitions



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Add header with BCM3368 definitions in order to be able to include it from
> device tree files.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:00:09

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 09/14] mips: bmips: bcm3368: include and use dt-bindings



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Now that there are proper device tree bindings we can start using them.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:00:26

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 10/14] mips: bmips: bcm6328: include and use dt-bindings



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Now that there are proper device tree bindings we can start using them.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:00:41

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 03/14] mips: bmips: add BCM6318 irq definitions



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Add header with BCM6318 definitions in order to be able to include it from
> device tree files.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:01:22

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 12/14] mips: bmips: bcm6362: include and use dt-bindings



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Now that there are proper device tree bindings we can start using them.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:01:57

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 13/14] mips: bmips: bcm6368: include and use dt-bindings



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Now that there are proper device tree bindings we can start using them.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:02:20

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 14/14] mips: bmips: bcm63268: include and use dt-bindings



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Now that there are proper device tree bindings we can start using them.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:03:08

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 11/14] mips: bmips: bcm6358: include and use dt-bindings



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Now that there are proper device tree bindings we can start using them.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:03:14

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 05/14] mips: bmips: add BCM6358 irq definitions



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Add header with BCM6358 definitions in order to be able to include it from
> device tree files.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:03:28

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 06/14] mips: bmips: add BCM6362 irq definitions



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Add header with BCM6362 definitions in order to be able to include it from
> device tree files.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:04:48

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 08/14] mips: bmips: add BCM63268 irq definitions



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Add header with BCM63268 definitions in order to be able to include it from
> device tree files.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:04:56

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 04/14] mips: bmips: add BCM6328 irq definitions



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Add header with BCM6328 definitions in order to be able to include it from
> device tree files.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-13 17:06:01

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 07/14] mips: bmips: add BCM6368 irq definitions



On 8/11/2020 11:31 PM, Álvaro Fernández Rojas wrote:
> Add header with BCM6368 definitions in order to be able to include it from
> device tree files.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2020-08-24 23:16:43

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 00/14] mips: bmips: include dt-bindings headers

On Wed, Aug 12, 2020 at 08:31:15AM +0200, ?lvaro Fern?ndez Rojas wrote:
> Allow including dt-bindings header files and use them for bcm63xx.
>
> ?lvaro Fern?ndez Rojas (14):
> mips: dts: brcm: allow including header files
> mips: bmips: add BCM3368 irq definitions
> mips: bmips: add BCM6318 irq definitions
> mips: bmips: add BCM6328 irq definitions
> mips: bmips: add BCM6358 irq definitions
> mips: bmips: add BCM6362 irq definitions
> mips: bmips: add BCM6368 irq definitions
> mips: bmips: add BCM63268 irq definitions
> mips: bmips: bcm3368: include and use dt-bindings
> mips: bmips: bcm6328: include and use dt-bindings
> mips: bmips: bcm6358: include and use dt-bindings
> mips: bmips: bcm6362: include and use dt-bindings
> mips: bmips: bcm6368: include and use dt-bindings
> mips: bmips: bcm63268: include and use dt-bindings
>
> .../boot/dts/brcm/bcm3368-netgear-cvg834g.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm3368.dtsi | 8 +-
> .../dts/brcm/bcm63268-comtrend-vr-3032u.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm63268.dtsi | 12 ++-
> arch/mips/boot/dts/brcm/bcm6328.dtsi | 12 ++-
> .../dts/brcm/bcm6358-neufbox4-sercomm.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm6358.dtsi | 12 ++-
> .../dts/brcm/bcm6362-neufbox6-sercomm.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm6362.dtsi | 12 ++-
> arch/mips/boot/dts/brcm/bcm6368.dtsi | 12 ++-
> arch/mips/boot/dts/brcm/bcm93384wvg.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm96368mvwg.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 +-
> arch/mips/boot/dts/brcm/bcm97358svmb.dts | 4 +-
> arch/mips/boot/dts/brcm/bcm97360svmb.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 +-
> arch/mips/boot/dts/brcm/bcm97420c.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97425svmb.dts | 4 +-
> arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 +-
> arch/mips/boot/dts/brcm/bcm9ejtagprb.dts | 2 +-
> .../bcm3368-interrupt-controller.h | 19 ++++
> .../bcm6318-interrupt-controller.h | 84 ++++++++++++++++++
> .../bcm63268-interrupt-controller.h | 86 +++++++++++++++++++
> .../bcm6328-interrupt-controller.h | 68 +++++++++++++++
> .../bcm6358-interrupt-controller.h | 38 ++++++++
> .../bcm6362-interrupt-controller.h | 71 +++++++++++++++
> .../bcm6368-interrupt-controller.h | 71 +++++++++++++++

You'll notice that there are essentially no other headers with
SoC interrupt numbers. That's because we don't do defines for them. It's
pointless obfuscation.

Rob

2021-02-24 09:41:04

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 0/7] mips: bmips: include dt-bindings headers

Allow including dt-bindings header files for bcm63xx.

v2: remove irqs header and add more bindings.

Álvaro Fernández Rojas (7):
mips: dts: brcm: allow including header files
mips: bmips: bcm3368: include dt-bindings
mips: bmips: bcm6328: include dt-bindings
mips: bmips: bcm6358: include dt-bindings
mips: bmips: bcm6362: include dt-bindings
mips: bmips: bcm6368: include dt-bindings
mips: bmips: bcm63268: include dt-bindings

arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts | 2 +-
arch/mips/boot/dts/brcm/bcm3368.dtsi | 3 +++
arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts | 2 +-
arch/mips/boot/dts/brcm/bcm63268.dtsi | 5 +++++
arch/mips/boot/dts/brcm/bcm6328.dtsi | 5 +++++
arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6358.dtsi | 4 ++++
arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6362.dtsi | 5 +++++
arch/mips/boot/dts/brcm/bcm6368.dtsi | 4 ++++
arch/mips/boot/dts/brcm/bcm93384wvg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts | 2 +-
arch/mips/boot/dts/brcm/bcm96368mvwg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97358svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97360svmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97420c.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97425svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm9ejtagprb.dts | 2 +-
22 files changed, 47 insertions(+), 21 deletions(-)

--
2.20.1

2021-02-24 09:42:12

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 3/7] mips: bmips: bcm6328: include dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
v2: remove irqs header, add more bindings.

arch/mips/boot/dts/brcm/bcm6328.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/mips/boot/dts/brcm/bcm6328.dtsi b/arch/mips/boot/dts/brcm/bcm6328.dtsi
index 9dc558763c46..fe93f2692281 100644
--- a/arch/mips/boot/dts/brcm/bcm6328.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6328.dtsi
@@ -1,4 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6328-clock.h"
+#include "dt-bindings/reset/bcm6328-reset.h"
+#include "dt-bindings/soc/bcm6328-pm.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
--
2.20.1

2021-02-24 09:42:35

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 1/7] mips: dts: brcm: allow including header files

Change /include/ with #include in order to be able to include header files
from dt-bindings.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
v2: no changes.

arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts | 2 +-
arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts | 2 +-
arch/mips/boot/dts/brcm/bcm93384wvg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts | 2 +-
arch/mips/boot/dts/brcm/bcm96368mvwg.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97358svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97360svmb.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97420c.dts | 2 +-
arch/mips/boot/dts/brcm/bcm97425svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 ++--
arch/mips/boot/dts/brcm/bcm9ejtagprb.dts | 2 +-
16 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts b/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts
index ed6023a91763..d702a843c74a 100644
--- a/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts
+++ b/arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm3368.dtsi"
+#include "bcm3368.dtsi"

/ {
compatible = "netgear,cvg834g", "brcm,bcm3368";
diff --git a/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts b/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts
index 8d010b919de2..b511bc7125d5 100644
--- a/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts
+++ b/arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm63268.dtsi"
+#include "bcm63268.dtsi"

/ {
compatible = "comtrend,vr-3032u", "brcm,bcm63268";
diff --git a/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts b/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts
index 53e57cc29291..c646690ee3df 100644
--- a/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts
+++ b/arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6358.dtsi"
+#include "bcm6358.dtsi"

/ {
compatible = "sfr,nb4-ser", "brcm,bcm6358";
diff --git a/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts b/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts
index 3e83bee5b91e..f83d95ca0514 100644
--- a/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts
+++ b/arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6362.dtsi"
+#include "bcm6362.dtsi"

/ {
compatible = "sfr,nb6-ser", "brcm,bcm6362";
diff --git a/arch/mips/boot/dts/brcm/bcm93384wvg.dts b/arch/mips/boot/dts/brcm/bcm93384wvg.dts
index 601e4d9293ab..7d3f181b8980 100644
--- a/arch/mips/boot/dts/brcm/bcm93384wvg.dts
+++ b/arch/mips/boot/dts/brcm/bcm93384wvg.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm3384_zephyr.dtsi"
+#include "bcm3384_zephyr.dtsi"

/ {
compatible = "brcm,bcm93384wvg", "brcm,bcm3384";
diff --git a/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts b/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts
index 938a8e66128c..f845faa0d682 100644
--- a/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts
+++ b/arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm3384_viper.dtsi"
+#include "bcm3384_viper.dtsi"

/ {
compatible = "brcm,bcm93384wvg-viper", "brcm,bcm3384-viper";
diff --git a/arch/mips/boot/dts/brcm/bcm96368mvwg.dts b/arch/mips/boot/dts/brcm/bcm96368mvwg.dts
index 6d772c394e41..f5e955085308 100644
--- a/arch/mips/boot/dts/brcm/bcm96368mvwg.dts
+++ b/arch/mips/boot/dts/brcm/bcm96368mvwg.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6368.dtsi"
+#include "bcm6368.dtsi"

/ {
compatible = "brcm,bcm96368mvwg", "brcm,bcm6368";
diff --git a/arch/mips/boot/dts/brcm/bcm97125cbmb.dts b/arch/mips/boot/dts/brcm/bcm97125cbmb.dts
index 79e9769f7e00..bda5f796251a 100644
--- a/arch/mips/boot/dts/brcm/bcm97125cbmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97125cbmb.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7125.dtsi"
+#include "bcm7125.dtsi"

/ {
compatible = "brcm,bcm97125cbmb", "brcm,bcm7125";
diff --git a/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts b/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts
index 28370ff77eeb..9f73735e815c 100644
--- a/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97346dbsmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7346.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch24.dtsi"
+#include "bcm7346.dtsi"
+#include "bcm97xxx-nand-cs1-bch24.dtsi"

/ {
compatible = "brcm,bcm97346dbsmb", "brcm,bcm7346";
diff --git a/arch/mips/boot/dts/brcm/bcm97358svmb.dts b/arch/mips/boot/dts/brcm/bcm97358svmb.dts
index 41c1b510c230..522f2c40d6e6 100644
--- a/arch/mips/boot/dts/brcm/bcm97358svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97358svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7358.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch4.dtsi"
+#include "bcm7358.dtsi"
+#include "bcm97xxx-nand-cs1-bch4.dtsi"

/ {
compatible = "brcm,bcm97358svmb", "brcm,bcm7358";
diff --git a/arch/mips/boot/dts/brcm/bcm97360svmb.dts b/arch/mips/boot/dts/brcm/bcm97360svmb.dts
index 9f6c6c9b7ea7..01f215b08dba 100644
--- a/arch/mips/boot/dts/brcm/bcm97360svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97360svmb.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7360.dtsi"
+#include "bcm7360.dtsi"

/ {
compatible = "brcm,bcm97360svmb", "brcm,bcm7360";
diff --git a/arch/mips/boot/dts/brcm/bcm97362svmb.dts b/arch/mips/boot/dts/brcm/bcm97362svmb.dts
index df8b755c390f..97aeb51b6831 100644
--- a/arch/mips/boot/dts/brcm/bcm97362svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97362svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7362.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch4.dtsi"
+#include "bcm7362.dtsi"
+#include "bcm97xxx-nand-cs1-bch4.dtsi"

/ {
compatible = "brcm,bcm97362svmb", "brcm,bcm7362";
diff --git a/arch/mips/boot/dts/brcm/bcm97420c.dts b/arch/mips/boot/dts/brcm/bcm97420c.dts
index 086faeaa384a..cc70c2dd4d85 100644
--- a/arch/mips/boot/dts/brcm/bcm97420c.dts
+++ b/arch/mips/boot/dts/brcm/bcm97420c.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7420.dtsi"
+#include "bcm7420.dtsi"

/ {
compatible = "brcm,bcm97420c", "brcm,bcm7420";
diff --git a/arch/mips/boot/dts/brcm/bcm97425svmb.dts b/arch/mips/boot/dts/brcm/bcm97425svmb.dts
index 0ed22217bf3a..9efecfe1e05c 100644
--- a/arch/mips/boot/dts/brcm/bcm97425svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97425svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7425.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch24.dtsi"
+#include "bcm7425.dtsi"
+#include "bcm97xxx-nand-cs1-bch24.dtsi"

/ {
compatible = "brcm,bcm97425svmb", "brcm,bcm7425";
diff --git a/arch/mips/boot/dts/brcm/bcm97435svmb.dts b/arch/mips/boot/dts/brcm/bcm97435svmb.dts
index 2c145a883aef..b653c6ff74b5 100644
--- a/arch/mips/boot/dts/brcm/bcm97435svmb.dts
+++ b/arch/mips/boot/dts/brcm/bcm97435svmb.dts
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm7435.dtsi"
-/include/ "bcm97xxx-nand-cs1-bch24.dtsi"
+#include "bcm7435.dtsi"
+#include "bcm97xxx-nand-cs1-bch24.dtsi"

/ {
compatible = "brcm,bcm97435svmb", "brcm,bcm7435";
diff --git a/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts b/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts
index 8d58c1971b30..615d2b97770e 100644
--- a/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts
+++ b/arch/mips/boot/dts/brcm/bcm9ejtagprb.dts
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/dts-v1/;

-/include/ "bcm6328.dtsi"
+#include "bcm6328.dtsi"

/ {
compatible = "brcm,bcm9ejtagprb", "brcm,bcm6328";
--
2.20.1

2021-02-24 09:44:01

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 2/7] mips: bmips: bcm3368: include dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
v2: remove irqs header.

arch/mips/boot/dts/brcm/bcm3368.dtsi | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/mips/boot/dts/brcm/bcm3368.dtsi b/arch/mips/boot/dts/brcm/bcm3368.dtsi
index 69cbef472377..db7e801dad55 100644
--- a/arch/mips/boot/dts/brcm/bcm3368.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm3368.dtsi
@@ -1,4 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm3368-clock.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
--
2.20.1

2021-02-24 09:44:36

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 7/7] mips: bmips: bcm63268: include dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
v2: remove irqs header, add more bindings.

arch/mips/boot/dts/brcm/bcm63268.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi
index e0021ff9f144..575c9d3eb4c8 100644
--- a/arch/mips/boot/dts/brcm/bcm63268.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi
@@ -1,4 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm63268-clock.h"
+#include "dt-bindings/reset/bcm63268-reset.h"
+#include "dt-bindings/soc/bcm63268-pm.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
--
2.20.1

2021-02-24 09:44:36

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 4/7] mips: bmips: bcm6358: include dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
v2: remove irqs header, add more bindings.

arch/mips/boot/dts/brcm/bcm6358.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/mips/boot/dts/brcm/bcm6358.dtsi b/arch/mips/boot/dts/brcm/bcm6358.dtsi
index 9d93e7f5e6fc..f8753becc164 100644
--- a/arch/mips/boot/dts/brcm/bcm6358.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6358.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6358-clock.h"
+#include "dt-bindings/reset/bcm6358-reset.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
--
2.20.1

2021-02-24 09:46:06

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 6/7] mips: bmips: bcm6368: include dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
v2: remove irqs header, add more bindings.

arch/mips/boot/dts/brcm/bcm6368.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/mips/boot/dts/brcm/bcm6368.dtsi b/arch/mips/boot/dts/brcm/bcm6368.dtsi
index 52c19f40b9cc..c4eb4b67ecbd 100644
--- a/arch/mips/boot/dts/brcm/bcm6368.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6368.dtsi
@@ -1,4 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6368-clock.h"
+#include "dt-bindings/reset/bcm6368-reset.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
--
2.20.1

2021-02-24 13:07:25

by Álvaro Fernández Rojas

[permalink] [raw]
Subject: [PATCH 5/7] mips: bmips: bcm6362: include dt-bindings

Now that there are proper device tree bindings we can start using them.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
---
v2: remove irqs header, add more bindings.

arch/mips/boot/dts/brcm/bcm6362.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/mips/boot/dts/brcm/bcm6362.dtsi b/arch/mips/boot/dts/brcm/bcm6362.dtsi
index eb10341b75ba..a2dbbf062cd8 100644
--- a/arch/mips/boot/dts/brcm/bcm6362.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm6362.dtsi
@@ -1,4 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
+
+#include "dt-bindings/clock/bcm6362-clock.h"
+#include "dt-bindings/reset/bcm6362-reset.h"
+#include "dt-bindings/soc/bcm6362-pm.h"
+
/ {
#address-cells = <1>;
#size-cells = <1>;
--
2.20.1

2021-03-12 10:36:07

by Thomas Bogendoerfer

[permalink] [raw]
Subject: Re: [PATCH 0/7] mips: bmips: include dt-bindings headers

On Wed, Feb 24, 2021 at 10:38:49AM +0100, ?lvaro Fern?ndez Rojas wrote:
> Allow including dt-bindings header files for bcm63xx.
>
> v2: remove irqs header and add more bindings.
>
> ?lvaro Fern?ndez Rojas (7):
> mips: dts: brcm: allow including header files
> mips: bmips: bcm3368: include dt-bindings
> mips: bmips: bcm6328: include dt-bindings
> mips: bmips: bcm6358: include dt-bindings
> mips: bmips: bcm6362: include dt-bindings
> mips: bmips: bcm6368: include dt-bindings
> mips: bmips: bcm63268: include dt-bindings
>
> arch/mips/boot/dts/brcm/bcm3368-netgear-cvg834g.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm3368.dtsi | 3 +++
> arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm63268.dtsi | 5 +++++
> arch/mips/boot/dts/brcm/bcm6328.dtsi | 5 +++++
> arch/mips/boot/dts/brcm/bcm6358-neufbox4-sercomm.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm6358.dtsi | 4 ++++
> arch/mips/boot/dts/brcm/bcm6362-neufbox6-sercomm.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm6362.dtsi | 5 +++++
> arch/mips/boot/dts/brcm/bcm6368.dtsi | 4 ++++
> arch/mips/boot/dts/brcm/bcm93384wvg.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm93384wvg_viper.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm96368mvwg.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97125cbmb.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97346dbsmb.dts | 4 ++--
> arch/mips/boot/dts/brcm/bcm97358svmb.dts | 4 ++--
> arch/mips/boot/dts/brcm/bcm97360svmb.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97362svmb.dts | 4 ++--
> arch/mips/boot/dts/brcm/bcm97420c.dts | 2 +-
> arch/mips/boot/dts/brcm/bcm97425svmb.dts | 4 ++--
> arch/mips/boot/dts/brcm/bcm97435svmb.dts | 4 ++--
> arch/mips/boot/dts/brcm/bcm9ejtagprb.dts | 2 +-
> 22 files changed, 47 insertions(+), 21 deletions(-)

series applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]