2021-03-04 18:34:52

by Kieran Bingham

[permalink] [raw]
Subject: [PATCH] arm64: dts: renesas: falcon: Add GP LEDs

Three general purpose LEDs are provided on the Falcon CPU board.

Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
These LEDs are arranged in a block of four LEDs on the board itself, but
the fourth LED is as yet unidentified.

Signed-off-by: Kieran Bingham <[email protected]>
---
arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
index 5617b81dd7dc..a18f84128fe1 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
@@ -20,6 +20,20 @@ aliases {
chosen {
stdout-path = "serial0:115200n8";
};
+
+ leds {
+ compatible = "gpio-leds";
+
+ led1 {
+ gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
+ };
+ led2 {
+ gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
+ };
+ led3 {
+ gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
+ };
+ };
};

&rwdt {
--
2.25.1


2021-03-05 14:12:45

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: renesas: falcon: Add GP LEDs

Hi Kieran,

On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
<[email protected]> wrote:
> Three general purpose LEDs are provided on the Falcon CPU board.
>
> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
> These LEDs are arranged in a block of four LEDs on the board itself, but
> the fourth LED is as yet unidentified.
>
> Signed-off-by: Kieran Bingham <[email protected]>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts

I believe the LEDs are on the CPU board, so they belong in
r8a779a0-falcon-cpu.dtsi instead?

> @@ -20,6 +20,20 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led1 {
> + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;

Any need for other properties from
Documentation/devicetree/bindings/leds/common.yaml, like
color = <LED_COLOR_ID_GREEN>?

> + };
> + led2 {
> + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
> + };
> + led3 {
> + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
> + };
> + };
> };

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-03-05 14:18:44

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: renesas: falcon: Add GP LEDs

On 05/03/2021 14:10, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
> <[email protected]> wrote:
>> Three general purpose LEDs are provided on the Falcon CPU board.
>>
>> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
>> These LEDs are arranged in a block of four LEDs on the board itself, but
>> the fourth LED is as yet unidentified.
>>
>> Signed-off-by: Kieran Bingham <[email protected]>
>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
>
> I believe the LEDs are on the CPU board, so they belong in
> r8a779a0-falcon-cpu.dtsi instead?

Yes, I hadn't quite grasped the layouts of this new board yet.

Sorry - I'll move it.


>
>> @@ -20,6 +20,20 @@ aliases {
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + led1 {
>> + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
>
> Any need for other properties from
> Documentation/devicetree/bindings/leds/common.yaml, like
> color = <LED_COLOR_ID_GREEN>?

Oh, I wasn't aware of those. But indeed the LED is green, so it seems
appropriate.

I'll test it out, and see if I can make it glow red (jokes).


>
>> + };
>> + led2 {
>> + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
>> + };
>> + led3 {
>> + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
>> + };
>> + };
>> };
>
> Gr{oetje,eeting}s,
>
> Geert
>