2021-04-09 07:58:34

by Chen Hui

Subject: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Chen Hui <[email protected]>
---
drivers/pci/controller/pcie-altera-msi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/controller/pcie-altera-msi.c b/drivers/pci/controller/pcie-altera-msi.c
index 42691dd8ebef..98aa1dccc6e6 100644
--- a/drivers/pci/controller/pcie-altera-msi.c
+++ b/drivers/pci/controller/pcie-altera-msi.c
@@ -236,10 +236,8 @@ static int altera_msi_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"vector_slave");
msi->vector_base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(msi->vector_base)) {
- dev_err(&pdev->dev, "failed to map vector_slave memory\n");
+ if (IS_ERR(msi->vector_base))
return PTR_ERR(msi->vector_base);
- }

msi->vector_phy = res->start;

--
2.17.1

2021-04-09 08:57:11

by Tan, Ley Foon

Subject: RE: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe()

> -----Original Message-----
> From: Chen Hui <[email protected]>
> Sent: Friday, April 9, 2021 3:58 PM
> To: Tan, Ley Foon <[email protected]>; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]; linux-
> [email protected]
> Subject: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in
> altera_msi_probe()
>
> There is a error message within devm_ioremap_resource already, so remove
> the dev_err call to avoid redundant error message.
>
> Signed-off-by: Chen Hui <[email protected]>
> ---
> drivers/pci/controller/pcie-altera-msi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-altera-msi.c
> b/drivers/pci/controller/pcie-altera-msi.c
> index 42691dd8ebef..98aa1dccc6e6 100644
> --- a/drivers/pci/controller/pcie-altera-msi.c
> +++ b/drivers/pci/controller/pcie-altera-msi.c
> @@ -236,10 +236,8 @@ static int altera_msi_probe(struct platform_device
> *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "vector_slave");
> msi->vector_base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(msi->vector_base)) {
> - dev_err(&pdev->dev, "failed to map vector_slave
> memory\n");
> + if (IS_ERR(msi->vector_base))
> return PTR_ERR(msi->vector_base);
> - }
>
> msi->vector_phy = res->start;
>
> --


Reviewed-by: Ley Foon Tan <[email protected]>

2021-04-14 18:12:31

by Lorenzo Pieralisi

Subject: Re: [PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe()

On Fri, 9 Apr 2021 15:57:48 +0800, Chen Hui wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied to pci/altera-msi, thanks!

[1/1] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe()
https://git.kernel.org/lpieralisi/pci/c/b1160a06e0

Thanks,
Lorenzo