2021-05-02 00:21:49

by brookxu.cn

Subject: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string

From: Chunguang Xu <[email protected]>

Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a
string is better.

v2: replace some space with tab.

Signed-off-by: Chunguang Xu <[email protected]>
---
include/trace/events/writeback.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 1efa463..7c78c04 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -36,7 +36,8 @@
EM( WB_REASON_PERIODIC, "periodic") \
EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \
EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \
- EMe(WB_REASON_FORKER_THREAD, "forker_thread")
+ EM( WB_REASON_FORKER_THREAD, "forker_thread") \
+ EMe(WB_REASON_FOREIGN_FLUSH, "foreign_flush")

WB_WORK_REASON

--
1.8.3.1

2021-05-03 18:04:43

by Steven Rostedt

Subject: Re: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string

This should go through the folks that maintain the write back trace events.

-- Steve


On Sun, 2 May 2021 08:12:27 +0800
brookxu <[email protected]> wrote:

> From: Chunguang Xu <[email protected]>
>
> Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a
> string is better.
>
> v2: replace some space with tab.
>
> Signed-off-by: Chunguang Xu <[email protected]>
> ---
> include/trace/events/writeback.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 1efa463..7c78c04 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -36,7 +36,8 @@
> EM( WB_REASON_PERIODIC, "periodic") \
> EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \
> EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \
> - EMe(WB_REASON_FORKER_THREAD, "forker_thread")
> + EM( WB_REASON_FORKER_THREAD, "forker_thread") \
> + EMe(WB_REASON_FOREIGN_FLUSH, "foreign_flush")
>
> WB_WORK_REASON
>

2021-05-15 10:56:23

by Steven Rostedt

Subject: Re: [PATCH v2] trace: replace WB_REASON_FOREIGN_FLUSH with a string

Andrew,

Would you like to take this?

-- Steve


On Sun, 2 May 2021 08:12:27 +0800
brookxu <[email protected]> wrote:

> From: Chunguang Xu <[email protected]>
>
> Now WB_REASON_FOREIGN_FLUSH is displayed as a number, maybe a
> string is better.
>
> v2: replace some space with tab.
>
> Signed-off-by: Chunguang Xu <[email protected]>
> ---
> include/trace/events/writeback.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 1efa463..7c78c04 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -36,7 +36,8 @@
> EM( WB_REASON_PERIODIC, "periodic") \
> EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \
> EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \
> - EMe(WB_REASON_FORKER_THREAD, "forker_thread")
> + EM( WB_REASON_FORKER_THREAD, "forker_thread") \
> + EMe(WB_REASON_FOREIGN_FLUSH, "foreign_flush")
>
> WB_WORK_REASON
>