2021-05-27 00:16:11

by Jeremy Linton

Subject: [PATCH] coresight: Propagate symlink failure

If the symlink is unable to be created, the driver goes
ahead and continues device creation. Instead lets propagate
the failure, and fail the probe.

Signed-off-by: Jeremy Linton <[email protected]>
---
drivers/hwtracing/coresight/coresight-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
index 6c68d34d956e..2dc4b0110442 100644
--- a/drivers/hwtracing/coresight/coresight-core.c
+++ b/drivers/hwtracing/coresight/coresight-core.c
@@ -1392,7 +1392,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev)
}
}

- return 0;
+ return ret;
}

static int coresight_remove_match(struct device *dev, void *data)
--
2.31.1

2021-05-27 23:23:34

by Mathieu Poirier

Subject: Re: [PATCH] coresight: Propagate symlink failure

On Wed, May 26, 2021 at 03:40:42PM -0500, Jeremy Linton wrote:
> If the symlink is unable to be created, the driver goes
> ahead and continues device creation. Instead lets propagate
> the failure, and fail the probe.
>
> Signed-off-by: Jeremy Linton <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 6c68d34d956e..2dc4b0110442 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1392,7 +1392,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev)
> }
> }
>
> - return 0;
> + return ret;

I have applied your patch.

Thanks,
Mathieu

> }
>
> static int coresight_remove_match(struct device *dev, void *data)
> --
> 2.31.1
>