2021-06-17 02:43:50

by Pu Lehui

Subject: [PATCH -next] pstore/blk: Fix return value check in pstore_blk_init()

Fix the return value check which testing the wrong variable
in pstore_blk_init().

Signed-off-by: Pu Lehui <[email protected]>
---
fs/pstore/blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/pstore/blk.c b/fs/pstore/blk.c
index ccfb11ee4d50..d5e22e6209a6 100644
--- a/fs/pstore/blk.c
+++ b/fs/pstore/blk.c
@@ -287,7 +287,7 @@ static int __init pstore_blk_init(void)
struct pstore_device_info *best_effort_dev;

best_effort_dev = kzalloc(sizeof(*best_effort_dev), GFP_KERNEL);
- if (!best_effort) {
+ if (!best_effort_dev) {
ret = -ENOMEM;
goto unlock;
}
--
2.17.1

2021-06-17 03:20:48

by Kees Cook

Subject: Re: [PATCH -next] pstore/blk: Fix return value check in pstore_blk_init()

On Thu, Jun 17, 2021 at 08:54:24AM +0800, Pu Lehui wrote:
> Fix the return value check which testing the wrong variable
> in pstore_blk_init().
>
> Signed-off-by: Pu Lehui <[email protected]>
> ---
> fs/pstore/blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/blk.c b/fs/pstore/blk.c
> index ccfb11ee4d50..d5e22e6209a6 100644
> --- a/fs/pstore/blk.c
> +++ b/fs/pstore/blk.c
> @@ -287,7 +287,7 @@ static int __init pstore_blk_init(void)
> struct pstore_device_info *best_effort_dev;
>
> best_effort_dev = kzalloc(sizeof(*best_effort_dev), GFP_KERNEL);
> - if (!best_effort) {
> + if (!best_effort_dev) {
> ret = -ENOMEM;
> goto unlock;
> }

Whoops; thanks!

--
Kees Cook