2021-10-15 13:20:18

by Jiabing Wan

Subject: [PATCH] MIPS: Loongson64: Add of_node_put() before break

Fix following coccicheck warning:
./arch/mips/loongson64/init.c:174:1-22: WARNING: Function
for_each_node_by_name should have of_node_put() before break

Early exits from for_each_node_by_name should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
arch/mips/loongson64/init.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/mips/loongson64/init.c b/arch/mips/loongson64/init.c
index 4ac5ba80bbf6..ee8de1735b7c 100644
--- a/arch/mips/loongson64/init.c
+++ b/arch/mips/loongson64/init.c
@@ -179,6 +179,7 @@ static __init void reserve_pio_range(void)

if (of_range_parser_init(&parser, np)) {
pr_info("Failed to parse resources.\n");
+ of_node_put(np);
break;
}

--
2.20.1

2021-10-15 13:20:19

by Huacai Chen

Subject: Re: [PATCH] MIPS: Loongson64: Add of_node_put() before break

Reviewed-by: Huacai Chen <[email protected]>

On Fri, Oct 15, 2021 at 3:01 PM Wan Jiabing <[email protected]> wrote:
>
> Fix following coccicheck warning:
> ./arch/mips/loongson64/init.c:174:1-22: WARNING: Function
> for_each_node_by_name should have of_node_put() before break
>
> Early exits from for_each_node_by_name should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> arch/mips/loongson64/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/loongson64/init.c b/arch/mips/loongson64/init.c
> index 4ac5ba80bbf6..ee8de1735b7c 100644
> --- a/arch/mips/loongson64/init.c
> +++ b/arch/mips/loongson64/init.c
> @@ -179,6 +179,7 @@ static __init void reserve_pio_range(void)
>
> if (of_range_parser_init(&parser, np)) {
> pr_info("Failed to parse resources.\n");
> + of_node_put(np);
> break;
> }
>
> --
> 2.20.1
>

2021-10-18 16:22:57

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: Loongson64: Add of_node_put() before break

On Fri, Oct 15, 2021 at 03:01:22AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./arch/mips/loongson64/init.c:174:1-22: WARNING: Function
> for_each_node_by_name should have of_node_put() before break
>
> Early exits from for_each_node_by_name should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> arch/mips/loongson64/init.c | 1 +
> 1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]