2021-10-21 09:48:06

by Jiabing Wan

Subject: [PATCH] net: dsa: sja1105: Add of_node_put() before return

Fix following coccicheck warning:
./drivers/net/dsa/sja1105/sja1105_main.c:1193:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/net/dsa/sja1105/sja1105_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 1832d4bd3440..70ece441b3b8 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -1233,8 +1233,10 @@ static int sja1105_parse_ports_node(struct sja1105_private *priv,
priv->phy_mode[index] = phy_mode;

err = sja1105_parse_rgmii_delays(priv, index, child);
- if (err)
+ if (err) {
+ of_node_put(child);
return err;
+ }
}

return 0;
--
2.20.1

2021-10-22 23:41:02

by Jakub Kicinski

Subject: Re: [PATCH] net: dsa: sja1105: Add of_node_put() before return

On Thu, 21 Oct 2021 05:46:06 -0400 Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/net/dsa/sja1105/sja1105_main.c:1193:1-33: WARNING: Function
> for_each_available_child_of_node should have of_node_put() before return.
>
> Early exits from for_each_available_child_of_node should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Applied, thanks.