2021-11-11 09:12:23

by Krzysztof Kozlowski

Subject: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

Include the header with prototype of s3c2410_modify_misccr to fix W=1
warning:

arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/mach-s3c/gpio-samsung.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
index 76ef415789f2..fda2c01f5a08 100644
--- a/arch/arm/mach-s3c/gpio-samsung.c
+++ b/arch/arm/mach-s3c/gpio-samsung.c
@@ -35,6 +35,7 @@
#include "gpio-core.h"
#include "gpio-cfg.h"
#include "gpio-cfg-helpers.h"
+#include "hardware-s3c24xx.h"
#include "pm.h"

int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
--
2.32.0

2021-11-11 09:47:10

by Arnd Bergmann

Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Thank you for fixing it,

Acked-by: Arnd Bergmann <[email protected]>

If you like, I can put it into the fixes branch of the soc tree directly,
otherwise I expect you'll send it in a pull request later.

Arnd

2021-11-11 09:56:45

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

On 11/11/2021 10:46, Arnd Bergmann wrote:
> On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> Include the header with prototype of s3c2410_modify_misccr to fix W=1
>> warning:
>>
>> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
>> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>>
>> Reported-by: kernel test robot <[email protected]>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Thank you for fixing it,
>
> Acked-by: Arnd Bergmann <[email protected]>
>
> If you like, I can put it into the fixes branch of the soc tree directly,
> otherwise I expect you'll send it in a pull request later.

It's not a serious bug and was there since long time, so maybe let's
send it via regular pull request.


Best regards,
Krzysztof

2021-11-11 16:29:16

by Alim Akhtar

Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

Hi Krzysztof,

On Thu, Nov 11, 2021 at 2:42 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Alim Akhtar <[email protected]>

> arch/arm/mach-s3c/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c
> index 76ef415789f2..fda2c01f5a08 100644
> --- a/arch/arm/mach-s3c/gpio-samsung.c
> +++ b/arch/arm/mach-s3c/gpio-samsung.c
> @@ -35,6 +35,7 @@
> #include "gpio-core.h"
> #include "gpio-cfg.h"
> #include "gpio-cfg-helpers.h"
> +#include "hardware-s3c24xx.h"
> #include "pm.h"
>
> int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
> --
> 2.32.0
>


--
Regards,
Alim

2021-11-11 16:42:09

by Arnd Bergmann

Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

On Thu, Nov 11, 2021 at 10:56 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 11/11/2021 10:46, Arnd Bergmann wrote:
> > On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> > <[email protected]> wrote:
> >>
> >> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> >> warning:
> >>
> >> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> >> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
> >>
> >> Reported-by: kernel test robot <[email protected]>
> >> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >
> > Thank you for fixing it,
> >
> > Acked-by: Arnd Bergmann <[email protected]>
> >
> > If you like, I can put it into the fixes branch of the soc tree directly,
> > otherwise I expect you'll send it in a pull request later.
>
> It's not a serious bug and was there since long time, so maybe let's
> send it via regular pull request.

Ok, sounds good. I was worried for a bit that this would break builds
with CONFIG_WERROR, but of course that is already broken in
many ways with W=1.

Arnd

2021-11-15 13:13:09

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

On Thu, 11 Nov 2021 10:11:23 +0100, Krzysztof Kozlowski wrote:
> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> warning:
>
> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
>
>
> [...]

Applied, thanks!

[1/1] ARM: s3c: include header for prototype of s3c2410_modify_misccr
commit: 90dc0df9168b6c1ddb339481b440d7c13cc4417c

Best regards,
--
Krzysztof Kozlowski <[email protected]>