2021-11-23 08:23:19

by Wei Yongjun

Subject: [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq' static

The sparse tool complains as follows:

drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
symbol 'remove_work_wq' was not declared. Should it be static?

This symbol is not used outside of ipmi_msghandler.c, so
marks it static.

Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/char/ipmi/ipmi_msghandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 1ade72bfae0f..a2ec0171363a 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -191,7 +191,7 @@ struct ipmi_user {
struct work_struct remove_work;
};

-struct workqueue_struct *remove_work_wq;
+static struct workqueue_struct *remove_work_wq;

static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
__acquires(user->release_barrier)

2021-11-23 12:45:19

by Corey Minyard

Subject: Re: [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq' static

On Tue, Nov 23, 2021 at 08:36:18AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
> symbol 'remove_work_wq' was not declared. Should it be static?
>
> This symbol is not used outside of ipmi_msghandler.c, so
> marks it static.

Thanks, I should have noticed this.

-corey

>
> Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 1ade72bfae0f..a2ec0171363a 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -191,7 +191,7 @@ struct ipmi_user {
> struct work_struct remove_work;
> };
>
> -struct workqueue_struct *remove_work_wq;
> +static struct workqueue_struct *remove_work_wq;
>
> static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
> __acquires(user->release_barrier)
>