This series adds compatibles to the dt-bindings documentation where it
was missed before.
Finally, the last patch solves some further dtbs_check errors by
modifying the sm6350.dtsi to match the binding docs more closely.
Please note, that the first patch from Konrad is a resend that wasn't
picked up when sent to the lists in August 2021.
Konrad Dybcio (1):
dt-bindings: arm: msm: Add LLCC for SM6350
Luca Weiss (9):
dt-bindings: firmware: scm: Add SM6350 compatible
dt-bindings: qcom,pdc: Add SM6350 compatible
dt-bindings: phy: qcom,qusb2: Add SM6350 compatible
dt-bindings: thermal: tsens: Add SM6350 compatible
dt-bindings: usb: qcom,dwc3: Add SM6350 compatible
dt-bindings: watchdog: Add SM6350 and SM8250 compatible
dt-bindings: arm: msm: Don't mark LLCC interrupt as required
dt-bindings: simple-framebuffer: allow standalone compatible
arm64: dts: qcom: sm6350: Fix validation errors
.../devicetree/bindings/arm/msm/qcom,llcc.yaml | 2 +-
.../bindings/display/simple-framebuffer.yaml | 12 +++++++-----
.../devicetree/bindings/firmware/qcom,scm.txt | 1 +
.../bindings/interrupt-controller/qcom,pdc.txt | 5 +++--
.../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 1 +
.../devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
.../devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
.../devicetree/bindings/watchdog/qcom-wdt.yaml | 2 ++
arch/arm64/boot/dts/qcom/sm6350.dtsi | 16 ++++++++--------
9 files changed, 25 insertions(+), 16 deletions(-)
--
2.34.1
From: Konrad Dybcio <[email protected]>
Add LLCC compatible for SM6350 SoC.
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
Acked-by: Rob Herring <[email protected]>
Signed-off-by: Luca Weiss <[email protected]>
---
Please note, that this patch is a resend that wasn't picked up when
sent to the lists in August 2021.
Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
index 62fcbd883392..e12fc7999356 100644
--- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
+++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
@@ -24,6 +24,7 @@ properties:
- qcom,sc7180-llcc
- qcom,sc7280-llcc
- qcom,sdm845-llcc
+ - qcom,sm6350-llcc
- qcom,sm8150-llcc
- qcom,sm8250-llcc
--
2.34.1
Add devicetree compatible for pdc on SM6350 SoC.
Also correct the compatibles for sm8250 and sm8350.
Signed-off-by: Luca Weiss <[email protected]>
---
I do have the .txt -> .yaml conversion ready for this but will send
as a separate patch.
.../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
index 98d89e53013d..3b7b1134dea9 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
@@ -21,8 +21,9 @@ Properties:
- "qcom,sc7180-pdc": For SC7180
- "qcom,sc7280-pdc": For SC7280
- "qcom,sdm845-pdc": For SDM845
- - "qcom,sdm8250-pdc": For SM8250
- - "qcom,sdm8350-pdc": For SM8350
+ - "qcom,sm6350-pdc": For SM6350
+ - "qcom,sm8250-pdc": For SM8250
+ - "qcom,sm8350-pdc": For SM8350
- reg:
Usage: required
--
2.34.1
Add devicetree compatible for SCM on SM6350 SoC.
Signed-off-by: Luca Weiss <[email protected]>
---
Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
index d7e3cda8924e..1fc14f64e318 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
@@ -26,6 +26,7 @@ Required properties:
* "qcom,scm-sc7280"
* "qcom,scm-sdm845"
* "qcom,scm-sdx55"
+ * "qcom,scm-sm6350"
* "qcom,scm-sm8150"
* "qcom,scm-sm8250"
* "qcom,scm-sm8350"
--
2.34.1
Newer SoCs like SM6350 or SM8250 don't provide an interrupt for LLCC.
Signed-off-by: Luca Weiss <[email protected]>
Acked-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
index e12fc7999356..03882aac8d2d 100644
--- a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
+++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml
@@ -45,7 +45,6 @@ required:
- compatible
- reg
- reg-names
- - interrupts
additionalProperties: false
--
2.34.1
Add devicetree compatible for the watchdog on SM6350 and SM8250 SoC.
Signed-off-by: Luca Weiss <[email protected]>
Acked-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index ba60bdf1fecc..16c6f82a13ca 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -20,7 +20,9 @@ properties:
- qcom,apss-wdt-sc7280
- qcom,apss-wdt-sdm845
- qcom,apss-wdt-sdx55
+ - qcom,apss-wdt-sm6350
- qcom,apss-wdt-sm8150
+ - qcom,apss-wdt-sm8250
- qcom,kpss-timer
- qcom,kpss-wdt
- qcom,kpss-wdt-apq8064
--
2.34.1
Add devicetree compatible for dwc3 on SM6350 SoC.
Signed-off-by: Luca Weiss <[email protected]>
Acked-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 2bdaba023c01..fb79ea518696 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -23,6 +23,7 @@ properties:
- qcom,sdx55-dwc3
- qcom,sm4250-dwc3
- qcom,sm6115-dwc3
+ - qcom,sm6350-dwc3
- qcom,sm8150-dwc3
- qcom,sm8250-dwc3
- qcom,sm8350-dwc3
--
2.34.1
Add devicetree compatible for the usb phy on SM6350 SoC.
Signed-off-by: Luca Weiss <[email protected]>
Acked-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
index aa2e409a1a09..e651a63a4be3 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
@@ -30,6 +30,7 @@ properties:
- enum:
- qcom,sc7180-qusb2-phy
- qcom,sdm845-qusb2-phy
+ - qcom,sm6350-qusb2-phy
- const: qcom,qusb2-v2-phy
reg:
maxItems: 1
--
2.34.1
Add devicetree compatible for tsens on SM6350 SoC.
Signed-off-by: Luca Weiss <[email protected]>
Acked-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index d3b9e9b600a2..6d48c5ff6bda 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -50,6 +50,7 @@ properties:
- qcom,sc8180x-tsens
- qcom,sdm630-tsens
- qcom,sdm845-tsens
+ - qcom,sm6350-tsens
- qcom,sm8150-tsens
- qcom,sm8250-tsens
- qcom,sm8350-tsens
--
2.34.1
Sort clocks and interrupts as specified in the docs and remove the stray
property #power-domain-cells from aoss_qmp to solve dtbs_check
validation errors.
Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm64/boot/dts/qcom/sm6350.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index a7158fe9e192..8322a981cdfc 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -810,10 +810,10 @@ usb_1_qmpphy: phy@88e9000 {
ranges;
clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>,
+ <&xo_board>,
<&rpmhcc RPMH_QLINK_CLK>,
- <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>,
- <&xo_board>;
- clock-names = "aux", "ref", "com_aux", "cfg_ahb";
+ <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>;
+ clock-names = "aux", "cfg_ahb", "ref", "com_aux";
resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>,
<&gcc GCC_USB3_PHY_PRIM_BCR>;
@@ -871,11 +871,12 @@ usb_1: usb@a6f8800 {
"sleep";
interrupts-extended = <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
- <&pdc 14 IRQ_TYPE_EDGE_BOTH>,
+ <&pdc 17 IRQ_TYPE_LEVEL_HIGH>,
<&pdc 15 IRQ_TYPE_EDGE_BOTH>,
- <&pdc 17 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "hs_phy_irq", "dp_hs_phy_irq",
- "dm_hs_phy_irq", "ss_phy_irq";
+ <&pdc 14 IRQ_TYPE_EDGE_BOTH>;
+
+ interrupt-names = "hs_phy_irq", "ss_phy_irq",
+ "dm_hs_phy_irq", "dp_hs_phy_irq";
power-domains = <&gcc USB30_PRIM_GDSC>;
@@ -935,7 +936,6 @@ aoss_qmp: power-controller@c300000 {
mboxes = <&ipcc IPCC_CLIENT_AOP IPCC_MPROC_SIGNAL_GLINK_QMP>;
#clock-cells = <0>;
- #power-domain-cells = <1>;
};
spmi_bus: spmi@c440000 {
--
2.34.1
Qualcomm platforms use "simple-framebuffer" without a more specific
compatible. Allow that in the binding doc.
Signed-off-by: Luca Weiss <[email protected]>
---
.../bindings/display/simple-framebuffer.yaml | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
index c2499a7906f5..2d82d0ce4a34 100644
--- a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
+++ b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml
@@ -52,11 +52,13 @@ description: |+
properties:
compatible:
- items:
- - enum:
- - apple,simple-framebuffer
- - allwinner,simple-framebuffer
- - amlogic,simple-framebuffer
+ oneOf:
+ - items:
+ - enum:
+ - apple,simple-framebuffer
+ - allwinner,simple-framebuffer
+ - amlogic,simple-framebuffer
+ - const: simple-framebuffer
- const: simple-framebuffer
reg:
--
2.34.1
On 13-12-21, 09:26, Luca Weiss wrote:
> Add devicetree compatible for the usb phy on SM6350 SoC.
Applied to phy-next, thanks
--
~Vinod
On Mon, 13 Dec 2021 09:26:03 +0100, Luca Weiss wrote:
> Add devicetree compatible for SCM on SM6350 SoC.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <[email protected]>
On Mon, 13 Dec 2021 09:26:04 +0100, Luca Weiss wrote:
> Add devicetree compatible for pdc on SM6350 SoC.
>
> Also correct the compatibles for sm8250 and sm8350.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> I do have the .txt -> .yaml conversion ready for this but will send
> as a separate patch.
>
> .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Mon, 13 Dec 2021 09:26:06 +0100, Luca Weiss wrote:
> Add devicetree compatible for tsens on SM6350 SoC.
>
> Signed-off-by: Luca Weiss <[email protected]>
> Acked-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <[email protected]>
On Mon, 13 Dec 2021 09:26:07 +0100, Luca Weiss wrote:
> Add devicetree compatible for dwc3 on SM6350 SoC.
>
> Signed-off-by: Luca Weiss <[email protected]>
> Acked-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <[email protected]>
On Mon, 13 Dec 2021 09:26:08 +0100, Luca Weiss wrote:
> Add devicetree compatible for the watchdog on SM6350 and SM8250 SoC.
>
> Signed-off-by: Luca Weiss <[email protected]>
> Acked-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
On Mon, 13 Dec 2021 09:26:09 +0100, Luca Weiss wrote:
> Newer SoCs like SM6350 or SM8250 don't provide an interrupt for LLCC.
>
> Signed-off-by: Luca Weiss <[email protected]>
> Acked-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/msm/qcom,llcc.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Mon, 13 Dec 2021 09:26:10 +0100, Luca Weiss wrote:
> Qualcomm platforms use "simple-framebuffer" without a more specific
> compatible. Allow that in the binding doc.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> .../bindings/display/simple-framebuffer.yaml | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Mon, 13 Dec 2021 09:26:01 +0100, Luca Weiss wrote:
> This series adds compatibles to the dt-bindings documentation where it
> was missed before.
>
> Finally, the last patch solves some further dtbs_check errors by
> modifying the sm6350.dtsi to match the binding docs more closely.
>
> Please note, that the first patch from Konrad is a resend that wasn't
> picked up when sent to the lists in August 2021.
>
> [...]
Applied, thanks!
[10/10] arm64: dts: qcom: sm6350: Fix validation errors
commit: f56498fc6a9364a35dd74af791bd1251467e9cc1
Best regards,
--
Bjorn Andersson <[email protected]>
Hi all,
On Wed Dec 15, 2021 at 9:10 PM CET, Rob Herring wrote:
> On Mon, 13 Dec 2021 09:26:06 +0100, Luca Weiss wrote:
> > Add devicetree compatible for tsens on SM6350 SoC.
> >
> > Signed-off-by: Luca Weiss <[email protected]>
> > Acked-by: Konrad Dybcio <[email protected]>
> > ---
> > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Acked-by: Rob Herring <[email protected]>
It looks like this patch hasn't been applied yet. Could the responsible
maintainer please pick it up?
Regards
Luca
On Fri, Apr 08, 2022 at 01:25:26PM +0200, Luca Weiss wrote:
> Hi all,
>
> On Wed Dec 15, 2021 at 9:10 PM CET, Rob Herring wrote:
> > On Mon, 13 Dec 2021 09:26:06 +0100, Luca Weiss wrote:
> > > Add devicetree compatible for tsens on SM6350 SoC.
> > >
> > > Signed-off-by: Luca Weiss <[email protected]>
> > > Acked-by: Konrad Dybcio <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> >
> > Acked-by: Rob Herring <[email protected]>
>
> It looks like this patch hasn't been applied yet. Could the responsible
> maintainer please pick it up?
Normally that should be the thermal maintainers, but I've applied this.
Rob
On Fri, Apr 08, 2022 at 01:24:43PM +0200, Luca Weiss wrote:
> Hi all,
>
> On Wed Dec 15, 2021 at 9:10 PM CET, Rob Herring wrote:
> > On Mon, 13 Dec 2021 09:26:04 +0100, Luca Weiss wrote:
> > > Add devicetree compatible for pdc on SM6350 SoC.
> > >
> > > Also correct the compatibles for sm8250 and sm8350.
> > >
> > > Signed-off-by: Luca Weiss <[email protected]>
> > > ---
> > > I do have the .txt -> .yaml conversion ready for this but will send
> > > as a separate patch.
> > >
> > > .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> >
> > Acked-by: Rob Herring <[email protected]>
>
> It looks like this patch hasn't been applied yet. Could the responsible
> maintainer please pick it up?
Applied.
Rob
On 08/04/2022 16:28, Rob Herring wrote:
> On Fri, Apr 08, 2022 at 01:25:26PM +0200, Luca Weiss wrote:
>> Hi all,
>>
>> On Wed Dec 15, 2021 at 9:10 PM CET, Rob Herring wrote:
>>> On Mon, 13 Dec 2021 09:26:06 +0100, Luca Weiss wrote:
>>>> Add devicetree compatible for tsens on SM6350 SoC.
>>>>
>>>> Signed-off-by: Luca Weiss <[email protected]>
>>>> Acked-by: Konrad Dybcio <[email protected]>
>>>> ---
>>>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>
>>> Acked-by: Rob Herring <[email protected]>
>>
>> It looks like this patch hasn't been applied yet. Could the responsible
>> maintainer please pick it up?
>
> Normally that should be the thermal maintainers, but I've applied this.
Right, I missed it, thanks for taking care of the patch.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Hi all,
On Wed Dec 15, 2021 at 9:10 PM CET, Rob Herring wrote:
> On Mon, 13 Dec 2021 09:26:04 +0100, Luca Weiss wrote:
> > Add devicetree compatible for pdc on SM6350 SoC.
> >
> > Also correct the compatibles for sm8250 and sm8350.
> >
> > Signed-off-by: Luca Weiss <[email protected]>
> > ---
> > I do have the .txt -> .yaml conversion ready for this but will send
> > as a separate patch.
> >
> > .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> Acked-by: Rob Herring <[email protected]>
It looks like this patch hasn't been applied yet. Could the responsible
maintainer please pick it up?
Regards
Luca