2022-02-24 16:01:08

by Geert Uytterhoeven

Subject: [PATCH] clk: COMMON_CLK_LAN966X should depend on SOC_LAN966

The LAN966x Generic Clock Controller is only present on Microchip
LAN966x SoCs. Hence add a dependency on SOC_LAN966, to prevent asking
the user about this driver when configuring a kernel without LAN966x SoC
support.

Fixes: 54104ee023333e3b ("clk: lan966x: Add lan966x SoC clock driver")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/clk/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index c390e26dadf471f5..1c82a3e1129d4342 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -232,6 +232,7 @@ config COMMON_CLK_GEMINI

config COMMON_CLK_LAN966X
bool "Generic Clock Controller driver for LAN966X SoC"
+ depends on SOC_LAN966 || COMPILE_TEST
help
This driver provides support for Generic Clock Controller(GCK) on
LAN966X SoC. GCK generates and supplies clock to various peripherals
--
2.25.1

2022-03-09 01:54:27

by Nicolas Ferre

Subject: Re: [PATCH] clk: COMMON_CLK_LAN966X should depend on SOC_LAN966

On 24/02/2022 at 16:29, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The LAN966x Generic Clock Controller is only present on Microchip
> LAN966x SoCs. Hence add a dependency on SOC_LAN966, to prevent asking
> the user about this driver when configuring a kernel without LAN966x SoC
> support.
>
> Fixes: 54104ee023333e3b ("clk: lan966x: Add lan966x SoC clock driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Horatiu, Kavyasree,
We probably need your view on this.

Best regards,
Nicolas

> ---
> drivers/clk/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c390e26dadf471f5..1c82a3e1129d4342 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -232,6 +232,7 @@ config COMMON_CLK_GEMINI
>
> config COMMON_CLK_LAN966X
> bool "Generic Clock Controller driver for LAN966X SoC"
> + depends on SOC_LAN966 || COMPILE_TEST
> help
> This driver provides support for Generic Clock Controller(GCK) on
> LAN966X SoC. GCK generates and supplies clock to various peripherals
> --
> 2.25.1
>


--
Nicolas Ferre

2022-03-09 01:58:43

by Horatiu Vultur

Subject: Re: [PATCH] clk: COMMON_CLK_LAN966X should depend on SOC_LAN966

The 02/24/2022 16:29, Geert Uytterhoeven wrote:
>
> The LAN966x Generic Clock Controller is only present on Microchip
> LAN966x SoCs. Hence add a dependency on SOC_LAN966, to prevent asking
> the user about this driver when configuring a kernel without LAN966x SoC
> support.

Reviewed-by: Horatiu Vultur <[email protected]>

>
> Fixes: 54104ee023333e3b ("clk: lan966x: Add lan966x SoC clock driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/clk/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c390e26dadf471f5..1c82a3e1129d4342 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -232,6 +232,7 @@ config COMMON_CLK_GEMINI
>
> config COMMON_CLK_LAN966X
> bool "Generic Clock Controller driver for LAN966X SoC"
> + depends on SOC_LAN966 || COMPILE_TEST
> help
> This driver provides support for Generic Clock Controller(GCK) on
> LAN966X SoC. GCK generates and supplies clock to various peripherals
> --
> 2.25.1
>

--
/Horatiu

2022-03-12 08:45:08

by Stephen Boyd

Subject: Re: [PATCH] clk: COMMON_CLK_LAN966X should depend on SOC_LAN966

Quoting Geert Uytterhoeven (2022-02-24 07:29:17)
> The LAN966x Generic Clock Controller is only present on Microchip
> LAN966x SoCs. Hence add a dependency on SOC_LAN966, to prevent asking
> the user about this driver when configuring a kernel without LAN966x SoC
> support.
>
> Fixes: 54104ee023333e3b ("clk: lan966x: Add lan966x SoC clock driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---

Applied to clk-next