2022-05-04 08:18:56

by Robert Marko

Subject: [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells

IPQ6018 and IPQ8074 require #clock-cells to be set to 1 as their APSS
clock driver provides multiple clock outputs.

So allow setting 1 as #clock-cells and check that its set to 1 for IPQ6018
and IPQ8074, check others for 0 as its currently.

Signed-off-by: Robert Marko <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
Changes in v2:
* Correct subject name
---
.../mailbox/qcom,apcs-kpss-global.yaml | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 3b5ba7ecc19d..1f803925867e 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -50,7 +50,7 @@ properties:
const: 1

'#clock-cells':
- const: 0
+ enum: [0, 1]

clock-names:
minItems: 2
@@ -96,6 +96,22 @@ allOf:
properties:
clocks:
maxItems: 3
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,ipq6018-apcs-apps-global
+ - qcom,ipq8074-apcs-apps-global
+ then:
+ properties:
+ '#clock-cells':
+ const: 1
+
+ else:
+ properties:
+ '#clock-cells':
+ const: 0
+
examples:

# Example apcs with msm8996
--
2.35.1

2022-05-08 09:20:30

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells

On 03/05/2022 21:56, Robert Marko wrote:
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 3b5ba7ecc19d..1f803925867e 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -50,7 +50,7 @@ properties:
> const: 1
>
> '#clock-cells':
> - const: 0
> + enum: [0, 1]
>
> clock-names:
> minItems: 2
> @@ -96,6 +96,22 @@ allOf:
> properties:
> clocks:
> maxItems: 3
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,ipq6018-apcs-apps-global
> + - qcom,ipq8074-apcs-apps-global
> + then:
> + properties:
> + '#clock-cells':
> + const: 1
> +

If there is a respin, please drop this blank line.

> + else:
> + properties:
> + '#clock-cells':
> + const: 0
> +
> examples:
>
> # Example apcs with msm8996


Best regards,
Krzysztof

2022-05-09 02:01:36

by Robert Marko

Subject: Re: [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells

On Thu, 5 May 2022 at 10:37, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 03/05/2022 21:56, Robert Marko wrote:
> > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > index 3b5ba7ecc19d..1f803925867e 100644
> > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > @@ -50,7 +50,7 @@ properties:
> > const: 1
> >
> > '#clock-cells':
> > - const: 0
> > + enum: [0, 1]
> >
> > clock-names:
> > minItems: 2
> > @@ -96,6 +96,22 @@ allOf:
> > properties:
> > clocks:
> > maxItems: 3
> > + - if:
> > + properties:
> > + compatible:
> > + enum:
> > + - qcom,ipq6018-apcs-apps-global
> > + - qcom,ipq8074-apcs-apps-global
> > + then:
> > + properties:
> > + '#clock-cells':
> > + const: 1
> > +
>
> If there is a respin, please drop this blank line.

Done as part of v3, thanks.

Regards,
Robert
>
> > + else:
> > + properties:
> > + '#clock-cells':
> > + const: 0
> > +
> > examples:
> >
> > # Example apcs with msm8996
>
>
> Best regards,
> Krzysztof