2022-05-18 04:58:44

by Jiabing Wan

Subject: [PATCH] ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all

Fix following coccicheck error:
./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671.

Here should be 'cp' rather than 'ip'.

Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock")
Signed-off-by: Wan Jiabing <[email protected]>
---
sound/usb/endpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index df5a70013a85..f9c921683948 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -1668,7 +1668,7 @@ void snd_usb_endpoint_free_all(struct snd_usb_audio *chip)
kfree(ip);

list_for_each_entry_safe(cp, cn, &chip->clock_ref_list, list)
- kfree(ip);
+ kfree(cp);
}

/*
--
2.36.1

2022-05-18 05:32:25

by Takashi Iwai

Subject: Re: [PATCH] ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all

On Wed, 18 May 2022 04:16:16 +0200,
Wan Jiabing wrote:
>
> Fix following coccicheck error:
> ./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671.
>
> Here should be 'cp' rather than 'ip'.
>
> Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock")
> Signed-off-by: Wan Jiabing <[email protected]>

Oh, that was a silly failure.
Applied now, thanks!


Takashi